October 2017 - Koha-bugs - lists.koha-community.org

[Bug 11976] show issue date instead of received date for serials in opac
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 David Bourgault <david.bourgault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67615|0 |1 is obsolete| | Attachment #67964|0 |1 is obsolete| | --- Comment #12 from David Bourgault <david.bourgault(a)inlibro.com> --- Created attachment 68192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68192&action=ed… Bug 11976 - Choose date to display Allows choosing between publication date or receival date (or both) for serials information in the OPAC. Test plan : 0) If you have no serials : a) Create a subscription b) Receive the item, making sure to have a different publication and receival date 1) Visit the OPAC details page for the item you've created 2) Without the patch only the receival date will be displayed 3) Apply patch 4) Run installer/data/mysql/updatedatabase.pl 5) With the patch the publication date and the receival date will be displayed. This can be changed to either (or both) with the 'OPACSerialDisplayPublishedDate' system preference. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11976] show issue date instead of received date for serials in opac
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 David Bourgault <david.bourgault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19289 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Jon Knight <J.P.Knight(a)lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60570|0 |1 is obsolete| | --- Comment #32 from Jon Knight <J.P.Knight(a)lboro.ac.uk> --- Created attachment 68187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68187&action=ed… Bug 13287: QA Follow up Added missing upgrade SQL system preference. Corrected system preference screen message Fixes on purge_suggestions.pl - perlcritic friendlier - address $PERL5LIB comment by using $PROGRAM_NAME (comment #10) - used STDERR (comment #10) - perltidy TEST PLAN --------- $ ./installer/data/mysql/updatedatabase.pl -- should run upgrade and generate new systempreference in table $ ./misc/cronjobs/purge_suggestions.pl --help -- should give help with a real path used instead of $PERL5LIB. $ ./misc/cronjobs/purge_suggestions.pl -days -1 -- should give error message as expected $ ./misc/cronjobs/purge_suggestions.pl -days 0 -- should give error message as expected Go to OPAC system preferences tab and check the PurgeSuggestionsOlderThan system preference -- message should be as expected (see comment #9) run koha qa test tools -- all should pass Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jon Knight <J.P.Knight(a)lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #116 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 68186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68186&action=ed… Bug 7317: Add unit tests & fix, add comments to Illrequest.pm. * Koha/Illrequest.pm: Add code commentary. (_backend_capability): We need to invoke our code ref. * t/db_dependent/Illrequest/Config.t: Improve tests. * t/db_dependent/Illrequestattributes.t: Improve tests. * t/db_dependent/Illrequests.t: Improve tests. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #115 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 68185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68185&action=ed… Bug 7317: Remove obsolete files. The tests files will be replaced with t/db_dependent/Illrequests.t. Dummy backend files are now in their own repository. * Koha/Illrequest/Backend/Dummy/Base.pm: Delete. * t/db_dependent/Illrequest.t: Delete. * t/db_dependent/Illrequest/Dummy.t: Delete. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com --- Comment #57 from M. Tompsett <mtompset(a)hotmail.com> --- Trying to test acquisition change... having difficulties. I don't think it is a code issue. BTW, Additional fields does look okay for a circulation Z39.50 search. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #56 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 67314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67314 Bug 12747 - Corrections on QA feedback Review of attachment 67314: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=127…) ----------------------------------------------------------------- ::: C4/Breeding.pm @@ -224,5 @@ > - @servers = (); > - foreach my $id (@id) { > - push @servers, {id => $id}; > - } > - Why was this removed? Did you add it before? @@ +344,5 @@ > + > + return $row; > +} > + > +sub _add_custom_field_rowdata Nice extraction. ::: installer/data/mysql/sysprefs.sql @@ +9,2 @@ > ('AdditionalFieldsInZ3950ResultSearch', '', NULL, 'Determines which MARC field/subfields are displayed in -Additional field- column in the result of a search Z3950', 'Free'), > +('AddressFormat','us','us|de|fr','Choose format to display postal addresses', 'Choice'), Intermediate patches dealing with rebases makes this look like a mistake. Squashing is frequently a good idea where possible. ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt @@ +133,4 @@ > <th>Author</th> > <th>ISBN</th> > <th>LCCN</th> > + [% IF Koha.Preference('AdditionalFieldsInZ3950ResultSearch') != '' %] Length, != ''... okay, this is better. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 David Bourgault <david.bourgault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|philippe.blouin(a)inlibro.com |david.bourgault(a)inlibro.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #55 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 66589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66589 Bug12747 - Small fix for add this field correctly in cataloging module Review of attachment 66589: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=127…) ----------------------------------------------------------------- I don't see the point of this patch. If the issue was adding 000, then check length. Less parameters is always better. -- You are receiving this mail because: You are watching all bug changes.

1 0