October 2017 - Koha-bugs - lists.koha-community.org

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #54 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 66588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66588 Bug12747 - Follow-up to QA Review of attachment 66588: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=127…) ----------------------------------------------------------------- ::: t/db_dependent/Breeding.t @@ +195,5 @@ > + > +sub test_add_rowdata { > + > + my $old_preference = C4::Context->preference("AdditionalFieldsInZ3950ResultSearch"); > + C4::Context->set_preference("AdditionalFieldsInZ3950ResultSearch",""); It would be better to mock the preference, so that failure would not affect the database. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #53 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 66587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66587 Bug 12747 - Add extra column in Z3950 search result Review of attachment 66587: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=127…) ----------------------------------------------------------------- ::: C4/Breeding.pm @@ +362,4 @@ > my @addnumberfields; > foreach (@addnumber_array) { > my $length = length($_); > my $adTag = substr($_, 0, 3); If the field is: 100$a 245$a 700$a Then why aren't you: my @fields_to_add = split / /, $pref_addnumber; And inside the the loop: foreach my $field (@fields_to_add) { my ($tag,$subtags) = split |\$|, $field; You are making an assumption that the user won't type something bad like 20$a instead of 020$a. Notice my use of $subtags, because that would be the 'abc' or whatever was set. my @subtags = split //,$subtags; # I believe this splits each character out. foreach my $subtag (@subtags) { substr() calculations are just messy and slow. @@ +385,5 @@ > + my $subfields_text = $field->as_string(); > + push(@addnumberfields, $_); > + $row->{$_} = $subfields_text; > + } > + } And then all this logic could be optimized. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9573] Ability to download items lost report
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #8) > The patch appears to break the list of checkouts in the patron account: > > Error: Syntax error, unrecognized expression: ##issues-table Indeed, I git grepped on **/*.tt but there was an occurrence in a .js file. Thanks for the catch! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9573] Ability to download items lost report
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 --- Comment #9 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 68184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68184&action=ed… Bug 9573: (follow-up) Lost items report - add KohaTable to itemlost -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19472] New: Add perl extension to borrowers-force-messaging-defaults
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19472 Bug ID: 19472 Summary: Add perl extension to borrowers-force-messaging-defaults Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz See bug 13572 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9

[Bug 13572] Add actives parameter to force_borrower_messaging_defaults script
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13572] Add actives parameter to force_borrower_messaging_defaults script
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572 --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 68183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68183&action=ed… Bug 13572: Patrons are still active if their expiry date is today -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #52 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 66586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66586 Bug 12747 - Add extra column in Z3950 search Review of attachment 66586: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=127…) ----------------------------------------------------------------- ::: C4/Breeding.pm @@ +365,5 @@ > + my $fieldContent=''; > + if ($length > 3){ > + my $adSubfield; > + for (my $i=0; $i<$length-3; $i++){ > + $adSubfield = substr($_, 3+$i, 1); When you have nested loops, one should avoid $_ and be explicit (on line 359) to improve readability and prevent accidental breakage later. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15259] Formatting spine labels
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15259 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2500] Standing enhancement request for adding/ updating call number splitting algorithms in C4/Labels.pm
by bugzilla-daemon＠bugs.koha-community.org 16 Oct '17

16 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2500 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

1 0