October 2017 - Koha-bugs - lists.koha-community.org

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '17

09 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #25 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Tomas, what I meant is that the table displays dail limit = 0 for all circulation conditions existing pre-update. If 0 means unlimited it should display as such. If 0 means 0 we should fix the existing rules on update so they still work. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '17

09 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #24 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Katrin Fischer from comment #17) > 1) Translations in mind, I suggest to make the message a bit more specific: > Daily limit reached for patron > > Daily hold limit reached for patron Fixed, thanks! > 2) If nothing is entered, it appears to default to 0 (instead of unlimited). > So I think this will break existing installations. I'd suggest to copy the > max holds total into max holds daily. This is intended, on purpose! Its the same behaviour allowedreserves has. 0 and undef mean the same in the code. If no daily (or zero) limit is defined, then the global one is used > 3) The tests are giving me trouble: > kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Holds.t > t/db_dependent/Holds.t .. 26/59 # Looks like you planned 59 tests but ran 56. > t/db_dependent/Holds.t .. Dubious, test returned 255 (wstat 65280, 0xff00) > Failed 3/59 subtests Fixed it, I guess some recent changes in Holds.t made this. Tests should pass noW! Thanks for the feedback! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '17

09 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67207|0 |1 is obsolete| | --- Comment #23 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 67845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67845&action=ed… Bug 15486: Modify request.tt to handle the new error string This patch makes reserve/request.pl display a convenient error description when a hold cannot be placed due to the new daily limit configuration. To test: - Apply this patchset - Upgrade - Configure your circulation rules so there's a daily limit for holds - Place holds so the patron reaches the maximum - Place one more hold - Notice the hold cannot be placed and a convenient error message is displayed. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '17

09 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67206|0 |1 is obsolete| | --- Comment #22 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 67844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67844&action=ed… Bug 15486: Extend CanItemBeReserved so it handles daily holds limits This patch implements the required changes in C4::Reserves::CanItemBeReserved so it implements a daily limit on holds. It returns the 'tooManyReservesToday' string if the policy doesn't allow placing the hold. It returns 'OK' (current behaviour) otherwise. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Holds.t => FAIL: Tests fail because the error condition is not making CanItemBeReserved return the desired error code. - Apply this patch - Run: k$ prove t/db_dependent/Holds.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '17

09 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67205|0 |1 is obsolete| | --- Comment #21 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 67843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67843&action=ed… Bug 15486: Unit tests This patch introduces unit tests for the new circulation rules option that allows setting a max holds per day limit. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Holds.t => FAIL: CanItemBeReserved doesn't check the amount of holds per day and the introduced error code is not returned. OK is returned instead. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '17

09 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67204|0 |1 is obsolete| | --- Comment #20 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 67842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67842&action=ed… Bug 15486: Make circ rules UI handle holds_per_day This patch makes the staff UI correctly handle the holds_per_day configuration. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '17

09 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67203|0 |1 is obsolete| | --- Comment #19 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 67841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67841&action=ed… Bug 15486: DBIC update schema -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '17

09 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67202|0 |1 is obsolete| | --- Comment #18 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 67840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67840&action=ed… Bug 15486: DB structure change This patch adds a new column __max_holds_per_day__ to the issuingrules table. It's going to be used to set a daily limit for holds. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '17

09 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Michael Kuhn <mik(a)adminkuhn.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mik(a)adminkuhn.ch | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13766] Make biblioitems.ean longer and add index
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '17

09 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 --- Comment #22 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #21) > I think the most common use case is using deleted* in a union with the > undeleted table. But I am not sure if the index has a positive effect then > or not. Depends on use in ORDER BY or WHERE etc. -- You are receiving this mail because: You are watching all bug changes.

1 0