October 2017 - Koha-bugs - lists.koha-community.org

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |katrin.fischer(a)bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Code looks good, but there is a bigger conflict in the test file I am not sure about, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15494 - Unit tests Using index info to reconstruct a base tree... M t/db_dependent/Circulation.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Circulation.t CONFLICT (content): Merge conflict in t/db_dependent/Circulation.t error: Failed to merge in the changes. Patch failed at 0001 Bug 15494 - Unit tests The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15494---Unit-tests-pu3VeI.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14866] Make high holds work with different item types and number of open days
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |katrin.fischer(a)bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Patch no longer applies, can you please rebase? It also seems to be missing tests? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14866: Make high holds work with different item types .git/rebase-apply/patch:80: trailing whitespace. <td>[% rule.decreaseloanholds %]</td> warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M C4/Circulation.pm M admin/smart-rules.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt .git/rebase-apply/patch:80: trailing whitespace. <td>[% rule.decreaseloanholds %]</td> warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Auto-merging admin/smart-rules.pl CONFLICT (content): Merge conflict in admin/smart-rules.pl Auto-merging C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14866: Make high holds work with different item types The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14866-Make-high-holds-work-with-different-item-RnFis7.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi David, I've tried several things, but I think we are missing something in the test plan. That's what I've tried and I've always seen a message on check-in: 1) Created an manual indefinite restriction for the patron. 2) Created a manual restriction with a date in 2 weeks. Question: - You say checkout and checkin - I can only do so by overwriting the restriction temporarily. Is that what you do as well? - You say fines by days should be 0. I was testing with a manual restriction, should this be a restriction of a certain type? If you want suspension, why then fines in days = 0? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14746] Set up logging and configuration file reading for Mojolicious
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14746 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Patch currently has a conflict in a file, but should not be hard to resolve. How can this be tested? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14746: Set up logging and configuration file reading for Mojolicious Using index info to reconstruct a base tree... M Koha/REST/V1.pm Falling back to patching base and 3-way merge... Auto-merging Koha/REST/V1.pm CONFLICT (content): Merge conflict in Koha/REST/V1.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14746: Set up logging and configuration file reading for Mojolicious The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14746-Set-up-logging-and-configuration-file-re-pH4w1p.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14919] Holds history for patron
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 --- Comment #16 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Katrin Fischer from comment #14) > Hi Joseph, can you sign off my follow-up and switch status to signed off if > it's ok? Done, thanks for the followup! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14919] Holds history for patron
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67811|0 |1 is obsolete| | --- Comment #15 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 67818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67818&action=ed… Bug 14919: (follow-up) Fixing some typos and adding to pref description - Adds 'holds' to pref description of intranetreadinghistory - Fixes typo in link to holds history from patron account - Changes reserve date to hold date in table heading Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14919] Holds history for patron
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] results per page setting for catalog search in staff client and opac
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Status|Needs Signoff |Patch doesn't apply --- Comment #33 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Patch doesn't apply anymore, but this sounds like an interesting feature. Can someone rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14715: results per page setting for catalog search Using index info to reconstruct a base tree... M C4/Search.pm M catalogue/search.pl M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt M opac/opac-search.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-search.pl CONFLICT (content): Merge conflict in opac/opac-search.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Auto-merging catalogue/search.pl CONFLICT (content): Merge conflict in catalogue/search.pl Auto-merging C4/Search.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14715: results per page setting for catalog search The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14715-results-per-page-setting-for-catalog-sea-nZTnir.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12902] Cronjob monitoring script, nagios3 compatible
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12902 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Patch still applies, but I don't know how to test this. Someone using Nagios maybe? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- 1) Translations in mind, I suggest to make the message a bit more specific: Daily limit reached for patron > Daily hold limit reached for patron 2) If nothing is entered, it appears to default to 0 (instead of unlimited). So I think this will break existing installations. I'd suggest to copy the max holds total into max holds daily. 3) The tests are giving me trouble: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. 26/59 # Looks like you planned 59 tests but ran 56. t/db_dependent/Holds.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 3/59 subtests Test Summary Report ------------------- t/db_dependent/Holds.t (Wstat: 65280 Tests: 56 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 59 tests but ran 56. Files=1, Tests=56, 2 wallclock secs ( 0.02 usr 0.01 sys + 1.70 cusr 0.34 csys = 2.07 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

1 0