October 2017 - Koha-bugs - lists.koha-community.org

[Bug 13205] Last/First page options for result list paging
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 --- Comment #20 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 67777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67777&action=ed… Bug 13205: [FOLLOW-UP] Fixing math and variable names Have changed my $last_page = $pages * ( $results_per_page - 1 ); to my $last_page = ( $pages - 1) * $results_per_page; which seems to fix the 'last' button offset! (Comment 10) Will add the box to jump to a page in a separate patch. Adding the pagination to the top on the staff client will be dealt with in Bug 18916 as it is slightly out of the scope of this bug. Signed-off-by: Lee Jamison <ldjamison(a)marywood.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13205] Last/First page options for result list paging
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 --- Comment #19 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 67776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67776&action=ed… Bug 13205: [FOLLOW-UP] Some extra logic See Comment 8. Test: When on first page of results, confirm that the 'First' and 'Previous' buttons do not show. Confirm they come back on the second page and every page after. When on last page of results, confirm that the 'Last' and 'Next' buttons do not show. Confirm they come back on all previous pages. Check on both staff side and OPAC. Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison <ldjamison(a)marywood.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13205] Last/First page options for result list paging
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 --- Comment #18 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 67775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67775&action=ed… Bug 13205: Last/first page options for result list paging for OPAC Same fix but on OPAC side. Same test plan Sponsored-by: Catalyst IT Signed-off-by: Dilan Johnpulle <dilan(a)calyx.net.au> Signed-off-by: Your Full Name <your_email> Signed-off-by: Lee Jamison <ldjamison(a)marywood.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13205] Last/First page options for result list paging
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64981|0 |1 is obsolete| | Attachment #64982|0 |1 is obsolete| | Attachment #64983|0 |1 is obsolete| | Attachment #64984|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 67774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67774&action=ed… Bug 13205: Last/first page options for result list paging This patch adds first and last page buttons to the pagination at the bottom of a page of catalog search results. To test: 1) Apply patch 2) Do a number of searches 3) For each search, ensure that the first and last page buttons work as expected Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Lee Jamison <ldjamison(a)marywood.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13205] Last/First page options for result list paging
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13205] Last/First page options for result list paging
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64938|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13205] Last/First page options for result list paging
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64670|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13205] Last/First page options for result list paging
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61194|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13205] Last/First page options for result list paging
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com Attachment #60248|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13208] More complete breadcrumbs when cancelling an order
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #35 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 67772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67772&action=ed… Bug 13208: [FOLLOW-UP] Tests for Koha::Acquisition::Baskets To test: prove -v t/db_dependent/Koha/Acquisition/Baskets.t Signed-off-by: David Bourgault <david.bourgault(a)inlibro.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0