October 2017 - Koha-bugs - lists.koha-community.org

[Bug 14620] Contact information validations
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61843|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 67812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67812&action=ed… Bug 14620: Contact information validations This patch adds a phone number validation by regex and centralizes different validation methods into Koha::Validation class. Introduces a new system preference, ValidatePhoneNumber, that takes a regular expression and uses it to validate phone numbers both client and server side. Unit tests to test: 1. prove t/db_dependent/Koha/Validation.t To test: 1. Apply the patches and run updatedatabase.pl to install the new system preference 2. Set system preference ValidatePhoneNumber to any regex you like (there is an example in the description of the preference) 3. Navigate to edit user contact informations in Staff client and OPAC. 4. Insert invalid email (e.g. "invalid") and invalid phone number ("+123invalid") and send the form. 5. Confirm that form will not be submitted and errors will be given. 6. Disable JavaScript and test that these errors will also be provided by the server. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14620] Contact information validations
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #23 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- There are some complaints from the QA tool: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt FAIL forbidden patterns forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 233) OK git manipulation OK spelling OK tt_valid OK valid_template FAIL Koha/Validation.pm OK critic FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK git manipulation OK pod OK pod coverage OK spelling OK valid Tests pass, database update is ok. Reattaching the rebased patch and a tiny follow-up with a suggestion for better system preference formatting. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14620] Contact information validations
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #22 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Had a conflict, think I fixed it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14590] Validate messaging preferences
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |BLOCKED --- Comment #20 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Sorry, I had missed the dependency on bug 14620, but this also doesn't apply. Marking this one 'blocked' and the other 'doesn't apply'. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14590] Validate messaging preferences
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Status|Needs Signoff |Patch doesn't apply --- Comment #19 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I am sorry, this does no longer apply: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14590: Validate messaging preferences .git/rebase-apply/patch:663: trailing whitespace. print scalar ($destination eq "circ") ? error: sha1 information is lacking or useless (Koha/Validation.pm). error: could not build fake ancestor Patch failed at 0001 Bug 14590: Validate messaging preferences The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14590-Validate-messaging-preferences-JMLoUs.patch >From eyeballing the code I was wondering if you only check 'primary email' and don't take AutoEmailPrimaryAddress into account? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #32 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Patch doesn't apply, not sure how to fix, sorry! Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13952: Import and export authority types Using index info to reconstruct a base tree... M admin/import_export_framework.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt Auto-merging admin/import_export_framework.pl CONFLICT (content): Merge conflict in admin/import_export_framework.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 13952: Import and export authority types The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-13952-Import-and-export-authority-types-CLgCHQ.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #57 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Sorry, patch no longer applies :( Bug 12446 - Enable an adult to have a guarantor 64794 - Bug 12446 - Enable an adult to have a guarantor 64828 - Bug 12446 - Added a missing comma in kohastructure.sql Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12446 - Enable an adult to have a guarantor Using index info to reconstruct a base tree... M installer/data/mysql/kohastructure.sql M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc M koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref M koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt M koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt M koha-tmpl/intranet-tmpl/prog/js/members.js M members/memberentry.pl M members/moremember.pl M svc/members/search Falling back to patching base and 3-way merge... Auto-merging svc/members/search Auto-merging members/moremember.pl Auto-merging members/memberentry.pl CONFLICT (content): Merge conflict in members/memberentry.pl Auto-merging koha-tmpl/intranet-tmpl/prog/js/members.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 12446 - Enable an adult to have a guarantor The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-12446---Enable-an-adult-to-have-a-guarantor-iB_HiD.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14919] Holds history for patron
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 --- Comment #14 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Joseph, can you sign off my follow-up and switch status to signed off if it's ok? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14919] Holds history for patron
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 67811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67811&action=ed… Bug 14919: (follow-up) Fixing some typos and adding to pref description - Adds 'holds' to pref description of intranetreadinghistory - Fixes typo in link to holds history from patron account - Changes reserve date to hold date in table heading -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14919] Holds history for patron
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 67810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67810&action=ed… Bug 14919: Add holds history for patron Test plan: 0) Have a patron with some current and old reserves 1) Go to patron circulation page 2) Notice, there is new item called "Holds history" in the left circulation menu 3) Go to this page and confirm the data on this page are OK, and that ui does behave as expected 4) Go to adminitration, columns setting, try to change the setting for holdshistory table and confirm it is taken into account on holds history page Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0