November 2017 - Koha-bugs - lists.koha-community.org

[Bug 12497] Make OPAC search history feature accessible when it should
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12497] Make OPAC search history feature accessible when it should
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #12 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Charles Farmer from comment #9) > Is this intended behavior to return a 404 whenever a systempreference blocks > a page in Koha? I feel like the template could simply state to users and > admin alike that search history is disabled, unless that's deemed too > verbose for the user's own good. > > But it works, nonetheless, so I'm signing it off. You will find more examples like: if ( ! C4::Context->preference('suggestion') ) { print $input->redirect("/cgi-bin/koha/errors/404.pl"); exit; } But you are right, nice is something else :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #59 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I know quite a few libraries of ours would be happy to see this fixed. As it is classified as a bugfix (correctly) it could still go into 17.11.x later on. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #58 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Are you fixing a missing status (Transit) from GetReserveStatus by working around it in IsAvailableForItemLevelRequest ? (See above too) What about other calls of GetReserveStatus ? - [% IF ( AllowOnShelfHolds OR ItemsIssued ) %] + [% IF ( AllowOnShelfHolds OR ItemsIssued OR ItemsWaitingOrInTransit ) %] Would it be easier to just have one template var for this? +my $itemsWaitingOrInTransit = Koha::Holds->search( + { + biblionumber => $biblionumber, + found => ['W', 'T'] + })->count(); +unless ($itemsWaitingOrInTransit) { + foreach my $item ( Koha::Items->search(biblionumber => $biblionumber) ) { + $itemsWaitingOrInTransit = 1 if $item->get_transfer; + } +} Move this code into a sub ? And test it ? I think we are too late anyway to get this into the new release. Some of the points mentioned are no blockers, but imo the code still needs some attention. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #57 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Conflicts now with just pushed 18547 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18547 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #12 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Janusz Kaczmarek from comment #10) > Hello to all. To not open a new bug I would like to submit here a patch > that should fix this painful and far-too-long-still-not-resolved issue. The > proposed approach relies on authority records (which should be > correct--that's exactly why they are called 'authority' records). > Especially MARC 21 case, as stated by Zeno, is more complex, specially for > 6XX (2nd ind., $2 subfield etc.) > > To test -- have some authority recs. with different tags (eg. 100, 130, > 150), use them in biblio, especially in 6XX, 7XX (setting 2nd ind). > Have running indexer and proper value of AuthorityMergeLimit, i.e. not 0. > Then play with indicators in authorities. For MARC 21 auth used in 6XX > play also with 008/11 and 040 $f (if 008/11 set to 'z'). Have a look > at the results in biblio (see subfield $2 in MARC 21 6XX if 008/11 = z > and 040 $f defined). Hi Janusz Thx for submitting this proposal. It really looks interesting. Will need more time to have a closer look, but I am glad that we take a next step. Quick question: The patch is MARC21 oriented; what about the UNIMARC side ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #6 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 69356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69356&action=ed… Bug 7046 - Implemented dropdown sub length element To make this work I moved the _get_sub_length function from subscription-add.pl to C4/Serials.pm so that the subscription-renew.pl script could also call it to store the sublength for the appropriate field of the subscriptions database table. Test plan: 1. Create a subscription and notice that there is a dropdown box for sub length containing the values: issues, weeks, months 2. Renew the subscription and notice that there are 3 input text boxes: 'number of num', 'number of weeks' and 'number of months' 3. Input a 'Number of weeks' value of 2 4. Query the subscription database table and notice that the value of 2 has been stored in the weeklength field for the subscription record you just renewed 5. Apply the patch 6. Renew the subscription and notice that there is now a sublength dropdown box containing issues, weeks and months 7. Set the month value to 3 8. Query the database and notice that 3 was stored in the monthlength field for the subscription record 9. Create a new subscription and select the sub length values of issues and 3 10. Query the database and notice that the numberlength field for the subscription you just created is set to 3 showing that the sublength dropbox is still working for creating a new subscription Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley(a)catalyst.net.nz Attachment #69355|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0