November 2017 - Koha-bugs - lists.koha-community.org

[Bug 19402] New: Date of birth datepicker year range depending on current value
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19402 Bug ID: 19402 Summary: Date of birth datepicker year range depending on current value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 18447 sets for date of birth a year range "c-100:c" meaning current year and 100 years earlier. This is good when imput is empty. But when input already contains a date, say "01/01/1950", years range is 1850 to 1950. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #13 from Janusz Kaczmarek <januszop(a)gmail.com> --- > Thx for submitting this proposal. It really looks interesting. Will need > more time to have a closer look, but I am glad that we take a next step. > Quick question: The patch is MARC21 oriented; what about the UNIMARC side ? Hi Marcel, Thank you for your comments. To answer your question, UNIMARC is covered here in the same way as it is covered in the enhancement introduced with Bug 5262 four years ago (see the discussion there)--at that time I worked mainly in UNIMARC environment, so I hope it shouldn't be very wrong also now. (BTW, see the initial message of Julian.) UNIMARC is rather straightforward here. It is MARC 21 that makes things more complicated. But really, I should probably reconsider operations on $2 for UNIMARC subject headings fields in respect to 152 $b in UNIMARC authority record. In 2013, also, Magnus reported: "NORMARC does not support authorities at all at the moment" (still from Bug 5262 discussion). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12497] Make OPAC search history feature accessible when it should
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12497] Make OPAC search history feature accessible when it should
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12497] Make OPAC search history feature accessible when it should
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69342|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 69381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69381&action=ed… Bug 12497: Fix OPAC search history reachable by URL even when disabled Test plan: 1. Set EnableOpacSearchHistory syspref to "Keep" 2. Make a search in the OPAC 3. Go to /cgi-bin/koha/opac-search-history.pl 4. Set the EnableOpacSearchHistory syspref to "Don't keep" 5. Refresh the OPAC page to show that history is still accessible 6. Apply the patch 7. Refresh the OPAC page, you should end on the 404 page 8. Set EnableOpacSearchHistory syspref to "Keep" 9. Go to /cgi-bin/koha/opac-search-history.pl which should be reachable Signed-off-by: David Bourgault <david.bourgault(a)inlibro.com> Signed-off-by: Charles Farmer <charles.farmer(a)inLibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12497] Make OPAC search history feature accessible when it should
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69341|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 69380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69380&action=ed… Bug 12497: Fix search history non-accessible when OPAC was private (when the user didn't have the "borrowers" permission) Test plan: 1. Set syspref "OpacPublic" to false (Disable) 2. Log in as a user without any permission 3. Try to access the search history. The link is next to "Log out" 4. Then you should see "Access denied" 5. Apply this patch 6. Refresh the page 7. Then you should see the search history Signed-off-by: David Bourgault <david.bourgault(a)inlibro.com> Signed-off-by: Charles Farmer <charles.farmer(a)inLibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12497] Make OPAC search history feature accessible when it should
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12497] Make OPAC search history feature accessible when it should
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #12 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Charles Farmer from comment #9) > Is this intended behavior to return a 404 whenever a systempreference blocks > a page in Koha? I feel like the template could simply state to users and > admin alike that search history is disabled, unless that's deemed too > verbose for the user's own good. > > But it works, nonetheless, so I'm signing it off. You will find more examples like: if ( ! C4::Context->preference('suggestion') ) { print $input->redirect("/cgi-bin/koha/errors/404.pl"); exit; } But you are right, nice is something else :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #59 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I know quite a few libraries of ours would be happy to see this fixed. As it is classified as a bugfix (correctly) it could still go into 17.11.x later on. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '17

27 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #58 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Are you fixing a missing status (Transit) from GetReserveStatus by working around it in IsAvailableForItemLevelRequest ? (See above too) What about other calls of GetReserveStatus ? - [% IF ( AllowOnShelfHolds OR ItemsIssued ) %] + [% IF ( AllowOnShelfHolds OR ItemsIssued OR ItemsWaitingOrInTransit ) %] Would it be easier to just have one template var for this? +my $itemsWaitingOrInTransit = Koha::Holds->search( + { + biblionumber => $biblionumber, + found => ['W', 'T'] + })->count(); +unless ($itemsWaitingOrInTransit) { + foreach my $item ( Koha::Items->search(biblionumber => $biblionumber) ) { + $itemsWaitingOrInTransit = 1 if $item->get_transfer; + } +} Move this code into a sub ? And test it ? I think we are too late anyway to get this into the new release. Some of the points mentioned are no blockers, but imo the code still needs some attention. -- You are receiving this mail because: You are watching all bug changes.

1 0