November 2017 - Koha-bugs - lists.koha-community.org

[Bug 2454] Improve display of credits on pay fines tab
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '17

17 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Dominic Pichette <dominic.pichette(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69098|0 |1 is obsolete| | --- Comment #20 from Dominic Pichette <dominic.pichette(a)inlibro.com> --- Created attachment 69210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69210&action=ed… Bug 2454 - Removed the display of NotifyID and Level values on Pay fines page Based on tester feedback this patch has been redone so as to remove changes of indentation to lines not added or modified by this patch. Test plan: 1. From the Koha staff interface go the Patron area and select a patron page 2. Create a fine of $10 for the patron by clicking on the 'Fines' tab and creating a fine in the 'Create manual invoice' tab 3. Create a credit of $5 for the patron in the 'Create manual credit' page 4. Then go to the 'Pay fines' tab and notice there is a row for both the fine and credit both with values in the account type, Notify ID, and level boxes of the table 5. Select "write off all" and 'OK' in the confirmation box 6. Youre redirected to Account tab, return to 'pay fines' tab and notice no fines or credits are displayed 7. Repeat steps 2, 3, 4 and then click "Pay amount", confirm it, then navigate back to the 'Pay fines' tab and notice although the fine and credit are displayed the 'total due' value is 0.00 8. Apply the patch attached to this bug report 9. Repeat steps 2, and 3. 10. Navigate to 'Pay fines' tab and notice the fine has values in account type, Notify ID, and level and the credit does not. Additionally credit has the description value of 'Credit' 11. Repeat steps 5 and 6 and as with before this patch was applied notice the 'Pay fines' tab does not show any fines or credits 12. Repeat step 7 and again notice the 'Total due' value is 0.00 Sponsored-By: Catalyst IT Signed-off-by: Dominic Pichette <dominic(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 2454] Improve display of credits on pay fines tab
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '17

17 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Dominic Pichette <dominic.pichette(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominic.pichette(a)inlibro.co | |m Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '17

17 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Bouzid <bouzid.fergani(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #23 from Bouzid <bouzid.fergani(a)inlibro.com> --- Hi Katrin, I fixed : - adding atomicupdate - cleaninig sysprefs.sql - Some problem of QA tools - Use Modern::Perl - internal error server But, I do not know how to add tests for new linker, because it uses z3950 server?, any idea. Thanks -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '17

17 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Bouzid <bouzid.fergani(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69096|0 |1 is obsolete| | --- Comment #22 from Bouzid <bouzid.fergani(a)inlibro.com> --- Created attachment 69204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69204&action=ed… Bug 11300 - Add a new authority linker which searches for authority links on a Z39.50 server. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19485] New: Limiting by title-series (se) broken on ES
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '17

17 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19485 Bug ID: 19485 Summary: Limiting by title-series (se) broken on ES Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching - Elasticsearch Assignee: david.bourgault(a)inlibro.com Reporter: david.bourgault(a)inlibro.com When filtering/limiting search results by Series title, the limit field name passed to ES is 'title-series' but it expects 'se', causing no results to be found. This is particularly confusing as the page URL clearly says limit=se:XYZ. -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 9081] Opac news not output on check in and check out notices
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '17

17 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9081 Lisette <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '17

17 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #26 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Thx David for your brave changes. Looks good, still asking some attention. - } elsif ( $issue->date_due and $patron->debarred ) { + if ( $new_debar == 0 and $patron->debarred ) { Why do you remove the test on date_due (might be just theoretical)? Since you change the program flow by changing an elsif into an if, the game may change here. The comment on top is no longer valid at least ("There is no overdue..."); seems ok for the rest. Variable $is_a_reminder is no longer used. # if borrower was already debarred but does not get an extra debarment Your changes make this comment look bad. Since _debar_user_on_return now seems to return new or extended debarment dates only, please adjust POD. In AddReturn adjust varname accordingly (like newdebardate or so )? You do not need $debardate and $new_debar now; $newdebardate would be enough to test. See Comment11 too. We still need additional unit testing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '17

17 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #25 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Changing status. Comment follows. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13867] change input in 245$a and 245$c for textarea
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '17

17 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13867 Patrick Robitaille <patrick.robitaille(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '17

17 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #24 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.

1 0