November 2017 - Koha-bugs - lists.koha-community.org

[Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '17

17 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #26 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Thx David for your brave changes. Looks good, still asking some attention. - } elsif ( $issue->date_due and $patron->debarred ) { + if ( $new_debar == 0 and $patron->debarred ) { Why do you remove the test on date_due (might be just theoretical)? Since you change the program flow by changing an elsif into an if, the game may change here. The comment on top is no longer valid at least ("There is no overdue..."); seems ok for the rest. Variable $is_a_reminder is no longer used. # if borrower was already debarred but does not get an extra debarment Your changes make this comment look bad. Since _debar_user_on_return now seems to return new or extended debarment dates only, please adjust POD. In AddReturn adjust varname accordingly (like newdebardate or so )? You do not need $debardate and $new_debar now; $newdebardate would be enough to test. See Comment11 too. We still need additional unit testing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '17

17 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #25 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Changing status. Comment follows. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13867] change input in 245$a and 245$c for textarea
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '17

17 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13867 Patrick Robitaille <patrick.robitaille(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '17

17 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #24 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14759] Replacement for Text::Unaccent
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '17

17 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #26 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Colin Campbell from comment #25) > Text::Unaccent does not build on 64bit systems, the tests fail because of > errors in the ccode. There has been a patch for that for four years but it > looks like the upstream code is moribund. If you look at the test results it > now fails on all linux test builds. The module has not been kept up to date > to handle modern perl strings. I think the debian version may be patched to > fix the bug in 64bit tests but it is buggy and should not be relied on. > Suggest moving to Text::Unaccent::PurPerl be prioritized Where are we using Text::Unaccent? Is it still just in userid strings? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8992] Add an interfacing with the idref webservice
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '17

16 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640 [Bug 19640] IdRef webservice display is broken -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19639] New: Are temporary CGI uploads removed too late under Plack?
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '17

16 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19639 Bug ID: 19639 Summary: Are temporary CGI uploads removed too late under Plack? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Scripts that run under Plack like tools/inventory that use larger file uploads, create temporary files that are removed when CGI closes. This may take longer when we run this under Plack. Is it too long? Could they fill up your tmp partition? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '17

16 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Self-Check module stand |Stand alone self check-in |alone check-in |tool -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Self-Check module stand alone check-in
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '17

16 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #8 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Owen Leonard from comment #4) > This is missing from sci-main.tt: > > <script type="text/javascript"> > function _(s) { return s } // dummy function for gettext > </script> > > (see sco-main.tt for comparison) I've re-introduced it, along with several other tiny fixes/changes, including the help modal. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Self-Check module stand alone check-in
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '17

16 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69168|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 69179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69179&action=ed… Bug 15492: Add SCI module This patch adds the SCI module, and adapts C4::Auth to know about it. The current behaviour is: - Requires admin user initialization/login - Uses the logged users' library - A form allows to scan multiple barcodes - A button sends the barcode list to the controller to batch perform the checkins - Successful and failed checkins are sent to the template - Results are displayed - Logout link To test: - Apply this patches - Make sure you upgrade: $ kshell k$ perl installer/data/mysql/updatedatabase.pl - Have 'SelfCheckInModule' disabled - Go to http://kohadev.myDNSname.org:8080/cgi-bin/koha/sci/sci-main.pl [1] => SUCCESS: You are rejected because the feature is disabled - Enable 'SelfCheckInModule' - Go to the previous URL => SUCCESS: You are required to login - Login with a user WITHOUT self_checkout permissions => SUCCESS: You are not allowed to log into the Self check-in module. - Login with a user WITH self_checkour permissions => SUCCESS: You gain access, and are presented the UI - Go through the several options => SUCCESS: All works as it should - Click the 'Help' link => SUCCESS: A help text is displayed on a modal - Sign off :-D - Bonus points: $ kshell k$ qa -c 2 -v 2 => SUCCESS: All tests green [1] Adjust to your dev's OPAC setup -- You are receiving this mail because: You are watching all bug changes.

1 0