November 2017 - Koha-bugs - lists.koha-community.org

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '17

08 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle(a)bywatersolutions.com |tomascohen(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '17

08 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #198 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 69046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69046&action=ed… Bug 7317: Remove traces of UnmediatedILL This patch removes references to UnmediatedILL. This feature is introduced on a separate bug. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '17

08 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #197 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 69045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69045&action=ed… Bug 7317: (followup) Remove extra columns from backends on the main list This patch removes the extra columns functionality, simplifying the code. It removes redundant code (in both Perl and JS), unused vars. It removes the use of here_link and hardcodes the script path on the template. It also adjusts the AJAX call so it uses the 'library' param instead of 'branch'. The library column now displays the library name instead of the ID. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '17

08 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #196 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 69044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69044&action=ed… Bug 7317: (QA followup) Rename 'branch' for 'library' Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '17

08 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #195 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Jonathan Druart from comment #193) > Some more: > > 1. This looks wrong > 260 here_link => "/cgi-bin/koha/ill/ill-requests.pl" > > url should be in template I'd say The path shouldn't need to be added manually, I'd say any option is wrong, fixed anyway in an upcoming patch. > 2. This is not used, you are using an ajax call > 219 } elsif ( $op eq 'illlist') { > 220 # Display all current ILLs > > 221 my $requests = $illRequests->search(); > 222 > 223 $template->param( > > 224 requests => $requests > > 225 ); This is not used and is removed on an upcoming patch. > 3. 257 media => [ "Book", "Article", "Journal" ], > Is this used? This is used as a fallback in case the backends don't implement their own list. Needs to be kept (e.g. for the Dummy backend to work). > 4. > Config.pm > 312 die "No DEFAULT_FORMATS has been defined in koha-conf.xml, but > UNMEDIATEDILL is active." > 313 if ( $unmediated && > !$configuration->{default_formats}->{default} ); > > Not used yet, please remove Yup, removed in an upcoming patch. > 5. 794 \"YEAR(placed) = YEAR(NOW())" > This looks like a mysqlism True. But I cannot find any option to specify the same behaviour in SQL::Abstract or the DBIC docs. The very same line of code can be found on the DBIC docs as an example. > 6. The branchcode is displayed instead of the branchname in the list of ILL > requests. Sounds easy to fix as we embed "branch" (must be library?) Fixed in an upcoming patch. > 7. api/v1/swagger/paths/*.json > "name": "branchcode" > vs > "name": "branch_id" > same with > borrowernumber vs borrower_id > and > biblionumber vs biblio_id I can work on this tomorrow. Today's been enough! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18256] New: Koha::Biblio - Remove GetItemsCount
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '17

08 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 Bug ID: 18256 Summary: Koha::Biblio - Remove GetItemsCount Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 17631] New: Koha::Biblio - Remove GetHolds
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '17

08 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17631 Bug ID: 17631 Summary: Koha::Biblio - Remove GetHolds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 17630 Blocks: 17628 C4::Biblio::GetHolds can be replaced with Koha::Biblio->holds->count Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 [Bug 17628] Move bibliographic related code to Koha::Biblio https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17630 [Bug 17630] Add the Koha::Biblio->holds method -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 16203] New: item plugins
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '17

08 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Bug ID: 16203 Summary: item plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '17

08 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69009|0 |1 is obsolete| | --- Comment #194 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Comment on attachment 69009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69009 Bug 7317: (QA followup 2) Fix capitalization and terminology issues This patch doesn't apply because the attached patches already fix this. Not sure how it happened. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to reserve first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 08 Nov '17

08 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Lisette <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0