December 2017 - Koha-bugs - lists.koha-community.org

[Bug 17941] New: CanBookBeRenewed is very inefficient/slow
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '18

28 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Bug ID: 17941 Summary: CanBookBeRenewed is very inefficient/slow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: boutrosboutrosboutros(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com I started investigating why populating the checkout list in the patron view sometimes took ages (minutes), and on occations even causing the system to almost halt because of DB overload. It turned out that reason is calls to C4::Circulation::CanBookBeRenewed. The critical factor is whether an item has many holds on it, and if there are many items that can fill the hold. Briefly looking at the code it seems obvious that the time spent grows exponentially with the number of holds and items. As one example, checking if an item with 111 holds (and 12 items on the biblio) can be renewed takes around 25 sec and generates over 18,000 SQL queries. I can't help to think there must be some missed "early returns" opportunities in the loops somewhere. For example, if there are more unfulfilled holds than available items, can the item ever be renewed? If no, return before even begin to calculate.. However, I know holds are full of complexities and things I probably haven't thought about so I need to dig into the code more. I would be very gratefull if anyone knowledgeable about this part of the code could help me find some ways to optimize this! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 54

[Bug 19468] New: Can't create basket in acquisitions
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19468 Bug ID: 19468 Summary: Can't create basket in acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Depends on: 15685 When trying to create a new basket in acq, I get an internal server error: Can't call method "unblessed" on an undefined value at /home/vagrant/kohaclone/C4/Acquisition.pm line 829. I think this might be a side effect of the recently pushed bug 15685. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5

[Bug 19695] New: Uncertain prices should not use find in list context
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19695 Bug ID: 19695 Summary: Uncertain prices should not use find in list context Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: stefan.berndtsson(a)ub.gu.se QA Contact: testopia(a)bugs.koha-community.org When clicking on Uncertain prices button from a basket, the log fails with the following message: Cannot use "->find" in list context at <path>/acqui/uncertainprice.pl line 76. Similar to Bug 18179. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 19452] New: working title
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452 Bug ID: 19452 Summary: working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 38

[Bug 19584] New: Inventory: working title
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '18

26 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19584 Bug ID: 19584 Summary: Inventory: working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19

[Bug 19522] New: Label creator - some strings are not translatable
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '18

26 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Bug ID: 19522 Summary: Label creator - some strings are not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: victor.grousset(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr This bug will group several patches to make all strings translatable in the Label creator tool (those that I've found at least) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 92

[Bug 19467] New: Display location and itemtype description on lost items report
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '18

26 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19467 Bug ID: 19467 Summary: Display location and itemtype description on lost items report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org The lost items report displays the location and itemtype codes instead of the descriptions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 22

[Bug 18797] New: t/db_dependent/rollingloans.t is skipping
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '18

26 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18797 Bug ID: 18797 Summary: t/db_dependent/rollingloans.t is skipping Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org t/db_dependent/rollingloans.t is need of a refactor using TestBuilder to correct its current lack of usefulness. -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 19785] New: Move template JavaScript to the footer: Authorities, part 1
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '18

26 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Bug ID: 19785 Summary: Move template JavaScript to the footer: Authorities, part 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for some of the authorities templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.

1 29

[Bug 19730] New: misc/ export_records.pl should use biblio_metadata.timestamp
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '18

26 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19730 Bug ID: 19730 Summary: misc/export_records.pl should use biblio_metadata.timestamp Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Depends on: 19724 Since bug 17196, biblioitems.timestamp is not always updated after a change in the MARC record. Filtering should be based on biblio_metadata.timestamp instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724 [Bug 19724] Add timestamp to biblio_metadata and deletedbiblio_metadata -- You are receiving this mail because: You are watching all bug changes.

1 15