December 2017 - Koha-bugs - lists.koha-community.org

[Bug 10032] Uncertain prices hide 'close basket' without explanation
by bugzilla-daemon＠bugs.koha-community.org 27 Dec '17

27 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032 --- Comment #4 from Jon Knight <J.P.Knight(a)lboro.ac.uk> --- OK, how about this for a test plan: 1) Before applying the patch, go to staff UI, and select Acquisitions, pick one of your existing vendors (or create a new one) and then open a new basket (call it anything you want). 2) Add a new (empty) record order to the basket. 3) Give the new record a made up title, add a single item (no need to fill in any details), set a price of 10.00 and check the "Uncertain price" checkbox before saving the record. 4) Confirm that the resulting summary page has a button bar that does NOT include any button for closing the basket. 5) Modify the record and remove the check mark from the "Uncertain price" checkbox before saving. 6) Confirm that the resulting basket summary page button bar now does have a "Close this basket" button (as the basket no longer has uncertain prices). 7) Apply the patch. 8) Modify the record again to check the "Uncertain price" checkbox again, then save it. 9) Confirm that the resulting summary page has a button bar that does include a "Close this basket" button but that this button is greyed out and inoperative. 10) Modify the record again to remove the check mark in the "Uncertain price" checkbox, then save the record. 11) Confirm that the resulting summary page has a button bar that does include a "Close this basket" button which is now active (as the order no longer has an uncertain price). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 27 Dec '17

27 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #23 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Jonathan Druart from comment #14) > All works great, few concerns: > 2. Only the AutoSelfCheckID should be able to connect to sci-main.pl, we > should apply the same behaviour as self-checkout (no?) FTR, self check users should be 'marked' by a flag somewhere (hardcoded category types, a flag in the patron category, on the borrowers table, etc) instead of doing complex tricks. This way we would just do if ( $patron->is_self_check_user ) { # handle it } instead. Just my 2 cents. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 27 Dec '17

27 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #22 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Jonathan Druart from comment #14) > All works great, few concerns: > 1. Code in C4::Auth must be simplify and merged with existing one (you c/p > 25 lines) Done. > 2. Only the AutoSelfCheckID should be able to connect to sci-main.pl, we > should apply the same behaviour as self-checkout (no?) The behaviour for SCI is different. Users with SCI permission can only access SCI in the OPAC. This should be carefully documented in the manual (it is explicitly mentioned in the permissions page). > 3. Description (and name) of the permission self_checkout must be adapted Done. I've moved self check-related sysprefs like this: - selc_check * self_checkin_module * self_checkout_module Existing code has been adjusted. This needs to be tested just in case, that's why I moved it back to NSO (it is a trivial change, though). > 4. I do not know how SCOMainUserBlock is used, but it may be wrong to > display it for SCI (?) I did what I planned for a followup bug: making SCI have its own set of sysprefs. I was going to do it anyway, but cleaner on the same patchset. Good catch. > 5. "Data corruption detected" => Are we sure we want to display that at the > OPAC? > 6. If error code is not known, we should display it instead of ignore it > (BLOCK error_message) Both addessed with Nick's idiomatic aid. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11606] Novelist Select in Staff Client
by bugzilla-daemon＠bugs.koha-community.org 27 Dec '17

27 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606 George Williams (NEKLS) <george(a)nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams(a)nekls.org |george(a)nekls.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 27 Dec '17

27 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 27 Dec '17

27 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #21 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 70179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70179&action=ed… Bug 15492: Display nicer message on data corruption This patch hides scary messages and changes the wording for a more idiomatic approach. Thanks to Nick :-D Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 27 Dec '17

27 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #20 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 70178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70178&action=ed… Bug 15492: Make SCI use its own sysprefs and CSS file Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 27 Dec '17

27 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #19 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 70177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70177&action=ed… Bug 15492: Make existing code aware of new self_check* permissions This patch makes the existing code for SCO use the new permissions schema for self check modules. Specifically addresses this change: circulate => self_checkout becomes slef_check => self_checkout_module about.pl checks are dejusted too. get_template_and_user gets refactored to avoid code duplication and the conditions are adjusted for the new permissions. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 27 Dec '17

27 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #18 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 70176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70176&action=ed… Bug 15492: New sysprefs and permissions In order to make this module unrelated to the SCO module, this patch introduces the following sysprefs: - SelfCheckInMainUserBlock - SelfCheckInModuleUserID - SelfCheckInTimeout - SelfCheckInUserCSS - SelfCheckInUserJS It also adds a new user flag and sub-permission: - self_check => self_checkin_module and moves the circulate => self_checkout permission into - self_check => self_checkout_module Descriptions are adjusted accordingly. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 27 Dec '17

27 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #17 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 70175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70175&action=ed… Bug 15492: (QA follow-up) Reset SCI if idle for 30 seconds Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0