December 2017 - Koha-bugs - lists.koha-community.org

[Bug 9834] Should reverting a waiting hold keep the item number?
by bugzilla-daemon＠bugs.koha-community.org 29 Dec '17

29 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Hugh Rundle <hughr(a)brimbank.vic.gov.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hughr(a)brimbank.vic.gov.au --- Comment #5 from Hugh Rundle <hughr(a)brimbank.vic.gov.au> --- Definitely needed for all the reasons mentioned: if holds are 'next available' (which is nearly always the case for us) then turning it into an item-level hold on allocation isn't ideal. Also, usually if you're reverting the waiting status it's because the item has gone missing, so the only way to fix this is actually to cancel the hold and then place a new hold and push the borrower to the top of the list again, which is ...suboptimal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 8962] Restore Any index behavior and add Anywhere index
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 --- Comment #56 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- As this would be a change of behavior now after a long time of dom indexing... should we make it possible to switch the one that is used in the GUI when selecting 'keyword'? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8962] Restore Any index behavior and add Anywhere index
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #55 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Magnus, I think this is out of scope if this aims to restore the former behaviour - you'd have to remove the place of publication from indexes. Maybe a next step could be a configurable Any index? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer(a)inlibro.com --- Comment #55 from Charles Farmer <charles.farmer(a)inlibro.com> --- Some rebasing on the new master was necessary. Submitted a third patch to follow-up on Marcel's observation. Had to obsolete the [SIGNED-OFF] patches, but didn't have the stomach to remove the sign off from the commit messages themselves. Patch back at needs sign off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70193|0 |1 is obsolete| | --- Comment #54 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 70196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70196&action=ed… Bug 11297: QA follow-up - Avoid carrying server attributes As it was pointed out, concatenating server attributes on a variable above the foreach loop meant carrying those attributes through every other queries. With a variable local to the loop, we can now send each server its specific zquery. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70192|0 |1 is obsolete| | --- Comment #53 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 70195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70195&action=ed… Bug 11297: QA follow-up - Some fixes - Makes Attributes only show up when adding a new Z39.50 server, not for SRU - Fixes typo in db documentation - Fixes sorting of table columns Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62938|0 |1 is obsolete| | Attachment #62939|0 |1 is obsolete| | Attachment #70191|0 |1 is obsolete| | --- Comment #52 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 70194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70194&action=ed… Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results modified: C4/Breeding.pm modified: Koha/Schema/Result/Z3950server.pm modified: admin/z3950servers.pl new file: installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql modified: installer/data/mysql/kohastructure.sql modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> New sign-off, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70190|0 |1 is obsolete| | --- Comment #51 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 70193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70193&action=ed… Bug 11297: QA follow-up - Avoid carrying server attributes As it was pointed out, concatenating server attributes on a variable above the foreach loop meant carrying those attributes through every other queries. With a variable local to the loop, we can now send each server its specific zquery. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #50 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 70192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70192&action=ed… Bug 11297: QA follow-up - Some fixes - Makes Attributes only show up when adding a new Z39.50 server, not for SRU - Fixes typo in db documentation - Fixes sorting of table columns Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #49 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 70191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70191&action=ed… Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results modified: C4/Breeding.pm modified: Koha/Schema/Result/Z3950server.pm modified: admin/z3950servers.pl new file: installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql modified: installer/data/mysql/kohastructure.sql modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> New sign-off, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0