December 2017 - Koha-bugs - lists.koha-community.org

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer(a)inlibro.com --- Comment #55 from Charles Farmer <charles.farmer(a)inlibro.com> --- Some rebasing on the new master was necessary. Submitted a third patch to follow-up on Marcel's observation. Had to obsolete the [SIGNED-OFF] patches, but didn't have the stomach to remove the sign off from the commit messages themselves. Patch back at needs sign off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70193|0 |1 is obsolete| | --- Comment #54 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 70196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70196&action=ed… Bug 11297: QA follow-up - Avoid carrying server attributes As it was pointed out, concatenating server attributes on a variable above the foreach loop meant carrying those attributes through every other queries. With a variable local to the loop, we can now send each server its specific zquery. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70192|0 |1 is obsolete| | --- Comment #53 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 70195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70195&action=ed… Bug 11297: QA follow-up - Some fixes - Makes Attributes only show up when adding a new Z39.50 server, not for SRU - Fixes typo in db documentation - Fixes sorting of table columns Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62938|0 |1 is obsolete| | Attachment #62939|0 |1 is obsolete| | Attachment #70191|0 |1 is obsolete| | --- Comment #52 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 70194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70194&action=ed… Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results modified: C4/Breeding.pm modified: Koha/Schema/Result/Z3950server.pm modified: admin/z3950servers.pl new file: installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql modified: installer/data/mysql/kohastructure.sql modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> New sign-off, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70190|0 |1 is obsolete| | --- Comment #51 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 70193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70193&action=ed… Bug 11297: QA follow-up - Avoid carrying server attributes As it was pointed out, concatenating server attributes on a variable above the foreach loop meant carrying those attributes through every other queries. With a variable local to the loop, we can now send each server its specific zquery. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #50 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 70192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70192&action=ed… Bug 11297: QA follow-up - Some fixes - Makes Attributes only show up when adding a new Z39.50 server, not for SRU - Fixes typo in db documentation - Fixes sorting of table columns Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #49 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 70191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70191&action=ed… Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results modified: C4/Breeding.pm modified: Koha/Schema/Result/Z3950server.pm modified: admin/z3950servers.pl new file: installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql modified: installer/data/mysql/kohastructure.sql modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> New sign-off, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #48 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 70190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70190&action=ed… Bug 11297: QA follow-up - Avoid carrying server attributes As it was pointed out, concatenating server attributes on a variable above the foreach loop meant carrying those attributes through every other queries. With a variable local to the loop, we can now send each server its specific zquery. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5620] Capture Mode of payment
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '17

28 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer(a)inlibro.com --- Comment #38 from Charles Farmer <charles.farmer(a)inlibro.com> --- Is there any consensus on how to move this bug forward? One of the implementation touches on SIP, the other does not. Are we sure they're really duplicates? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0