December 2017 - Koha-bugs - lists.koha-community.org

[Bug 19843] New: reviews.datereviewed is not set
by bugzilla-daemon＠bugs.koha-community.org 22 Dec '17

22 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843 Bug ID: 19843 Summary: reviews.datereviewed is not set Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 15839 Caused by commit 092ae340cef375cc66c8511fd34c1a4eec9c7ba6 Bug 15839: Koha::Reviews - Remove savereview the datereviewed=now() part of the query has not been translated. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 [Bug 15839] Move the reviews related code to Koha::Reviews -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 19315] New: Routing preview may use wrong biblionumber
by bugzilla-daemon＠bugs.koha-community.org 22 Dec '17

22 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19315 Bug ID: 19315 Summary: Routing preview may use wrong biblionumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com When generating the routing preview from the serials collection screen: /cgi-bin/koha/serials/serials-collection.pl?subscriptionid=## the subscription information is obtained via a mysql call in C4::Serials::GetSubscription, however, the statement pulls subscription.* and subscriptionhistory.* Both of these have a biblionumber field, so when routing-preview.pl pulls the biblionumber it may get bad information -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25

[Bug 17556] New: Move GetHideLostItemsPreference to Koha::Patron
by bugzilla-daemon＠bugs.koha-community.org 22 Dec '17

22 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556 Bug ID: 17556 Summary: Move GetHideLostItemsPreference to Koha::Patron Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 17555 Blocks: 16846 The subroutine C4::Members::GetHideLostItemsPreference can easily be replaced with Koha::Patron->find(42)->category->hidelostitems Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17555 [Bug 17555] Add Koha::Patron->category -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 22 Dec '17

22 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs(a)lists.koha-commun |david.bourgault(a)inlibro.com |ity.org | Summary|Add a column for note, |Add columns for note, order |order number ans ISBN in |number and ISBN to late |late order page |orders page --- Comment #7 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- David, don't forget to add you as Assignee when you plan to provide patches for a bug! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 9495] split NotesBlacklist in to two prefs for staff and OPAC
by bugzilla-daemon＠bugs.koha-community.org 22 Dec '17

22 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I am in doubt about adding a new routine to C4::GetOPACMarcNotes - We are missing tests, but tests are required for any new routine or a change to an existing one. - I think it might make more sense to use improve GetMarcNotes to take an interface parameter, like we do in other cases. Duplicating the code will create problems, such as with bug 18198. -- Some other small things: - Database update should be in an atomicupdate file (see database update instructions on the wiki) - Please use INSERT IGNORE - It might be a bit more consistent with other prefs to have OPACNotesBlackList. Examples: (OPAC)ISBD,(OPAC)AmazonCoverImages, (OPAC)LocalCoverImages, ...) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '17

21 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70086|0 |1 is obsolete| | --- Comment #128 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 70087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70087&action=ed… Bug 8000 - Redirect all emails to SendAllEmailsTo Koha/Email.pm Test plan: 1) Apply path 2) Run updatedatabase.pl 3) Clear all SendAllEmailsTo system preference 4) Send mail to a patron of your choosing, email will go to patron's email address as usual. 5) Set SendAllEmailsTo to a test email address 6) Send mail to the patron, email will be redirected to the email set in the systempreference. 7) Run prove -v t/db_dependent/Letters.t It does not affect messages in the message_queue. This patch obsoletes previous patches, because it achieves the same functionality in a much more centralized way. (4 lines of code!) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '17

21 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #127 from Charles Farmer <charles.farmer(a)inlibro.com> --- With the latest patch reworked by David, I feel like this bug can be placed once again in "Needs Signoff". Rebased on the current master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '17

21 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67155|0 |1 is obsolete| | --- Comment #126 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 70086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70086&action=ed… Bug 8000 - Redirect all emails to SendAllEmailsTo Koha/Email.pm Test plan: 1) Apply path 2) Clear all SendAllEmailsTo system preference 3) Send mail to a patron of your choosing, email will go to patron's email address as usual. 4) Set SendAllEmailsTo to a test email address 5) Send mail to the patron, email will be redirected to the email set in the systempreference. It does not affect messages in the message_queue. This patch obsoletes previous patches, because it achieves the same functionality in a much more centralized way. (4 lines of code!) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '17

21 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #13 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 70075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70075&action=ed… Bug 15492 [QA Followup] - Reset SCI if idle for 30 seconds Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '17

21 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #12 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 70074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70074&action=ed… Bug 15492: Add SCI module This patch adds the SCI module, and adapts C4::Auth to know about it. The current behaviour is: - Requires admin user initialization/login - Uses the logged users' library - A form allows to scan multiple barcodes - A button sends the barcode list to the controller to batch perform the checkins - Successful and failed checkins are sent to the template - Results are displayed - Logout link To test: - Apply this patches - Make sure you upgrade: $ kshell k$ perl installer/data/mysql/updatedatabase.pl - Have 'SelfCheckInModule' disabled - Go to http://kohadev.myDNSname.org:8080/cgi-bin/koha/sci/sci-main.pl [1] => SUCCESS: You are rejected because the feature is disabled - Enable 'SelfCheckInModule' - Go to the previous URL => SUCCESS: You are required to login - Login with a user WITHOUT self_checkout permissions => SUCCESS: You are not allowed to log into the Self check-in module. - Login with a user WITH self_checkour permissions => SUCCESS: You gain access, and are presented the UI - Go through the several options => SUCCESS: All works as it should - Click the 'Help' link => SUCCESS: A help text is displayed on a modal - Sign off :-D - Bonus points: $ kshell k$ qa -c 2 -v 2 => SUCCESS: All tests green [1] Adjust to your dev's OPAC setup Signed-off-by: David Bourgault <david.bourgault(a)inlibro.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0