December 2017 - Koha-bugs - lists.koha-community.org

[Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '17

05 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 --- Comment #8 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Ola, thx for explaining the use case! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19675] New: Cannot save notices when setting the TranslateNotices preference
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '17

05 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19675 Bug ID: 19675 Summary: Cannot save notices when setting the TranslateNotices preference Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: andreas.jonsson(a)kreablo.se QA Contact: testopia(a)bugs.koha-community.org The lang parameter is missing in the where clause of the update statement. The below patch fixes the problem. diff --git a/tools/letter.pl b/tools/letter.pl index 5920a8437f..f89930472c 100755 --- a/tools/letter.pl +++ b/tools/letter.pl @@ -303,11 +303,11 @@ sub add_validate { q{ UPDATE letter SET branchcode = ?, module = ?, name = ?, is_html = ?, title = ?, content = ?, lang = ? - WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? + WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? AND lang = ? }, undef, $branchcode || '', $module, $name, $is_html || 0, $title, $content, $lang, - $branchcode, $oldmodule, $code, $mtt + $branchcode, $oldmodule, $code, $mtt, $lang ); } else { $dbh->do( To reproduce: 1. Enable TranslateNotices global preference. 2. Edit any notice message and save a translation. 3. Try updating any translation. The save will fail and the log-file will contain errors such as this: DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /usr/share/koha/lib/Koha/Objects.pm line 92 DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /usr/share/koha/lib/Koha/Objects.pm line 92 DBD::mysql::db do failed: Duplicate entry 'circulation-ODUE--email-sv-SE' for key 'PRIMARY' [for Statement " UPDATE letter SET branchcode = ?, module = ?, name = ?, is_html = ?, title = ?, content = ?, lang = ? WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? "] at /usr/share/koha/intranet/cgi-bin/tools/letter.pl line 302. DBD::mysql::db do failed: Duplicate entry 'circulation-ODUE--email-en' for key 'PRIMARY' [for Statement " UPDATE letter SET branchcode = ?, module = ?, name = ?, is_html = ?, title = ?, content = ?, lang = ? WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? "] at /usr/share/koha/intranet/cgi-bin/tools/letter.pl line 302. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 19516] New: can' t save changes on notices if letter is already created
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '17

05 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19516 Bug ID: 19516 Summary: can't save changes on notices if letter is already created Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: hagud(a)orex.es QA Contact: testopia(a)bugs.koha-community.org we have seen a problem modifying notices in koha 17.05.04, the issue is that you can not modify notices if they're already created, when you try to modify you get an error in plack as these one. DBD::mysql::db do failed: Duplicate entry 'circulation-PREDUE--email-ca-ES' for key 'PRIMARY' [for Statement " UPDATE letter SET branchcode = ?, module = ?, name = ?, is_html = ?, title = ?, content = ?, lang = ? WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? "] at /usr/share/koha/intranet/cgi-bin/tools/letter.pl line 302. DBD::mysql::db do failed: Duplicate entry 'circulation-PREDUE--sms-ca-ES' for key 'PRIMARY' [for Statement " UPDATE letter SET branchcode = ?, module = ?, name = ?, is_html = ?, title = ?, content = ?, lang = ? WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? "] at /usr/share/koha/intranet/cgi-bin/tools/letter.pl line 302. DBD::mysql::db do failed: Duplicate entry 'circulation-PREDUE--email-es-ES' for key 'PRIMARY' [for Statement " UPDATE letter SET branchcode = ?, module = ?, name = ?, is_html = ?, title = ?, content = ?, lang = ? WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? "] at /usr/share/koha/intranet/cgi-bin/tools/letter.pl line 302. DBD::mysql::db do failed: Duplicate entry 'circulation-PREDUE--sms-es-ES' for key 'PRIMARY' [for Statement " UPDATE letter SET branchcode = ?, module = ?, name = ?, is_html = ?, title = ?, content = ?, lang = ? WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? "] at /usr/share/koha/intranet/cgi-bin/tools/letter.pl line 302. DBD::mysql::db do failed: Duplicate entry 'circulation-PREDUE--email-default' for key 'PRIMARY' [for Statement " UPDATE letter SET branchcode = ?, module = ?, name = ?, is_html = ?, title = ?, content = ?, lang = ? WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? "] at /usr/share/koha/intranet/cgi-bin/tools/letter.pl line 302. DBD::mysql::db do failed: Duplicate entry 'circulation-PREDUE--sms-default' for key 'PRIMARY' [for Statement " UPDATE letter SET branchcode = ?, module = ?, name = ?, is_html = ?, title = ?, content = ?, lang = ? WHERE branchcode = ? AND module = ? AND code = ? AND message_transport_type = ? "] at /usr/share/koha/intranet/cgi-bin/tools/letter.pl line 302. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '17

05 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 --- Comment #7 from Ola Andersson <ola.andersson(a)ltu.se> --- Hi Katrin! We would like to enable self registration to our employees only and they are required to enter their department in Address field 2. However in the OPAC we have enabled self modification for all patrons and here address field 2 can be empty for patrons such as students. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '17

05 Dec '17

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '17

05 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #9 from Josef Moravec <josef.moravec(a)gmail.com> --- Comment on attachment 69408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69408 Bug 7046 - Implemented dropdown sub length element Review of attachment 69408: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=704…) ----------------------------------------------------------------- ::: C4/Serials.pm @@ +1509,5 @@ > + $subtype eq 'issues' ? $length : 0, > + $subtype eq 'weeks' ? $length : 0, > + $subtype eq 'months' ? $length : 0, > + ); > +} Now it is not internal subroutine so the name should not start with underscores. Tests are needed for new subroutines in modules. Some refactoring using objects would be nice, but it is out of the scope of this bug report IMO, so no blocker. ::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt @@ +32,4 @@ > </li> > <li><fieldset> > <legend>Subscription length:</legend> > + <select name="subtype" id="subtype"> Here are tabs at beginning, need to be removed -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '17

05 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #8 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Dilan Johnpullé from comment #7) > Created attachment 69408 [details] [review] > Bug 7046 - Implemented dropdown sub length element > > Patch applies and functions as expected in line with test plan. > Signed-off-by: Dilan Johnpullé <dilan(a)calyx.net.au> Dilan, please do not remove the original commit message when you are sign-offing. We need it in git for better understanding of commit content/funcionality. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 9156] itemcallnumber not pulling more than 2 subfields
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '17

05 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Zeno Tajoli <z.tajoli(a)cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli(a)cineca.it | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9156] itemcallnumber not pulling more than 2 subfields
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '17

05 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Zeno Tajoli <z.tajoli(a)cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli(a)cineca.it --- Comment #4 from Zeno Tajoli <z.tajoli(a)cineca.it> --- To fix the probblrm we need to work on line 149 - 160 of ../cataloguing/additem.pl. The lines are: 149 my $pref_itemcallnumber = C4::Context->preference('itemcallnumber'); 150 if (!$value && $subfieldlib->{kohafield} eq 'items.itemcallnumber' && $pref_itemcallnumber) { 151 my $CNtag = substr($pref_itemcallnumber, 0, 3); 152 my $CNsubfield = substr($pref_itemcallnumber, 3, 1); 153 my $CNsubfield2 = substr($pref_itemcallnumber, 4, 1); 154 my $temp2 = $temp->field($CNtag); 155 if ($temp2) { 156 $value = ($temp2->subfield($CNsubfield)).' '.($temp2->subfield($CNsubfield2)); 157 #remove any trailing space incase one subfield is used 158 $value =~ s/^\s+|\s+$//g; 159 } 160 } It is clear that first and second subfields are user. Inside '$temp' you find bibliographic record data. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to reserve first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '17

05 Dec '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #58 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- It's waiting for the patch author to fix the problems pointed out in testing. -- You are receiving this mail because: You are watching all bug changes.

1 0