February 2017 - Koha-bugs - lists.koha-community.org

[Bug 17909] New: Add unit tests for authority merge
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '17

20 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Bug ID: 17909 Summary: Add unit tests for authority merge Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt(a)gmail.com Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 40

[Bug 8306] Patron stats, patron activity : no active doesn't work
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '17

20 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306 --- Comment #14 from Julian Maurice <julian.maurice(a)biblibre.com> --- Pushed to 3.22.x for 3.22.17 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4126] bulkmarcimport.pl allows -b and -a to be specified simultaneously
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '17

20 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4126 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com --- Comment #9 from Julian Maurice <julian.maurice(a)biblibre.com> --- Pushed to 3.22.x for 3.22.17 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 18009] New: IssueSlip.t test fails if launched between 00:00 and 00: 59
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '17

20 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009 Bug ID: 18009 Summary: IssueSlip.t test fails if launched between 00:00 and 00:59 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mtj(a)kohaaloha.com QA Contact: gmcharlt(a)gmail.com here's an example of the test passing then failing with 2 different dates. ------------------------- vagrant@kohadevbox:~$ sudo date -s 'Sun Jan 29 01:41:55 UTC 2017' Sun Jan 29 01:41:55 GMT 2017 kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Members/IssueSlip.t t/db_dependent/Members/IssueSlip.t .. ok All tests successful. Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 2.10 cusr 0.12 csys = 2.25 CPU) Result: PASS ------------------------- vagrant@kohadevbox:~$ sudo date -s 'Sun Jan 29 00:41:55 UTC 2017' Sun Jan 29 00:41:55 GMT 2017 kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Members/IssueSlip.t t/db_dependent/Members/IssueSlip.t .. # Looks like you planned 2 tests but ran 1. # Failed test 'Hourly loans' # at t/db_dependent/Members/IssueSlip.t line 279. # Looks like you failed 1 test of 3. t/db_dependent/Members/IssueSlip.t .. 1/3 # Failed test 'Issue slip' # at t/db_dependent/Members/IssueSlip.t line 281. The 'hour' parameter ("-1") to DateTime::set did not pass the 'an integer between 0 and 23' callback at /usr/lib/x86_64-linux-gnu/perl5/5.20/DateTime.pm line 1946. DateTime::set(undef, "hour", -1) called at t/db_dependent/Members/IssueSlip.t line 254 main::__ANON__() called at /usr/local/share/perl/5.20.2/Test/Builder.pm line 309 eval {...} called at /usr/local/share/perl/5.20.2/Test/Builder.pm line 309 Test::Builder::subtest(Test::Builder=HASH(0x1cfa9d0), "Hourly loans", CODE(0x85c7ea0)) called at /usr/local/share/perl/5.20.2/Test/More.pm line 807 Test::More::subtest("Hourly loans", CODE(0x85c7ea0)) called at t/db_dependent/Members/IssueSlip.t line 279 main::__ANON__() called at /usr/local/share/perl/5.20.2/Test/Builder.pm line 309 eval {...} called at /usr/local/share/perl/5.20.2/Test/Builder.pm line 309 Test::Builder::subtest(Test::Builder=HASH(0x1cfa9d0), "Issue slip", CODE(0x86031c8)) called at /usr/local/share/perl/5.20.2/Test/More.pm line 807 Test::More::subtest("Issue slip", CODE(0x86031c8)) called at t/db_dependent/Members/IssueSlip.t line 281 # Looks like your test exited with 255 just after 1. t/db_dependent/Members/IssueSlip.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 3/3 subtests Test Summary Report ------------------- t/db_dependent/Members/IssueSlip.t (Wstat: 65280 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 Parse errors: Bad plan. You planned 3 tests but ran 1. Files=1, Tests=1, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.79 cusr 0.08 csys = 1.89 CPU) Result: FAIL ------------------------- -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 14764] Add OPAC News branch selector
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '17

20 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 --- Comment #47 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 60452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60452&action=ed… Bug 14764 - [followup] Addressing QA concerns * removed Policy: * put the syspref in alpha order with the others * added els to the if. Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski(a)biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14764] Add OPAC News branch selector
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '17

20 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60396|0 |1 is obsolete| | Attachment #60425|0 |1 is obsolete| | --- Comment #46 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 60451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60451&action=ed… Bug 14764: OPAC news selector Test plan: 1) Add more than one library, at least two in total is needed. Make note of which is your current user's home branch. 2) Go to Tools -> News and add one global ("All") news item and one specific for each branch. 3) Apply the patches. 4) Perform database upgrades when you log in. 5) Go to OPAC main, it should work as before: Showing global news as well as the news for your home branch once logged in. 6) Go to System Preferences -> OPAC and set 'OPACNewsBranchSelect' to yes. 7) Go to OPAC main, you should see the global news item plus any items for your home branch for the current user if logged in. 8) Above the news, you will see a dropdown that lists the branches. Select one, and click "Change library." 9) You should now see global news and the news for the selected branch, regardless of whether logged in or not. Sponsored-By: Halland County Library Fixes QA comments: * Keep the current selected branch selected * Change OPACNewsBranchSelect -> OPACNewsLibrarySelect * fix 'system wide only' view for logged in user. We still show system wide even when a library is selected. * Removed the "change library" link * Added a label to the field. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Zeno Tajoli <z.tajoli(a)cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14764] Add OPAC News branch selector
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '17

20 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11450] Hold Request Confirm Deletion
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '17

20 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com --- Comment #26 from Julian Maurice <julian.maurice(a)biblibre.com> --- Pushed to 3.22.x for 3.22.17 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10978] redirect to basket list of a supplier after deleting a basket
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '17

20 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10978 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60371|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 60449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60449&action=ed… Bug 10978: Redirect to basket list of a supplier after deleting a basket This patch redirects to the vendor's list of baskets after deleting a basket, fixes breadcrumbs after deletion and also hides the toolbar actions after deletion (seeing as you can't edit/export etc a basket that no longer exists). To test: 1) Go to Acquisitions -> find a vendor -> view a basket or create a new basket 2) Delete the basket. Notice you are taken to a list of all vendors and baskets 3) Apply patch and do step 1 again 4) Delete the basket. Notice appropriate breadcrumbs, no toolbar, and confirm link to return to baskets for the vendor works. Sponsored-by: Catalyst IT Followed test plan, works as expected (links to vendor's baskets and all baskets) Signed-off-by: Marc Véron <veron(a)veron.ch> Re-tested. Wording of buttons "Show baskets for vendor..." and "Show all active baskets" makes sense. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10978] redirect to basket list of a supplier after deleting a basket
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '17

20 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10978 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0