February 2017 - Koha-bugs - lists.koha-community.org

[Bug 14405] Add datatable to fines table in OPAC patron account
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '17

16 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14405 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60198|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 60322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60322&action=ed… Bug 14405: Add datatables to fines table in OPAC To test: 1) Apply patch 2) Go to OPAC -> Your account 3) Confirm you can now sort on all columns Sponsored-by: Catalyst IT NOTE: NICE! Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7626] Delete multiple tags at once
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '17

16 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7626 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60294|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 60310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60310&action=ed… Bug 7626: Delete multiple tags in OPAC at once This patch removes the individual 'Delete' buttons for every tag as suggested in Comment 0. It adds a checkbox to every tag, with a 'Delete selected tags' button at the bottom of the table. This patch also adds a function to check if any checkboxes have been checked before submitting the form (only works with JS enabled). To test: 1) Find a record in the OPAC and add some tags to it 2) Go to your tags and notice the checkboxes, no more delete buttons for each tag 3) Click 'Delete selected tags' button without selecting any tags 4) Confirm alert shows up. Click OK 5) Select one or more tags and click 'Delete selected tags' button 6) Confirm delete is successful and correct number of deleted tags shows up Sponsored-by: Catalyst IT Followed test plan, works as expected Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7626] Delete multiple tags at once
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '17

16 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7626 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12478] Elasticsearch support for Koha
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '17

16 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18130 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18130 [Bug 18130] ES - Cannot reindex given biblionumbers -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '17

16 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #10 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Thanks, Aleisha, for picking up this older bug. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '17

16 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #9 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60308&action=ed… Bug 11889: [QA Follow-up] Add entry to sysprefs.sql Also changes the insert in the atomic update to an insert ignore, as we generally do for inserting sysprefs (see updatedatabase). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '17

16 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60307&action=ed… Bug 11889: [Follow-up] Remove share if you are the new owner This will probably be exceptional. But if the staff member already had a share for a private list of the patron he deletes now, he will be the new owner and we should remove the share record. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '17

16 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60224|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 60306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60306&action=ed… Bug 11889: Disown a list upon deletion of owner This patch adds a syspref 'ListOwnershipUponPatronDeletion' which decides if all the owner's lists (public and private) are deleted when the owner is deleted, or if the ownership of their public and shared lists are transfered to the user who deleted the owner (private lists that are not shared are always deleted). To test: 1) Apply patch and update database 2) Set the ListOwnershipUponPatronDeletion syspref to 'Transfer...' 3) Set up a superlibrarian user 4) Log in as this superlibrarian user and set up three lists, a public list (maybe named 'public'), and two private lists (named 'private' and 'shared') 5) Log in as this user to the opac (if you haven't already) and share the 'shared' list with someone 6) View the virtualshelves table in mysql to see the three lists you just created under your new user 7) Also view the virtualshelfshares table in mysql to see the 'shared' list 8) Log into the staff client with your regular user (a different user to the one you just created) 9) Search for the user you just created and delete them 10) Go to your lists 11) You should see the 'shared' list under your private lists, and their 'public' list under your public lists, both with you as the owner 12) if you view both the virtualshelves table and the virtualshelfshares table in mysql again, youll see you are now the owner and the 'private' list will no longer exist. 13) Set the ListOwnershipUponPatronDeletion syspref back to 'Delete...' 14) Repeat steps 3 - 10 again (it may help to delete the 'shared' and 'public' lists before you re-create them) 15) You should not see any of the lists you just made under private or public lists this time. To confirm, check the virtualshelves table in mysql and make sure that all three lists have been deleted. Sponsored-by: Catalyst IT Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '17

16 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10679] Lists interface offers delete option when user doesn' t have permission
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '17

16 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10679 --- Comment #5 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Aleisha Amohia from comment #4) > The reason the delete button was still showing is because, by default, > we allow anyone to remove THEIR OWN contributions from a list. So, the > delete button will always show. This patch makes sure that the delete > button will only show if permission for anyone else to add or delete > their own entries is granted. The permission to add is not relevant here. The only way to make sure if you can delete is check permissions and optionally check if loggedinuser 'owns' entries on that list (or perhaps on the page we show). > To test: > 1) Make a public list setting all permissions to 'do not allow' EXCEPT > 'remove own contributed entries' (set this to Allow). This should be > done by default, but just make sure > 2) Log in as a different user and go to that list. notice the 'remove > selected' button shows, but attempting to delete any records fails. This assumption is not correct. If I added an entry to a public list and the owner later sets the list to 'D-A-D', I should still be able to delete my entry. But you removed the button ! -- You are receiving this mail because: You are watching all bug changes.

1 0