February 2017 - Koha-bugs - lists.koha-community.org

[Bug 8355] "save" button on the result list doesn't have a clear function
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '17

05 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8355 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Aleisha Amohia from comment #3) > Can we mark this as resolved? I don't know how this function looked in 2012 > but in the latest version it is quite clear, with an 'Add to:' label and the > lists marked clearly from the Cart. +1 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '17

03 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset(a)hotmail.com --- Comment #2 from M. Tompsett <mtompset(a)hotmail.com> --- Let's start with the good: authbylogin -- cleaned up. SCOUserJS, SCOUserCSS -- both fixed. AllowSelfCheckReturns -- remnant left behind, but variable is used, so that's okay. Then the weird: display_patron_image -- something isn't quite right. It is only set if there is an image to display, whereas the preference change makes no such distinction. cardnumber is currently only set if there is an image, you could expand the condition. Strangely, cardnumber isn't even used in the template currently. The image logic is using borrower number. Something is wrong. Recommendation: Perhaps a prequel bug is in order to deal with this patron image bug in self-checkout? And lastly the reason I'm Failing QA. $selfchecktimeout -- Remnant left behind, which deals with system preference not being set. Logic in sco-main.tt line 343 does not deal with system preference not being set. Also line 419 in sco-main.tt was unchanged. Recommendation: leave the logic for this as was OR put the logic into the TT file. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '17

03 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #79 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 59898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59898&action=ed… Bug 13757: Better display for attr changes in members-update.pl This patch changes the way changed attributes are displayed for the staff user to make the decision to approve (or not) the changes. Regards -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '17

03 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #78 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 59897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59897&action=ed… Bug 13757: Make K::P::Modifications->pending return K::P::Attribute This patch makes Koha::Patron::Modifications->pending return Koha::Patron:Attribute objects. They are not stored on the DB but only live in memory on runtime. members-update.pl is the only place this is used, and this way we have all we need for better rendering the UI. Tests are added for the changed API. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '17

03 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59813|0 |1 is obsolete| | --- Comment #77 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 59896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59896&action=ed… Bug 13757: (QA followup) Fix non-editable attrs on failed save When a field is not editable but displayable in the OPAC, and you submit an incomplete/wrong update, those attributes are displayed as empty. This patch fixes that. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '17

03 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Jonathan Field <jonathan.field(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '17

03 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood@ptfs-europ | |e.com --- Comment #12 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Installing the Dummy ILL connector ================================== The Dummy connector returns canned responses to search requests and should be used for basic testing of ILL functionality. INSTALL ------- - Change to the correct directory: cd <your_Koha_root_directory>/Koha - If the 'Illbackends' directory does not exist, create it: mkdir Illbackends - Change to the backends directory: cd Illbackends - Clone the Dummy connector repository: git clone https://github.com/a-sassmannshausen/Dummy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '17

03 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #11 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 59895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59895&action=ed… ILLModule -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '17

03 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #10 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 59894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59894&action=ed… DO NOT PUSH: Updated Schema files. * Koha/Schema/Result/Borrower.pm: New file. * Koha/Schema/Result/Branch.pm: New file. * Koha/Schema/Result/Illrequest.pm: New file. * Koha/Schema/Result/Illrequestattribute.pm: New file. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '17

03 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #9 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 59893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59893&action=ed… Bug 7317: Add SQL templates & sysprefs. * installer/data/mysql/atomicupdate/ill_tables.sql: New file. * installer/data/mysql/kohastructure.sql: Add tables. * installer/data/mysql/sysprefs.sql: Add sysprefs. * installer/data/mysql/userflags.sql: Add userflags. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add sysprefs to UI. -- You are receiving this mail because: You are watching all bug changes.

1 0