March 2017 - Koha-bugs - lists.koha-community.org

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '17

22 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '17

22 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61440|0 |1 is obsolete| | --- Comment #49 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 61461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61461&action=ed… Bug 12063 - Fix unit tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '17

22 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #48 from Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> --- (In reply to Marcel de Rooy from comment #44) > (In reply to Andreas Hedström Mace from comment #41) > > And yes that is the same settings I was using. Since it works for both of > > you, I'm going to assume that either it is an issue with my devbox or I made > > a mistake while testing. Going to sign off. > Andreas: > This is not the best introduction for a signoff btw :) Haha, yes, sorry about that. Just wanted to mentioned that I looked at this (cancelation fee) again and got it to work properly. It was an issue with date/time on debian, where it was not correct set. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '17

22 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '17

22 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #32 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- (In reply to Katrin Fischer from comment #23) > At the moment you can't transfer list ownership - so the staff patron would > get stuck with the lists of the deleted patron until they delete them. It > would be good to have an option to do it, but I think that would be a new > bug. The subject of this bug is to disown a list. The heart of this bug is to transfer ownership of a list. I think this patch needs to focus on this topic as a whole and not as a piece. Transferring ownership because the original owner is deleted is only a piece of this puzzle, and if it only focuses on that one piece, a lot of people are going to be annoyed when ownership is transferred and there isn't much that can be done about it besides deleting it. I think a mechanism needs to be in place to move the owner before or during deletion. Perhaps what can be done is to setup a button on the list to transfer ownership. If it is the patron, they can have the option to transfer it to someone it is already shared with. They get to pick. And it is a request to the new patron in which they have to accept or decline, with the ability to add a quick note. If they accept, ownership is transferred. If they decline, the owner is notified. I think a superlibrarian should also have the ability to transfer, with the same options, but they get the ability to chose any patron to send the request to. Another approach for patrons being deleted with shared lists is to have the disowned list be listed in a group of unowned shared lists. A transfer does not necessarily have to occur when the patron/staff account is deleted. Then a superlibrarian or staff with appropriate permissions can use the transfer tool to ask someone if they will take ownership, or they can choose to delete it if they decide the list does not need to be kept. Another question arises...does a shared list have to be owned? If a list is shared or public, couldn't it remain unowned? Maybe it is a part of an unowned list, in which a superlibrarian could either transfer ownership, or discard if needed. But if the sole purpose of a list is to be public, does it have to have an owner to keep being public? Of course it does if it is being modified. Otherwise, if there is just some way to get to and manage unowned lists, do they have to reattach to someone to keep being public/shared? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17512] New: Improve handling dates in C4::Items
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '17

22 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512 Bug ID: 17512 Summary: Improve handling dates in C4::Items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl This is a follow-up on the internal server error on 0000-00-00 in the items column onloan. This patch deals with preventing to have such dates at all in the date fields of items. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '17

22 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #31 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Thx for your signoff, Cedric. The comments earlier from Christopher and Katrin still need attention. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '17

22 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #30 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 61454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61454&action=ed… Bug 11889: [FOLLOW-UP] Tests and new get_shared_shelves subroutine To test: 1) prove t/db_dependent/Virtualshelves.t 2) prove t/db_dependent/Koha/Patrons.t Sponsored-by: Catalyst IT Signed-off-by: Cédric Vita <cedric.vita(a)dracenie.com> Signed-off-by: Cédric Vita <cedric.vita(a)dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '17

22 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #29 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 61453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61453&action=ed… Bug 11889: [QA Follow-up] Add entry to sysprefs.sql Also changes the insert in the atomic update to an insert ignore, as we generally do for inserting sysprefs (see updatedatabase). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Cédric Vita <cedric.vita(a)dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '17

22 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #28 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 61452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61452&action=ed… Bug 11889: [Follow-up] Remove share if you are the new owner This will probably be exceptional. But if the staff member already had a share for a private list of the patron he deletes now, he will be the new owner and we should remove the share record. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Cédric Vita <cedric.vita(a)dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

1 0