March 2017 - Koha-bugs - lists.koha-community.org

[Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #14 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- I do not see a signoff on those patches? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12026] Shibboleth auto-provisioning
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #66 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Code looks good to me. This smaller change has mostly been code reviewed by me. I tested some constructs on itself, but I do not have a shibboleth server. Since most QAers do not and it has been tested by Martin and Mirko, I take the liberty to pass QA on it now. But not without a few remarks :) Koha::Database->new()->schema()->resultset('Borrower') ->find( { $config->{matchpoint} => $match } ); Strictly speaking, you should use find with primary keys/unique constraints. It might fallback to search here depending on your matchpoint (userid has a unique constraint). =head2 _autocreate my ( $retval, $retcard, $retuserid ) = _autocreate( $config, $match ); Given a database handle [...] => Where is that database handle? It got removed after the second patch.. Fixed in a followup. checkpw_shib The change to this routine should normally be accompanied by changes in the tests. Perhaps you should add autocreate => 0 explicitly to mockedConfig in this test. I wonder if testing autocreate => 1 should be done better in a db_dependent test. Since this patch goes such a long way, I do not want to block it now. But please add a small test on a new report. Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12026] Shibboleth auto-provisioning
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 --- Comment #65 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61527&action=ed… Bug 12026: [QA Follow-up] Fix a POD line Still refers to a removed parameter of _autocreate. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12026] Shibboleth auto-provisioning
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61449|0 |1 is obsolete| | --- Comment #64 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61526&action=ed… Bug 12026: [Rebase Follow-up] - Fix Test Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12026] Shibboleth auto-provisioning
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61448|0 |1 is obsolete| | --- Comment #63 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61525&action=ed… Bug 12026: [QA Follow-up] POD typo and tiny change in AddMember_Opac [1] Correct xml error in POD Copy-pasting this example from Auth_with_shibboleth.pm into koha-conf.xml did not work. We need a closing tag ;) [2] If AddMember_Opac calls AddMember_Auto, there is no need to call fixup_cardnumber. Adding trivial test for AddMember_Auto in Members.t. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12026] Shibboleth auto-provisioning
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61447|0 |1 is obsolete| | --- Comment #62 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61524&action=ed… Bug 12026: Fix small errors When running tests I got two errors. Do these changes make sense? Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12026] Shibboleth auto-provisioning
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61446|0 |1 is obsolete| | --- Comment #61 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61523&action=ed… Bug 12026: [Followup] Rebasing Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12026] Shibboleth auto-provisioning
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61445|0 |1 is obsolete| | --- Comment #60 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61522&action=ed… Bug 12026: [Follow up] Added Documentation Updated to work with match point selection - The base bug that this patch enhances has added the ability to choose your match point in the configuration file. This patch adds code to take that change into account. Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12026] Shibboleth auto-provisioning
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61444|0 |1 is obsolete| | --- Comment #59 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61521&action=ed… Bug 12026: Adds auto-provisioning to shibboleth - Adds the option to map shibboleth attributes to koha user columns and allows mapping to auto create non-existant users Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0