March 2017 - Koha-bugs - lists.koha-community.org

[Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #22 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- (In reply to Koha Team AMU from comment #21) > Tested on the Biblibre sandbox n°3. > > In the database : NOTRE DAME DE PARIS / Victor Hugo [Livres] (biblionumber : > 974) > > When we make a suggestion in low-case "notre dame de paris", no warning > message, the suggestion is added. > > When we make a suggestion in upper-case "NOTRE DAME DE PARIS", a warning > message appears before validate. > > It will be better if this patch is not case sensitive. This feature use FindDuplicate function and i think the problem come from here. So i agree that this is not a good match but this patch is not intended to improve matching methods. As mentioned in comment 16, we should improve findDuplicate in another bug. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #17 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61322&action=ed… Bug 11889: [FOLLOW-UP] Tests and new get_shared_shelves subroutine To test: 1) prove t/db_dependent/Virtualshelves.t 2) prove t/db_dependent/Koha/Patrons.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #16 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61321&action=ed… Bug 11889: [QA Follow-up] Add entry to sysprefs.sql Also changes the insert in the atomic update to an insert ignore, as we generally do for inserting sysprefs (see updatedatabase). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #15 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61320&action=ed… Bug 11889: [Follow-up] Remove share if you are the new owner This will probably be exceptional. But if the staff member already had a share for a private list of the patron he deletes now, he will be the new owner and we should remove the share record. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60306|0 |1 is obsolete| | Attachment #60307|0 |1 is obsolete| | Attachment #60308|0 |1 is obsolete| | Attachment #60481|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61319&action=ed… Bug 11889: Disown a list upon deletion of owner This patch adds a syspref 'ListOwnershipUponPatronDeletion' which decides if all the owner's lists (public and private) are deleted when the owner is deleted, or if the ownership of their public and shared lists are transfered to the user who deleted the owner (private lists that are not shared are always deleted). To test: 1) Apply patch and update database 2) Set the ListOwnershipUponPatronDeletion syspref to 'Transfer...' 3) Set up a superlibrarian user 4) Log in as this superlibrarian user and set up three lists, a public list (maybe named 'public'), and two private lists (named 'private' and 'shared') 5) Log in as this user to the opac (if you haven't already) and share the 'shared' list with someone 6) View the virtualshelves table in mysql to see the three lists you just created under your new user 7) Also view the virtualshelfshares table in mysql to see the 'shared' list 8) Log into the staff client with your regular user (a different user to the one you just created) 9) Search for the user you just created and delete them 10) Go to your lists 11) You should see the 'shared' list under your private lists, and their 'public' list under your public lists, both with you as the owner 12) if you view both the virtualshelves table and the virtualshelfshares table in mysql again, youll see you are now the owner and the 'private' list will no longer exist. 13) Set the ListOwnershipUponPatronDeletion syspref back to 'Delete...' 14) Repeat steps 3 - 10 again (it may help to delete the 'shared' and 'public' lists before you re-create them) 15) You should not see any of the lists you just made under private or public lists this time. To confirm, check the virtualshelves table in mysql and make sure that all three lists have been deleted. Sponsored-by: Catalyst IT Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #9 from Rozenn Davenel <rozenn.davenel(a)mairie-vitre.fr> --- With or without the "", the result is the same. when entering amount of "12,34" it is saved as "12.40" in the system. Don't accept formats with full stop or comma as the cents separator, optionally prefixed or suffixed with a currency symbol. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Rozenn Davenel <rozenn.davenel(a)mairie-vitre.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |rozenn.davenel@mairie-vitre | |.fr -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Eric <eric.gosselin.5(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.gosselin.5(a)gmail.com --- Comment #13 from Eric <eric.gosselin.5(a)gmail.com> --- I tried setting up the patch in a sandbox, but twice now I've gotten this email and i can't get to test it. The sandbox you've requested is not ready. Some problems occurred applying patches from bug 11889: <h1>Something went wrong !</h1>Applying: Bug 11889: Disown a list upon deletion of owner Applying: Bug 11889: [Follow-up] Remove share if you are the new owner Applying: Bug 11889: [QA Follow-up] Add entry to sysprefs.sql Applying: Bug 11889: [FOLLOW-UP] Tests and new get_shared_shelves subroutine fatal: sha1 information is lacking or useless (Koha/Patron.pm). Patch failed at 0001 Bug 11889: [FOLLOW-UP] Tests and new get_shared_shelves subroutine -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8603] Patron card creator - 'Barcode Type' doesn't stick in layouts
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8603 --- Comment #3 from Marc Véron <veron(a)veron.ch> --- Hi Jesse, I re-tested with an existing and a new layout for Patron card creator, it works fine for me. Can you provide the steps you did for testing? Thanks Marc -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6979] LDAP authentication fails during password comparison
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 --- Comment #43 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- OK.. Passing QA. I'm happy with the code here, and it moves us towards a more secure by default model. However, we'll need to highlight in the release notes that this patch effectively removes the auth by password comparison option from koha.. one always binds with this model. I don't think this is a bad move and I've yet to ever come across somewhere that actually requires a password comparison regime. We should push and fix the consequences in this case in my opinion. -- You are receiving this mail because: You are watching all bug changes.

1 0