March 2017 - Koha-bugs - lists.koha-community.org

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #54 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Patches "Add a subtest for specific postponed merge issues", and "Few subtle changes for postponed merge" have been slightly adjusted to catch a bug as reported by Jacek. The unit is adjusted to also include this case. Thanks, Jacek! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6979] LDAP authentication fails during password comparison
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61298|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 61313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61313&action=ed… Bug 6979 - Fix Already in a transaction error Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6979] LDAP authentication fails during password comparison
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6979] LDAP authentication fails during password comparison
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61297|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 61312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61312&action=ed… Bug 6979 - Handle multiple branches in non-auth_by_bin Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6979] LDAP authentication fails during password comparison
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61296|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 61311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61311&action=ed… Bug 6979 - Update tests Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6979] LDAP authentication fails during password comparison
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61295|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 61310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61310&action=ed… Bug #6979 I removed several lines of code in the checkpw_ldap subroutine where LDAP authentication takes place, in the "else" part of the conditional that checks for the auth_by_bind config parameter. I added several lines to check whether the user can log in to LDAP using their DN and the password supplied in the login form. If they are able to bind, login contiues as normal and the LDAP attributes can be harvested as normal if the update options are turned on. The routine that was in place was failing because it was trying to check against a non-existent LDAP entry attribute called 'userpassword'. Instead of checking against a 'userpassword' attribute, the routine really should be checking to make sure the user can actually bind to LDAP. That's what I set up, and it is a safer way to test authentication against LDAP. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60675|0 |1 is obsolete| | --- Comment #53 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61309&action=ed… Bug 9988: Add the cronjob and print an upgrade message The Debian cron file and the misc crontab example are updated. A message is printed when upgrading. Note: At this moment the merge cron job is run once a day. This is imo a good starting point. The load for this job greatly depends on the value of pref AuthorityMergeLimit. Of course you can schedule the job more often, and if this need is felt more globally, we can adjust it later. Test plan: [1] Run the dbrev and see the message. [2] Read the changes to the cron files. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60674|0 |1 is obsolete| | --- Comment #52 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61308&action=ed… Bug 9988: Refactor the cron script The cron job is moved from migration tools to cronjobs. And renamed to a plural form. The script is now based on Koha objects. It does no longer include the code to merge one record. This can be done via the interface, and will be added to a maintenance script on bug 18071. Should not be part of this cron job. Adding a cron_cleanup method to MergeRequests; this method is called from the cron script to reset older entries still marked in progress and to also remove old processed entries. Tested in a separate unit test. Test plan: [1] Run t/db_dependent/Authorities/MergeRequests.t [2] Set AuthorityMergeLimit to 0. (All merges are postponed.) [3] Modify an authority linked to a few records. [4] Delete an authority linked to a few records with batch delete tool. [5] And select two auth records with linked records. Merge these two records with authority/merge.pl. Note: Do not select Default. See also bug 17380. [6] Check the need_merge_authorities table for inserted records. [7] Run misc/cronjobs/merge_authorities.pl -b and inspect the linked records and the record status in need_merge_authorities. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60673|0 |1 is obsolete| | --- Comment #51 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61307&action=ed… Bug 9988: Few subtle changes for postponed merge The fails in the previous test showed that we need the first three changes here. Some final polishing in points 4 to 6. [1] Sub merge: Refine the condition for initializing $tags_new. A postponed 'modify'-merge (A to B) makes that $authtypefrom is not defined when running merge later. When crossing the type boundary, we need a new field too. [2] Sub merge: Add condition for an empty @record_to array. This indicates also that a field should be removed, since we should otherwise only add a $9 subfield. [3] Sub merge: Adjust initializing @record_from. This change is tested by verifying a cleared subfield in the test. [4] DelAuthority: Adding a skipmerge parameter to allow the call from authorities/merge.pl to skip an unneeded merge. This also prevents that the 'delete-merge' would precede the 'modify-merge' under a hypothetical race condition. [5] DelAuthority: There is actually no need to call GetAuthority. The subfields of the old record are not relevant in this case. [6] Added a few POD lines to merge. [7] Removed a trailing space in a comment line in merge. Test plan: [1] Run t/db_dependent/Authorities/Merge.t. The last subtest should no longer fail now. [2] See test plan of next patch. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '17

21 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60672|0 |1 is obsolete| | --- Comment #50 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61306&action=ed… Bug 9988: Add a subtest for specific postponed merge issues This subtest shows that we need a few little tweaks to make merge work in some specific postponed merge situations. Test plan: [1] Run t/db_dependent/Authorities/Merge.t. The last subtest should fail. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0