March 2017 - Koha-bugs - lists.koha-community.org

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61047|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61046|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60883|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60882|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60881|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60880|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60879|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60878|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes(a)biblibre.com --- Comment #42 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Patch tested with a sandbox, by Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #75 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Marcel de Rooy from comment #70) > (In reply to Jonathan Druart from comment #69) > > I have the feeling that there is a design issue. I'd have let the type="sql" > > but add another DB field ('usage' or similar) to identify how the profile > > can be used. > > I agree with Jonathan. > Although I acknowledge that this patch already has quite a history already. > > Export format is the name of the table for the CSV profiles (this is already > confusing btw). Actually, csv profiles would be a better name. > The column type should be either marc or sql: we refer to marc fields or > database columns. > But yes, we need an additional column where to use which profile. Probably > we can start here with the simple list we have now. Could be expanded later.. > > About t/db_dependent/Acquisition/GetBasketAsCSV.t: > Remove the dbh statements. You do not need them. You use schema txn.. > You pass a new CGI object in your test. You probably can; just wondering if > you should mock C4::Languages::getlanguage and not use CGI here. > Typo defautl So, I rebased the patch on top of current master and added some followups. Changes made - - revert the changes in csv profile types so there are again only two - marc and sql - added new db column used_for, which should say where the profile could be used - fix typo and remove dbh from test GetBasketAsCSV.t How do you think the mocked getlanguage could be used? The soubroutine GetBasketAsCSV does need the CGI object as a param... -- You are receiving this mail because: You are watching all bug changes.

1 0