March 2017 - Koha-bugs - lists.koha-community.org

[Bug 8010] Search history can be added to the wrong patron
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61256|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 61288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61288&action=ed… Added a new syspref to Load history to the next user Added a syspref LoadHistory addSearchHistoryToTheFirstLoggedUser to select if you want the system to add the history of searches performed without session when you log in as registered user. TEST PLAN 1 - Search in the catalogue, check you are not logged 2 - Log in : your last history should appear 4 - Log out 5 - Apply the patch 6 - Repeat 1 and 2 7 - Desactivate the syspref addSearchHistoryToTheFirstLoggedUser 8 - Repeat 1 and 2 : your last history shouldn't appear The Unit test doesn't rollback but delete the added lines : the function get_template_and_user allway sets the autocommit to 1. https://bugs.koha-community.org/show_bug.cgi?id=8010 Tested 3 patches together, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #42 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Marcel de Rooy from comment #41) > Especially the "Few subtle changes" patch makes a few additional refinements > in this regard. I can see an accommodation in this commit for missing $authtypefrom (for a postponed merge, when the old record is already deleted), but it doesn't look quite relevant to empty @record_from ;). I think there may be a problem in the code which is located above that instead, namely my $authfrom = Koha::Authorities->find($mergefrom); my $authtypefrom = $authfrom ? Koha::Authority::Types->find($authfrom->authtypecode) : undef; my $auth_tag_to_report_from = $authtypefrom ? $authtypefrom->auth_tag_to_report : ''; my @record_from; @record_from = $MARCfrom->field($auth_tag_to_report_from)->subfields() if $auth_tag_to_report_from && $MARCfrom && $MARCfrom->field($auth_tag_to_report_from); If the search my $authfrom = Koha::Authorities->find($mergefrom); fails (I'm guessing it will fail, for the postponed "real" merge ?), $MARCfrom will be ignored, no matter what (it's not used anywhere else in the merge() subroutine) and @record_from will be empty. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #50 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 61280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61280&action=ed… Bug 7534: Check hold availability to desired pickup location in opac-reserve.pl To test: -1. Have access to your browser's developer tools in order to modify <select> dropdown values 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No". Remember the branchcode of this library! 3. Go place a hold in OPAC 4. See the provided "Pick up location" list 5. Observe the library that you configured is not present in the list 6. You should see another library selected by default. Right click that and in Firefox/Chrome click "Inspect element" 7. You should see a list of <option value="xxxx">blabla</option> elements 8. Double click between value (xxxx in above example) and replace the value with the branchcode you remember from step 2. 9. Place the hold 10. Observe that you are taken to cgi-bin/koha/opac-user.pl but your hold was not successful. 11. Go back to place a hold and this time do not modify any values. 12. Observe that a hold is now placed. Signed-off-by: Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #49 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 61279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61279&action=ed… Bug 7534: Validate pickup location in CanBook/ItemBeReserved This patch adds $branchcode_to parameter to CanBookBeReserved and CanItemBeReserved. It represents the pickup location for the hold. To test: 1. prove t/db_dependent/Holds.t Signed-off-by: Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #48 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 61278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61278&action=ed… Bug 7534: (QA-follow-up) Default pickup location to Yes when adding a new library To test: 1. Apply the patches before this one 2. Go to /cgi-bin/koha/admin/branches.pl 3. Press New library button 4. Scroll down the page and observe Pickup location defaults to No 5. Apply this patch 6. Go to /cgi-bin/koha/admin/branches.pl 7. Press New library button 8. Scroll down the page and observe Pickup location now defaults to Yes Signed-off-by: Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #47 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 61277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61277&action=ed… Bug 7534: Display pickup locations instead of all libraries in opac-reserve.pl This patch sets opac-reserve.tt to use the list of pickup libraries instead of every library in the system. To test: 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No" 3. Go to OPAC and place a hold 4. See the provided Pickup location list 5. Observe the library that you configured is not present in the list Signed-off-by: Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #46 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 61276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61276&action=ed… Bug 7534: Display pickup locations instead of all libraries in request.pl This patch sets request.tt to use the list of pickup libraries instead of every library in the system. To test: 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No" 3. Go place a hold in intranet 4. See the provided "Pickup at" list 5. Observe the library that you configured is not present in the list 6. Place the hold 7. See list of existing holds on that biblio 8. See "Pickup library" column and observe your configured library is not included in the list Signed-off-by: Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #45 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 61275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61275&action=ed… Bug 7534: Add configuration to admin/branches.pl This patch adds a configuration option for pickup locations. To test: 1. Apply patch 2. Go to cgi-bin/koha/admin/branches.pl 3. Observe there is a new column "Pickup location" 4. Click "Edit" for any library 5. Scroll to bottom of the page and select "No" 6. Click "Submit" 7. Observe your library in Libraries-table, notice the value of "Pickup location" has changed to "No" Signed-off-by: Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #44 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 61274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61274&action=ed… Bug 7534: Use search parameters for Koha::Template::Plugin::Branches->all This lets us query libraries with additional search parameters and is useful for this particular Bug by allowing us to select pickup locations. Unit tests included. To test: 1. prove t/db_dependent/Template/Plugin/Branches.t Signed-off-by: Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #43 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 61273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61273&action=ed… Bug 7534: Add new column "pickup_location" to branches This patch adds a new column "pickup_location" for each library. This value defines whether a library can be used as a pickup location or not. For extended configurability, this flag could perhaps be considered as a part of issuing rules, but as of now, this patch only offers a simple flag into each library. This method also allows easy way for REST API to determine valid pickup locations by querying the /libraries endpoint. To test: 1. perl installer/data/mysql/updatedatabase.pl 2. Observe DEV atomic update: bug_7534.perl Upgrade to XXX done (Bug 7534 - Let libraries have configuration for pickup locations) https://bugs.koha-community.org/show_bug.cgi?id=7354 Signed-off-by: Koha Team AMU <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0