March 2017 - Koha-bugs - lists.koha-community.org

[Bug 14365] SQL Reports Last Edit Date column
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14365 --- Comment #12 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61222&action=ed… Bug 14365 - Change 'Last modified' to 'Last edit' for terseness Signed-off-by: Cab Vinton <director(a)plaistowlibrary.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14365] SQL Reports Last Edit Date column
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14365 --- Comment #11 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61221&action=ed… Bug 14365 - SQL Reports Last Edit Date column - Show in interface Test Plan: 1) Apply these patches 2) Modify a saved sql report 3) Note the "Last modified" column is updated 4) Run the report 5) Note the "Last run" column is updated Signed-off-by: Cab Vinton <director(a)plaistowlibrary.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14365] SQL Reports Last Edit Date column
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14365 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61060|0 |1 is obsolete| | Attachment #61061|0 |1 is obsolete| | Attachment #61062|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61220&action=ed… Bug 14365 - Populate never used saved_sql column last_run when execute_query is called Signed-off-by: Cab Vinton <director(a)plaistowlibrary.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14365] SQL Reports Last Edit Date column
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14365 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Not blocker but it would have been good to update the prototype of the subroutine to pass a hashref instead of the list of undef... This new parameter is a bit awkward: if the id is passed, a DB field is updated. Not elegant but given the quality of the existing code it's hard to provide something better... Passing QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14544] Move the list related code to Koha::Virtualshelves
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 [Bug 17886] Don't show option to add to existing list if there are no lists -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11431] Custom notification sounds
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18251 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15541] Prevent normalization during matching/import process
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 --- Comment #37 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Looks good to me. Finally :) %options: Putting a hash in the parameter list may be tricky of course. We always like to have unit tests. But unfortunately we have no tests for get_matches.. Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15541] Prevent normalization during matching/import process
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59295|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61216&action=ed… Bug 15541 - Prevent normalization during matching/import process This patch allows you to use the "qualifier,qualifier" syntax in the Record Matching Rules "Search Index" when using the QueryParser. While QueryParser doesn't support this syntax, it will now fallback correctly to non-QueryParser functionality. Without the patch, your search will just fail silently. This patch also adds a "skip_normalize" option to C4::Search::SimpleSearch(), and uses the option during C4::Matcher::get_matches. This prevents the s/:/=/g and s/=/:/g normalization. This normalization is heavy-handed, and while it is necessary sometimes to generate a valid CCL query or QueryParser query, C4::Matcher::get_matches() already produces a valid CCL query, so we don't need to do this normalization. Additionally, this normalization causes problems when you use a Zebra register which isn't normalized: namely the "u" register. Strings are stored "as is", so http://localhost/koha/resource/1 is stored as is during indexing. When you search, you need to pass the exact same thing through the query to get a match. Using http=//localhost/koha/resource/1 in your query will yield zero results. _TEST PLAN_ 0) Apply patch 1) Create a Record Matching Rule in Koha with the following details: Matching rule code: TEST Description: Test Match threshold: 100 Record type: Bibliographic Match point 1: Search index: id-other,st-urx Score: 100 Tag: 024 Subfields: a Normalization rule: None 2) Create a record in Koha with an indexable URI 2a) Default framework 2b) 024 $a http://koha-community.org/test $2 uri 2c) 040 $c test 2d) 245 $a This is a test record 2e) 942 $c Books 2f) Save (save again if cautioned about missing fields as these should autofill) 3) Do a full re-index of Zebra 4) Download your record from Koha as a .mrc file (ie isomarc, binary marc, etc) 5) Go to "Stage MARC records for import" 5a) Upload your .marc file. 5b) Change your "Record matching rule" to "Test" 5c) Click Stage for import 9) It should say "1 records with at least one match in catalog per matching rule "Test". NOTE: For completeness, you can go through this process on a clean master branch, and note that it will say '0 records with at least one match in catalog per matching rule "TEST"' Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15541] Prevent normalization during matching/import process
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13205] Last/First page options for result list paging
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Hi Aleisha, It's a bit more complicated, we do not want to see First and Last when they are not needed (for instance if you are on the first or last page). I would have written my $last_page = ($pages * $results_per_page) - $results_per_page; that way: my $last_page = $pages * ( $results_per_page - 1 ); Sounds more readable. -- You are receiving this mail because: You are watching all bug changes.

1 0