March 2017 - Koha-bugs - lists.koha-community.org

[Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 --- Comment #13 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Trivial rebase iirc -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27488|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 --- Comment #12 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61200&action=ed… Bug 12021 - SIP2 checkin should alert on transfer and use CT for return branch This small patch corrects the SIP2 checkin response if branch transfer is needed. It depends on bug 7981 and also removes an obsolete alert check in SIP2. Test plan: - apply bug 7981 - make sure syspref AutomaticItemReturn is false - check 'Return policy' in 'Default checkout, hold and return policy' - make a SIP2 checkout and checkin from a branch different than item's home branch. - verify that SIP2 response gives alert CV04 (=send to different branch) - also verify that response field CT gives correct branch according to 'Return policy' Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 --- Comment #11 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Still applies. Saw the CV04 but not the CT (protocol issue). A branch transfer was created for checkin at another location. Will come back here later. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7029] searching : fuzzy et steming
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7029 --- Comment #8 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- You have the syspref IncludeSeeFormInSearches on, it may impact the search results on worlds not visible in the biblio record. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue!
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18292 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 [Bug 18292] t/db_dependent/Circulation.t Dubious, test returned 1 even if test ok -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13205] Last/First page options for result list paging
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 dilan(a)calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan(a)calyx.net.au Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13205] Last/First page options for result list paging
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 --- Comment #7 from dilan(a)calyx.net.au --- Comment on attachment 61194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61194 Bug 13205: Last/first page options for result list paging for OPAC >From bd80eca290f389e8e12d63dd220ec639763adcbb Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia(a)hotmail.com> >Date: Thu, 16 Feb 2017 02:28:13 +0000 >Subject: [PATCH] Bug 13205: Last/first page options for result list paging for > OPAC > >Same fix but on OPAC side. Same test plan > >Sponsored-by: Catalyst IT > >Signed-off-by: Dilan Johnpulle <dilan(a)calyx.net.au> > >--- > .../bootstrap/en/includes/page-numbers.inc | 26 ++++++++++++---------- > opac/opac-search.pl | 2 ++ > 2 files changed, 16 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc >index f18c9ce..63e083e 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc >@@ -1,19 +1,21 @@ > [% IF ( PAGE_NUMBERS ) %] > <div class="pagination pagination-small noprint"> > <ul> >- [% IF ( previous_page_offset.defined ) %] >- <li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %]&offset=[% previous_page_offset %][% IF ( sort_by ) %]&sort_by=[% sort_by |html %][% END %]">« Previous</a></li> >- [% END %] >- [% FOREACH PAGE_NUMBER IN PAGE_NUMBERS %] >- [% IF ( PAGE_NUMBER.highlight ) %] >- <li class="active"><a href="#">[% PAGE_NUMBER.pg %]</a></li> >- [% ELSE %] >- <li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %]&offset=[% PAGE_NUMBER.offset %][% IF ( sort_by ) %]&sort_by=[% sort_by |html%][% END %]">[% PAGE_NUMBER.pg %]</a></li> >+ <li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %][% IF ( sort_by ) %]&sort_by=[% sort_by |html %][% END %]">First</a></li> >+ [% IF ( previous_page_offset.defined ) %] >+ <li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %]&offset=[% previous_page_offset %][% IF ( sort_by ) %]&sort_by=[% sort_by |html %][% END %]">« Previous</a></li> > [% END %] >- [% END %] >- [% IF ( next_page_offset ) %] >- <li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %]&offset=[% next_page_offset %][% IF ( sort_by ) %]&sort_by=[% sort_by |html %][% END %]">Next »</a></li> >- [% END %] >+ [% FOREACH PAGE_NUMBER IN PAGE_NUMBERS %] >+ [% IF ( PAGE_NUMBER.highlight ) %] >+ <li class="active"><a href="#">[% PAGE_NUMBER.pg %]</a></li> >+ [% ELSE %] >+ <li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %]&offset=[% PAGE_NUMBER.offset %][% IF ( sort_by ) %]&sort_by=[% sort_by |html%][% END %]">[% PAGE_NUMBER.pg %]</a></li> >+ [% END %] >+ [% END %] >+ [% IF ( next_page_offset ) %] >+ <li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %]&offset=[% next_page_offset %][% IF ( sort_by ) %]&sort_by=[% sort_by |html %][% END %]">Next »</a></li> >+ [% END %] >+ <li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %]&offset=[% last_page %][% IF ( sort_by ) %]&sort_by=[% sort_by |html %][% END %]">Last</a></li> > </ul> > </div> > [% END %] >diff --git a/opac/opac-search.pl b/opac/opac-search.pl >index a84e9d3..130aad3 100755 >--- a/opac/opac-search.pl >+++ b/opac/opac-search.pl >@@ -837,6 +837,7 @@ for (my $i=0;$i<@servers;$i++) { > my @page_numbers; > # total number of pages there will be > my $pages = ceil($hits / $results_per_page); >+ my $last_page = ($pages * $results_per_page) - $results_per_page; > # default page number > my $current_page_number = 1; > if ($offset) { >@@ -887,6 +888,7 @@ for (my $i=0;$i<@servers;$i++) { > > } > $template->param( PAGE_NUMBERS => \@page_numbers, >+ last_page => $last_page, > previous_page_offset => $previous_page_offset) unless $pages < 2; > $template->param(next_page_offset => $next_page_offset) unless $pages eq $current_page_number; > } >-- >2.1.4 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13205] Last/First page options for result list paging
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 --- Comment #6 from dilan(a)calyx.net.au --- Comment on attachment 61194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61194 Bug 13205: Last/first page options for result list paging for OPAC >From bd80eca290f389e8e12d63dd220ec639763adcbb Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia(a)hotmail.com> >Date: Thu, 16 Feb 2017 02:28:13 +0000 >Subject: [PATCH] Bug 13205: Last/first page options for result list paging for > OPAC > >Same fix but on OPAC side. Same test plan > >Sponsored-by: Catalyst IT > >Signed-off-by: Dilan Johnpulle <dilan(a)calyx.net.au> > >--- > .../bootstrap/en/includes/page-numbers.inc | 26 ++++++++++++---------- > opac/opac-search.pl | 2 ++ > 2 files changed, 16 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc >index f18c9ce..63e083e 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc >@@ -1,19 +1,21 @@ > [% IF ( PAGE_NUMBERS ) %] > <div class="pagination pagination-small noprint"> > <ul> >- [% IF ( previous_page_offset.defined ) %] >- <li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %]&offset=[% previous_page_offset %][% IF ( sort_by ) %]&sort_by=[% sort_by |html %][% END %]">« Previous</a></li> >- [% END %] >- [% FOREACH PAGE_NUMBER IN PAGE_NUMBERS %] >- [% IF ( PAGE_NUMBER.highlight ) %] >- <li class="active"><a href="#">[% PAGE_NUMBER.pg %]</a></li> >- [% ELSE %] >- <li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %]&offset=[% PAGE_NUMBER.offset %][% IF ( sort_by ) %]&sort_by=[% sort_by |html%][% END %]">[% PAGE_NUMBER.pg %]</a></li> >+ <li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %][% IF ( sort_by ) %]&sort_by=[% sort_by |html %][% END %]">First</a></li> >+ [% IF ( previous_page_offset.defined ) %] >+ <li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %]&offset=[% previous_page_offset %][% IF ( sort_by ) %]&sort_by=[% sort_by |html %][% END %]">« Previous</a></li> > [% END %] >- [% END %] >- [% IF ( next_page_offset ) %] >- <li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %]&offset=[% next_page_offset %][% IF ( sort_by ) %]&sort_by=[% sort_by |html %][% END %]">Next »</a></li> >- [% END %] >+ [% FOREACH PAGE_NUMBER IN PAGE_NUMBERS %] >+ [% IF ( PAGE_NUMBER.highlight ) %] >+ <li class="active"><a href="#">[% PAGE_NUMBER.pg %]</a></li> >+ [% ELSE %] >+ <li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %]&offset=[% PAGE_NUMBER.offset %][% IF ( sort_by ) %]&sort_by=[% sort_by |html%][% END %]">[% PAGE_NUMBER.pg %]</a></li> >+ [% END %] >+ [% END %] >+ [% IF ( next_page_offset ) %] >+ <li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %]&offset=[% next_page_offset %][% IF ( sort_by ) %]&sort_by=[% sort_by |html %][% END %]">Next »</a></li> >+ [% END %] >+ <li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %]&offset=[% last_page %][% IF ( sort_by ) %]&sort_by=[% sort_by |html %][% END %]">Last</a></li> > </ul> > </div> > [% END %] >diff --git a/opac/opac-search.pl b/opac/opac-search.pl >index a84e9d3..130aad3 100755 >--- a/opac/opac-search.pl >+++ b/opac/opac-search.pl >@@ -837,6 +837,7 @@ for (my $i=0;$i<@servers;$i++) { > my @page_numbers; > # total number of pages there will be > my $pages = ceil($hits / $results_per_page); >+ my $last_page = ($pages * $results_per_page) - $results_per_page; > # default page number > my $current_page_number = 1; > if ($offset) { >@@ -887,6 +888,7 @@ for (my $i=0;$i<@servers;$i++) { > > } > $template->param( PAGE_NUMBERS => \@page_numbers, >+ last_page => $last_page, > previous_page_offset => $previous_page_offset) unless $pages < 2; > $template->param(next_page_offset => $next_page_offset) unless $pages eq $current_page_number; > } >-- >2.1.4 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13205] Last/First page options for result list paging
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '17

17 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 dilan(a)calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60300|0 |1 is obsolete| | --- Comment #5 from dilan(a)calyx.net.au --- Created attachment 61194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61194&action=ed… Bug 13205: Last/first page options for result list paging for OPAC Same fix but on OPAC side. Same test plan Sponsored-by: Catalyst IT Signed-off-by: Dilan Johnpulle <dilan(a)calyx.net.au> Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.

1 0