April 2017 - Koha-bugs - lists.koha-community.org

[Bug 10382] collection not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '17

18 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #26 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hm, so is the problem that we save 'unchanged' instead of the original value, no matter if it was changed or not? And 'null' would be confusing, as it could mean 'unchanged' as well as 'was empty before'? So could it work like that? - change from a to b (changed, store a) - change from none to a (changed, store none) < current problem - change from a to none (changed, store a) - change from none to none (unchanged, store unchanged) - change from a to a (unchanged, store unchanged) I think the advantage of <unchanged> is currently that if you change the collection/location while the item is in the course reserve, with 'unchanged' it won't reset it by accident when you remove the item from the course reserve - the new value will stay. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10382] collection not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '17

18 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #25 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- (In reply to Jonathan Druart from comment #24) > This <UNCHANGED> stuff smells like a very bad codding pattern. > Could not we use empty string and undef/NULL to handle empty values? Hello Jonathan, I don't really see how to do that. If you create a course item this way: my $ci_id2 = ModCourseItem( itemnumber => $itemnumber, itype => '', ccode => 'BOOK', holdingbranch => '<UNCHANGED>', location => '<UNCHANGED>', ); or this way my $ci_id2 = ModCourseItem( itemnumber => $itemnumber, ccode => 'BOOK', holdingbranch => '<UNCHANGED>', location => '<UNCHANGED>', ); This results to the same when getting the course with GetCourseItem: itype is undef. Empty or null value are retrieved the same and we are unable to know if the value has changed or not. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4246] Koha support for Itiva Talking Tech phone notification service
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '17

18 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18444 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18444 [Bug 18444] Add TalkingTechItivaPhoneNotification to sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 7550] Self checkout: limit display of patron image to logged-in patron
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '17

18 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7550] Self checkout: limit display of patron image to logged-in patron
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '17

18 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62271|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron(a)veron.ch> --- Created attachment 62272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62272&action=ed… Bug 7550 - Self checkout: limit display of patron image to logged-in patron The patron image display in the self-checkout takes a GET parameter from the image source, so if someone copied the image location and substituted the barcode string they could browse through all patron images: <img alt="" src="/cgi-bin/koha/sco/sco-patron-image.pl?borrowernumber=XXXX"> To reproduce: - Enable self checkout, go to [Your Server]//cgi-bin/koha/sco/sco-main.pl - Log in with a user 'A' who has a patron image - Copy the address of the patron image into an other browser window - Change the borrowernumber to on of an other user 'B' having a patron image - Verify that the patron image is displayed To test: - Apply patch, restart plack / memcached - Try to reproduce - Verify that you can no longer display the image of user 'B' by tweaking the image address -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '17

18 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7550] Self checkout: limit display of patron image to logged-in patron
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '17

18 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 --- Comment #4 from Marc Véron <veron(a)veron.ch> --- Created attachment 62271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62271&action=ed… Bug 7550 - Self checkout: limit display of patron image to logged-in patron The patron image display in the self-checkout takes a GET parameter from the image source, so if someone copied the image location and substituted the barcode string they could browse through all patron images: <img alt="" src="/cgi-bin/koha/sco/sco-patron-image.pl?borrowernumber=XXXX"> To reproduce: - Enable self checkout, go to [Your Server]//cgi-bin/koha/sco/sco-main.pl - Log in with a user 'A' who has a patron image - Copy the address of the patron image into an other browser window - Change the borrowernumber to on of an other user 'B' having a patron image - Verify that the patron image is displayed To test: - Apply patch, restart plack / memcached - Try to reproduce - Verify that you can no longer display the image of user 'B' by tweaking the image address - Log out user 'A' from SCO (click 'Finish') - Try to display image of user 'A', verify that it is not possible - Log out form SCO (go to an other OPAC page) - Try to display image of user 'A', verify that it is not possible -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7550] Self checkout: limit display of patron image to logged-in patron
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '17

18 Apr '17

1 0

[Bug 17659] New: sample_notices.sql is broken for fr-QA
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '17

18 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17659 Bug ID: 17659 Summary: sample_notices.sql is broken for fr-QA Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 5260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 [Bug 5260] Add option to send an order by e-mail to the acquisition module -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 5260] Add option to send an order by e-mail to the acquisition module
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '17

18 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0