April 2017 - Koha-bugs - lists.koha-community.org

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '17

17 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61854|0 |1 is obsolete| | --- Comment #102 from Marc Véron <veron(a)veron.ch> --- Created attachment 62203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62203&action=ed… Bug 14224: Update Copyright Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '17

17 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61853|0 |1 is obsolete| | --- Comment #101 from Marc Véron <veron(a)veron.ch> --- Created attachment 62202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62202&action=ed… Bug 14224: Replace AllowIssueNotes with AllowCheckoutNotes Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '17

17 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61852|0 |1 is obsolete| | --- Comment #100 from Marc Véron <veron(a)veron.ch> --- Created attachment 62201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62201&action=ed… Bug 14224: Make strings translatable The strings should be translatable. This patch also removes the error as it appears that we only have 1 error. To improve we could surround the store with an eval. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '17

17 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61851|0 |1 is obsolete| | --- Comment #99 from Marc Véron <veron(a)veron.ch> --- Created attachment 62200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62200&action=ed… Bug 14224: Fix prevent submit That did not work, the form was submitted anyway Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '17

17 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61850|0 |1 is obsolete| | --- Comment #98 from Marc Véron <veron(a)veron.ch> --- Created attachment 62199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62199&action=ed… Bug 14224: Remove SQL query in svc script Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '17

17 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61849|0 |1 is obsolete| | --- Comment #97 from Marc Véron <veron(a)veron.ch> --- Created attachment 62198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62198&action=ed… Bug 14224: Reintroduce previous copyright Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '17

17 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61848|0 |1 is obsolete| | --- Comment #96 from Marc Véron <veron(a)veron.ch> --- Created attachment 62197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62197&action=ed… Bug 14224: Do not reintroduce GetItemIssue, it's dying Bug 17680 is removing it. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '17

17 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61847|0 |1 is obsolete| | --- Comment #95 from Marc Véron <veron(a)veron.ch> --- Created attachment 62196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62196&action=ed… Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Update database 3) Rebuild schema 4) Turn on 'AllowIssueNote' syspref 5) Check out three different items to a borrower (may be easiest to check out to yourself) 6) Log in as that borrower (or yourself) on the OPAC side and go to your summary 7) Confirm text field shows under Note column for all checkouts. Set a note for each issue, confirm all save. 8) Check the message_queue in mysql for the entries for ALL THREE issue notes. 9) Disable javascript in your browser 10) Refresh your summary page. Confirm that you can no longer edit the notes in the text field. Click the 'Create/edit note' button and confirm you are redirected to a new page. 11) Confirm that the correct title and author show for the note button you clicked. 12) Set the note and click Submit -> confirm you are redirected back to summary page and note is saved 13) Confirm there is a new entry in message_queue 14) Enable javascript and go back to the your checkouts page in the staff client for the borrower you issued the items to 15) Check in TWO items 16) Confirm that the issue notes show under the "Date due" column for the two items you checked in, and are accurate to the item (i.e. the right issue note under the right item) 17) Go to circ/returns.pl and check in the final item using the barcode. Confirm the issue note shows and the date is formatted correctly. Sponsored-by: Region Halland Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '17

17 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18438 --- Comment #94 from Marc Véron <veron(a)veron.ch> --- (In reply to Marc Véron from comment #93) > (In reply to Marc Véron from comment #91) > > Test plan step 4): > > AllowIssueNotes should read AllowCheckoutNotes > > > > ------ > > Test plan step 17: > > If I return an item with a hold placed on it, the note does not show. I see > > only the message about confirming hold. > > The problem is NOT related to this patch set. If there is a hold, the pop-up > window concerning the hold hides other messages on the main screen > (returns.pl). > :( See: Bug 18438 - Check in: Modal about holds hides important check in messages -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11360] Disable barcode field and submit button when a hold is found
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '17

17 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18438 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 [Bug 18438] Check in: Modal about holds hides important check in messages -- You are receiving this mail because: You are watching all bug changes.

1 0