April 2017 - Koha-bugs - lists.koha-community.org

[Bug 14932] serials/ serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial!
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle(a)bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 17.05, thanks Olli! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18413] New: Fix Letters.t (follow-up of 17866)
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18413 Bug ID: 18413 Summary: Fix Letters.t (follow-up of 17866) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: gmcharlt(a)gmail.com t/db_dependent/Letters.t .. 1/80 Can't call method "branchemail" on an undefined value at /home/vagrant/kohaclone/C4/Letters.pm line 576. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 --- Comment #13 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 62141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62141&action=ed… Bug 14698 - AtomicUpdater - addAllAtomicUpdates This patch adds a new method Koha::AtomicUpdater->addAllAtomicUpdates that marks all pending atomicupdates as applied, but does not execute the database changes in them. This is required for fresh installations to avoid applying same updates after the installation. Binds this feature to web installer. To test: 1. prove t/db_dependent/Koha/AtomicUpdater.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14399] Fix inventory.pl part two (following 12913)
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14399] Fix inventory.pl part two (following 12913)
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62099|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 62140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62140&action=ed… Bug 14399: Results form also needs a few interface changes Currently, the value of compareinv2barcd is used to determine if the Seen column, the Select/Clear all buttons and the Mark seen buttons are displayed. But if we scanned barcodes, we already marked items as seen. So we should only display these buttons when we did not upload barcodes. Test plan: [1] Upload a barcode file. Check that the result form does not show the buttons. [2] Generate an inventory list, so do not upload a barcode file. Verify that you still see the buttons. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14399] Fix inventory.pl part two (following 12913)
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62098|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 62139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62139&action=ed… Bug 14399: Interface changes A part of the confusion around the inventory script may arise from the fact that the form offers several options that are only used under certain conditions. This patch hopefully rearranges a few options more logically and only offers options when appropriate. The barcode fieldset now also contains Compare barcodes and Do not check in checkboxes. These are meaningful when a barcode file is uploaded. The fieldset Item location filters (new name) contains fields that are always used. Same for tne only control left under Additional options, Export to CSV. The fieldset Optional filters depends on the status of the barcode file and the Compare checkbox. It is now shown or hidden depending on what you select: if you do not upload a file, it is shown; or if you upload a file and check Compare, it is shown. Otherwise we hide it, since the script will not look at these values. Under this fieldset last inventory date and Skip items on loan are added, since their behavior is the same as the various item statuses. Test plan: In this test plan we test both the script changes from the previous patch and the interface changes here. We follow the three main scenario's as mentioned in the previous patch. [1] First we prepare a few test items. Pick two biblios A, B and create five items say A1,A2,B1,B2,B3. Pick a not-existing callnumber range you want to test and move these five items there. Add barcodes too (say A1..B3). Edit one item A1 to a not-existing notforloan status (doing this on the mysql command line is fastest). Like: update items set notforloan = '9' where barcode='A1'; Now simulate that we did not add/edit these items today: update items set datelastseen='2017-01-01' where barcode in ('A1','A2','B1','B2','B3'); Note: We need this when comparing with last inventory date in the last scenario. Scenario 1 (no barcodes uploaded) [2] Enter the callnumber range on inventory form. Verify that "Set inventory date", Compare barcodes and "Do not check in" are disabled on the form. Check that you see the Optional filters box. Submit the form. Verify that you see all five items. Do the same. Check Export to CSV. Check result file contents. Scenario 2 (upload barcodes, do not compare) [3] Create a barcode file with the barcodes of A1, A2 and B1. Add another existing barcode outside the test callnumber range. After uploading this file, verify that "Set inventory date", Compare and "Do not check in" are enabled. The Optional filters should be hidden. Leave "Set inventory date" to today. Enter the callnumber range again. Submit the form. What do we expect? Four items should have been updated (alert). We should see barcode A1 with problem Unknown status. We should see also the barcode from the other range (Found in wrong place). Repeat this step with the same file. But now export to CSV. Verify that you see two barcodes with problems again in the csv file. Scenario 3 (upload barcodes, compare) [4] Create another barcode file with barcodes of B2 and one existing barcode outside the test callnumber range. After uploading this file, check the Compare checkbox. Verify now that the Optional filters box is displayed again. Leave "Set inventory date" to today. Enter the callnumber range again. Also set "Last inventory date" to today (important!). Submit the form. What do we expect now? Two items should be updated (see alert). We should see barcode B3 with problem Missing. We should also see the barcode from the other range (wrong place). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14399] Fix inventory.pl part two (following 12913)
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #15 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #14) > Will adjust the test plan a little bit still If you do not set datelastseen back to yesterday or earlier, you will not have B3 in the results of the last step because it was created today. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62080|0 |1 is obsolete| | --- Comment #25 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 62138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62138&action=ed… Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14399] Fix inventory.pl part two (following 12913)
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #14 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Will adjust the test plan a little bit still -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #24 from Lari Taskula <lari.taskula(a)jns.fi> --- Depends on Bug 18413 (otherwise Letters.t fails) -- You are receiving this mail because: You are watching all bug changes.

1 0