April 2017 - Koha-bugs - lists.koha-community.org

[Bug 12930] Web installer does not show login errors
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- (in response to Jonathan Druart in comment 8) I have implemented a single patch meeting the requests you asked in comment 8. The comment 2 test plan is still applicable. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12930] Web installer does not show login errors
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 --- Comment #9 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 62116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62116&action=ed… Bug 12930 - Implemented invalid_username_or_password template variable being handed to Auth.tt. Removed indentation changes and modification to return value of checkpw -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12930] Web installer does not show login errors
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61808|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12930] Web installer does not show login errors
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '17

13 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61807|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14932] serials/ serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial!
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '17

12 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8435] new permissions on subscriptions "superserials"
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '17

12 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14932 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 [Bug 14932] serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14932] serials/ serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial!
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '17

12 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Depends on| |8435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435 [Bug 8435] new permissions on subscriptions "superserials" -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14932] serials/ serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial!
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '17

12 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 --- Comment #4 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 62112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62112&action=ed… Bug 14932: Do not call can_edit_subscription with an empty value ref($sub) eq 'ARRAY' should always be true, what we want is to call can_edit_subscription if there is at least 1 serial for this subscription. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14932] serials/ serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial!
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '17

12 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61974|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 62111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62111&action=ed… Bug 14932 - serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! Currently we have subscriptions with 300+ serials received. It takes a lot of time to show serials-collection.pl (~20s). This is especially troublesome when receiving serials, since after receival we get redirected to that page. We no longer can receive daily serials in the allotted timeframe. This quick and dirty fix prevents checking the subscription editing for each serial, but instead checks it for the first serial only. This reduced page load time by ~18s TEST PLAN: 1. Receive ~300 serials (or just a bunch :) ) 2. Observe the gradual slowing of the receival action. AFTER THIS PATCH: 1. Receive ~300 serials more (or just a bunch) 2. Observe a significant performance improvement. Signed-off-by: Paul POULAIN <paul.poulain(a)biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14932] serials/ serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial!
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '17

12 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0