April 2017 - Koha-bugs - lists.koha-community.org

[Bug 10382] collection not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '17

12 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #24 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- This <UNCHANGED> stuff smells like a very bad codding pattern. Could not we use empty string and undef/NULL to handle empty values? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7170] Remove use of XML::Simple
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '17

12 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13990] ILS-DI LookupPatron Requries ID Type
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '17

12 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14399] Fix inventory.pl part two (following 12913)
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '17

12 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14399] Fix inventory.pl part two (following 12913)
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '17

12 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Summary|"missingitem" code from |Fix inventory.pl part two |inventory.pl doesn't work |(following 12913) |properly | --- Comment #13 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- This is not a complete refactoring. I tried to resolve a lot of smaller issues within the current code. Rearranged the interface a bit too. The test plan of the third patch is the crux. It may look impressive, but you should be able to finish it in say 10-15 minutes (or faster). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14399] "missingitem" code from inventory.pl doesn't work properly
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '17

12 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #12 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 62099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62099&action=ed… Bug 14399: Results form also needs a few interface changes Currently, the value of compareinv2barcd is used to determine if the Seen column, the Select/Clear all buttons and the Mark seen buttons are displayed. But if we scanned barcodes, we already marked items as seen. So we should only display these buttons when we did not upload barcodes. Test plan: [1] Upload a barcode file. Check that the result form does not show the buttons. [2] Generate an inventory list, so do not upload a barcode file. Verify that you still see the buttons. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14399] "missingitem" code from inventory.pl doesn't work properly
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '17

12 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #11 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 62098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62098&action=ed… Bug 14399: Interface changes A part of the confusion around the inventory script may arise from the fact that the form offers several options that are only used under certain conditions. This patch hopefully rearranges a few options more logically and only offers options when appropriate. The barcode fieldset now also contains Compare barcodes and Do not check in checkboxes. These are meaningful when a barcode file is uploaded. The fieldset Item location filters (new name) contains fields that are always used. Same for tne only control left under Additional options, Export to CSV. The fieldset Optional filters depends on the status of the barcode file and the Compare checkbox. It is now shown or hidden depending on what you select: if you do not upload a file, it is shown; or if you upload a file and check Compare, it is shown. Otherwise we hide it, since the script will not look at these values. Under this fieldset last inventory date and Skip items on loan are added, since their behavior is the same as the various item statuses. Test plan: In this test plan we test both the script changes from the previous patch and the interface changes here. We follow the three main scenario's as mentioned in the previous patch. [1] First we prepare a few test items. Pick two biblios A, B and create five items say A1,A2,B1,B2,B3. Pick a not-existing callnumber range you want to test and move these five items there. Add barcodes too (say A1..B3). Edit one item A1 to a not-existing notforloan status (doing this on the mysql command line is fastest). Like: update items set notforloan = '9' where barcode='A1'; Scenario 1 (no barcodes uploaded) [2] Enter the callnumber range on inventory form. Verify that "Set inventory date", Compare barcodes and "Do not check in" are disabled on the form. Check that you see the Optional filters box. Submit the form. Verify that you see all five items. Do the same. Check Export to CSV. Check result file contents. Scenario 2 (upload barcodes, do not compare) [3] Create a barcode file with the barcodes of A1, A2 and B1. Add another existing barcode outside the test callnumber range. After uploading this file, verify that "Set inventory date", Compare and "Do not check in" are enabled. The Optional filters should be hidden. Leave "Set inventory date" to today. Enter the callnumber range again. Submit the form. What do we expect? Four items should have been updated (alert). We should see barcode A1 with problem Unknown status. We should see also the barcode from the other range (Found in wrong place). Repeat this step with the same file. But now export to CSV. Verify that you see two barcodes with problems again in the csv file. Scenario 3 (upload barcodes, compare) [4] Create another barcode file with barcodes of B2 and one existing barcode outside the test callnumber range. After uploading this file, check the Compare checkbox. Verify now that the Optional filters box is displayed again. Leave "Set inventory date" to today. Enter the callnumber range again. Also set "Last inventory date" to today (important!). Submit the form. What do we expect now? Two items should be updated (see alert). We should see barcode B3 with problem Missing. We should also see the barcode from the other range (wrong place). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14399] "missingitem" code from inventory.pl doesn't work properly
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '17

12 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #10 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 62097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62097&action=ed… Bug 14399: Numerous small refinements to the inventory script This patch contains the following changes: [01] Label "Inventory date" reworded to "Last inventory date", adding a small explanation for its purpose. [02] Restructured the results: it was an array with items and possible error messages. Multiple messages duplicated individual items. Now the results are in a hash, pulling all error messages for one item together. At the end of the script they are copied to an array. (A helper sub additemtoresults is added in this regard.) We no longer use array @items_with_problems. [03] Both datepickers are no longer connected to the same class. This prevents changing the set date by filling the last inventory date. [04] Input markseen in the template and $markseen in the script are no longer needed. [05] The paragraph before the detail link in the results table in the Title column has been removed. Same for problems column. This makes vertical spacing consistent. [06] Problem status 'missingitem' is no longer used; the missing items are marked as 'not_scanned'. Two additional statuses are: no_barcode and checkedout. [07] Removed unused $itemtype, $totalrecords and $count. We use variable $moddatecount to report a count to the template. [08] The script updated scanned items twice. The first time with ModItem and the second time with ModDateLastSeen. The second call is removed. [09] If a book is checked in, we do no longer return an error message when the checkin is successful (ERR_ONLOAN_RET). The updated datelastseen is passed to the results. [10] $wrongplacelist is renamed to $rightplacelist. It is only built when we need it. (Same for inventorylist now.) [11] Datelastseen (last inventory date) is always used for building the inventory list. It allows you to process partial barcode lists or make a list of items not seen after some date. We do no longer use variable $paramdatelastseen. [12] The section where items.datelastseen was compared with the inventory date has been removed. Scanned items were already updated; to get items seen before some date, you can now use last inventory date without passing barcodes. The form can mainly be used for the following three cases: [1] Prepare an inventory list or csv file; we do not upload barcodes. [2] Update items for uploaded barcodes without comparing to inventory. Last inventory date is useless in this case. Errors wrongplace, checkedout and changestatus are reported. Use this scenario for partial scanned barcode lists (all but last). [3] Update items for uploaded barcodes and compare to inventory, filtered by an optional last inventory date. Apart from the errors mentioned under [2], this also reports not_scanned ("missing") and no_barcode. Use this scenario too for the last partial barcode file (together with inventory date). Test plan: See next patch ("Interface changes"). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14399] "missingitem" code from inventory.pl doesn't work properly
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '17

12 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #9 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 62096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62096&action=ed… Bug 14399: Prevent display of double zero notforloan status On bug 12913 a zero status is added on the inventory form. This prevents a lot of false warnings for a wrong notforloan status. The zero status is not included in the default setup. But if you would add one, the status will display here twice now. This patch checks if the status already exists. Test plan: [1] Add a zero NOTFORLOAN status if it does not yet exist in Authorized values. [2] Check that you do not see two "For loan" statuses on inventory form. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 12 Apr '17

12 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #23 from Lari Taskula <lari.taskula(a)jns.fi> --- (In reply to Frédéric Demians from comment #21) > Get this: > > fatal: sha1 information is lacking or useless (C4/Letters.pm). > error: could not build fake ancestor I removed some dependencies and rebased this on master. Should now apply. -- You are receiving this mail because: You are watching all bug changes.

1 0