April 2017 - Koha-bugs - lists.koha-community.org

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61893|0 |1 is obsolete| | --- Comment #89 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 61915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61915&action=ed… Bug 9988: Add Koha objects for table need_merge_authorities This patch adds two Koha objects: MergeRequest(s). MergeRequest has a new method and an oldmarc method. A class method reporting_tag_xml is added to MergeRequests.pm. All new routines are tested in Authorities.t. Removes a few unneeded modules from Koha::Authority. Test plan: Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61892|0 |1 is obsolete| | --- Comment #88 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 61914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61914&action=ed… Bug 9988: DBIx schema changes for need_merge_authorities As generated by misc/devel/update_dbix_class_files.pl. No test plan. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61891|0 |1 is obsolete| | --- Comment #87 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 61913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61913&action=ed… Bug 9988: Table revision for need_merge_authorities In order to let merge do exactly the same when called from the merge cron job, we need three additional fields in the table. The use of these fields will be explained in a follow-up. Test plan: Run the dbrev (updatestructure step in webinstaller). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Also tested running kohastructure.sql for this table. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61890|0 |1 is obsolete| | --- Comment #86 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 61912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61912&action=ed… Bug 9988: Database revision for AuthorityMergeLimit Introduce the new preference and remove dontmerge. If dontmerge was enabled, the new pref will be set to zero and we will print a message about raising this value now. Test plan: Run the database revision or a new install. In case of an upgrade, check the new pref value. Should be 0 when dontmerge was enabled, otherwise 50. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Also tested sysprefs.sql on a new database. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #85 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marc Véron from comment #70) > Went through test plans from comment #68 and comment #69, works as described. Great, Marc ! Thanks. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61792|0 |1 is obsolete| | --- Comment #84 from Marc Véron <veron(a)veron.ch> --- Created attachment 61904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61904&action=ed… Bug 9988: Add the cronjob and print an upgrade message The Debian cron file and the misc crontab example are updated. A message is printed when upgrading. Note: At this moment the merge cron job is run once a day. This is imo a good starting point. The load for this job greatly depends on the value of pref AuthorityMergeLimit. Of course you can schedule the job more often, and if this need is felt more globally, we can adjust it later. Test plan: [1] Run the dbrev and see the message. [2] Read the changes to the cron files. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61791|0 |1 is obsolete| | --- Comment #83 from Marc Véron <veron(a)veron.ch> --- Created attachment 61903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61903&action=ed… Bug 9988: Refactor the cron script The cron job is moved from migration tools to cronjobs. And renamed to a plural form. The script is now based on Koha objects. It does no longer include the code to merge one record. This can be done via the interface, and will be added to a maintenance script on bug 18071. Should not be part of this cron job. Adding a cron_cleanup method to MergeRequests; this method is called from the cron script to reset older entries still marked in progress and to also remove old processed entries. Tested in a separate unit test. Test plan: [1] Run t/db_dependent/Authorities/MergeRequests.t [2] Set AuthorityMergeLimit to 0. (All merges are postponed.) [3] Modify an authority linked to a few records. [4] Delete an authority linked to a few records with batch delete tool. [5] And select two auth records with linked records. Merge these two records with authority/merge.pl. Note: Do not select Default. See also bug 17380. [6] Check the need_merge_authorities table for inserted records. [7] Run misc/cronjobs/merge_authorities.pl -b and inspect the linked records and the record status in need_merge_authorities. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7419] Add authority deduplication script
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Marjorie Barry-Vila <marjorie.barry-vila(a)ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila(a)ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61790|0 |1 is obsolete| | --- Comment #82 from Marc Véron <veron(a)veron.ch> --- Created attachment 61902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61902&action=ed… Bug 9988: Few subtle changes for postponed merge The fails in the previous test showed that we need the first three changes here. Some final polishing in points 4 to 6. [1] Sub merge: Refine the condition for initializing $tags_new. A postponed 'modify'-merge (A to B) makes that $authtypefrom is not defined when running merge later. When crossing the type boundary, we need a new field too. [2] Sub merge: Add condition for an empty @record_to array. This indicates also that a field should be removed, since we should otherwise only add a $9 subfield. [3] Sub merge: Adjust initializing @record_from. This change is tested by verifying a cleared subfield in the test. [4] DelAuthority: Adding a skipmerge parameter to allow the call from authorities/merge.pl to skip an unneeded merge. This also prevents that the 'delete-merge' would precede the 'modify-merge' under a hypothetical race condition. [5] DelAuthority: There is actually no need to call GetAuthority. The subfields of the old record are not relevant in this case. [6] Added a few POD lines to merge. [7] Removed a trailing space in a comment line in merge. Test plan: [1] Run t/db_dependent/Authorities/Merge.t. The last subtest should no longer fail now. [2] See test plan of next patch. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0