April 2017 - Koha-bugs - lists.koha-community.org

[Bug 12802] Sent notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45481|0 |1 is obsolete| | --- Comment #60 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 61883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61883&action=ed… Bug 12802: Fix tests in Letters.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Sent notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45480|0 |1 is obsolete| | --- Comment #59 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 61882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61882&action=ed… Bug 12802: Fix QA script issues FAIL C4/Reserves.pm FAIL pod Spurious =cut command in file C4/Reserves.pm Signed-off-by: Brendan Gallagher <brendan(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Sent notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45479|0 |1 is obsolete| | --- Comment #58 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 61881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61881&action=ed… Bug 12802: Fix if AutoEmailOpacUser is enabled Test plan: Verify that the behavior of AutoEmailOpacUser still works as before. Note that now the email can receive several emails if AutoEmailPrimaryAddress has several values. Signed-off-by: Brendan Gallagher <brendan(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Sent notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45478|0 |1 is obsolete| | --- Comment #57 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 61880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61880&action=ed… Bug 12802: FIX use the first valid email address if noemail is needed Signed-off-by: Brendan Gallagher <brendan(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Sent notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57296|0 |1 is obsolete| | --- Comment #56 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 61879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61879&action=ed… Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. The _update_message_to_address becomes useless since the to_address is retrieved previously. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. Signed-off-by: Brendan Gallagher <brendan(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Sent notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45476|0 |1 is obsolete| | --- Comment #55 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 61878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61878&action=ed… Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress Signed-off-by: Brendan Gallagher <brendan(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Allow correct handling of plural translation
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #21 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Marc Véron from comment #16) > Patch does no longer apply. > > How would disambiguation work? > > e.g. for the 3 meanings of "Title" mentioned in > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285#c25 To attach context to a string, you have to use one of the 'p' variants (__p, __px, __np, __npx). This context will appear in the PO file to help the translator and gettext will use this information to choose the right translation https://www.gnu.org/software/gettext/manual/html_node/Contexts.html Eg. __p('Patron', 'Title') __p('Bibliographic record', 'Title') -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Allow correct handling of plural translation
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50026|0 |1 is obsolete| | --- Comment #20 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 61876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61876&action=ed… Bug 15395: Add plural translation capabilities to JS files It adds Javascript equivalent of Koha::I18N's exported subroutines, and they are used the same way. String extraction is done only on *.js files and require gettext 0.19 (available in Debian stable, and also in wheezy-backports) It adds Javascript library Gettext.js for handling translation and a Perl script po2json to transform PO file into JSON. Gettext.js and po2json both come from Locale::Simple. There are several tools named po2json. It's simpler to integrate this one into Koha than to check if the good one is installed on the system. Locale::Simple is not needed. To avoid polluting the global namespace too much, this patch also introduce a global JS object named Koha and add some stuff in Koha.i18n Test plan: 1. Add a translatable string in a JS file. For example, add this: alert(__nx("There is one item", "There are {count} items", 3, {count: 3})); to staff-global.js 2. cd misc/translator && ./translate update fr-FR 3. Open misc/translator/po/fr_FR/LC_MESSAGES/Koha.po, verify that your string is present, and translate it 4. cd misc/translator && ./translate install fr-FR 5. (Optional) Verify that koha-tmpl/intranet-tmpl/prog/fr-FR/js/locale_data.js exists and contains your translation 6. Open your browser on the staff main page, change language and verify that the message is translated 7. Repeat 1-6 on OPAC side -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Allow correct handling of plural translation
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50025|0 |1 is obsolete| | --- Comment #19 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 61875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61875&action=ed… Bug 15395: Example usage of I18N Template::Toolkit plugin -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Allow correct handling of plural translation
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50024|0 |1 is obsolete| | --- Comment #18 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 61874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61874&action=ed… Bug 15395: Plural translations in templates Provides a way to handle translation of plural forms in templates Add Template::Toolkit plugin for Koha::I18N Use like this: [%# USE the plugin and define some macros %] [% PROCESS 'i18n.inc' %] [%# tn is the equivalent of __n %] [%# macro names can't start with underscore, t is for "translate" %] [% tn('item', 'items', num_items) %] Extraction of strings from templates is a bit complicated and use Template::Parser and PPI. Template is compiled into Perl code and then analyzed by PPI. It is slow, but should be correct even with complex constructions. Add dependency to PPI Test plan: 1. Open a template file (.tt or .inc) with your favorite text editor 2. Add the PROCESS directive mentioned above in the beginning of file 3. Use one of the t* macros defined in i18n.inc. They are used like their "__" equivalent, with one difference: the 'x' variants take a hashref instead of a hash as last parameter 4. cd misc/translator && ./translate update fr-FR 5. Open misc/translator/po/fr_FR/LC_MESSAGES/Koha.po and translate your string(s) 6. ./translate install fr-FR 7. Use your web browser to go to the page that should display the translation, change language and verify the translation is correct -- You are receiving this mail because: You are watching all bug changes.

1 0