April 2017 - Koha-bugs - lists.koha-community.org

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59799|0 |1 is obsolete| | --- Comment #83 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 61849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61849&action=ed… Bug 14224: Reintroduce previous copyright Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59798|0 |1 is obsolete| | --- Comment #82 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 61848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61848&action=ed… Bug 14224: Do not reintroduce GetItemIssue, it's dying Bug 17680 is removing it. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '17

05 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59779|0 |1 is obsolete| | --- Comment #81 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 61847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61847&action=ed… Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Update database 3) Rebuild schema 4) Turn on 'AllowIssueNote' syspref 5) Check out three different items to a borrower (may be easiest to check out to yourself) 6) Log in as that borrower (or yourself) on the OPAC side and go to your summary 7) Confirm text field shows under Note column for all checkouts. Set a note for each issue, confirm all save. 8) Check the message_queue in mysql for the entries for ALL THREE issue notes. 9) Disable javascript in your browser 10) Refresh your summary page. Confirm that you can no longer edit the notes in the text field. Click the 'Create/edit note' button and confirm you are redirected to a new page. 11) Confirm that the correct title and author show for the note button you clicked. 12) Set the note and click Submit -> confirm you are redirected back to summary page and note is saved 13) Confirm there is a new entry in message_queue 14) Enable javascript and go back to the your checkouts page in the staff client for the borrower you issued the items to 15) Check in TWO items 16) Confirm that the issue notes show under the "Date due" column for the two items you checked in, and are accurate to the item (i.e. the right issue note under the right item) 17) Go to circ/returns.pl and check in the final item using the barcode. Confirm the issue note shows and the date is formatted correctly. Sponsored-by: Region Halland Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18219] New: "Not checked out." problem message displays twice on local use.
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '17

04 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Bug ID: 18219 Summary: "Not checked out." problem message displays twice on local use. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When checking in an item that is not checked out, the problem message "Not checked out appears twice. This seems to have occured with the last update to the master. I did not see this before my master was updated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 26

[Bug 14620] Contact information validations
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '17

04 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 George Williams (NEKLS) <george(a)nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams(a)nekls.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14620] Contact information validations
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '17

04 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 George Williams (NEKLS) <george(a)nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george(a)nekls.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14620] Contact information validations
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '17

04 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 --- Comment #20 from Lari Taskula <lari.taskula(a)jns.fi> --- Rebased on top of master, created unit tests for Koha::Validation, removed dependency to Bug 7174. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7174] Authentication rewriting
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '17

04 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14620 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 [Bug 14620] Contact information validations -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14620] Contact information validations
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '17

04 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7174 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 [Bug 7174] Authentication rewriting -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14620] Contact information validations
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '17

04 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44705|0 |1 is obsolete| | --- Comment #19 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 61843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61843&action=ed… Bug 14620: Contact information validations This patch adds a phone number validation by regex and centralizes different validation methods into Koha::Validation class. Introduces a new system preference, ValidatePhoneNumber, that takes a regular expression and uses it to validate phone numbers both client and server side. Unit tests to test: 1. prove t/db_dependent/Koha/Validation.t To test: 1. Apply the patches and run updatedatabase.pl to install the new system preference 2. Set system preference ValidatePhoneNumber to any regex you like (there is an example in the description of the preference) 3. Navigate to edit user contact informations in Staff client and OPAC. 4. Insert invalid email (e.g. "invalid") and invalid phone number ("+123invalid") and send the form. 5. Confirm that form will not be submitted and errors will be given. 6. Disable JavaScript and test that these errors will also be provided by the server. -- You are receiving this mail because: You are watching all bug changes.

1 0