April 2017 - Koha-bugs - lists.koha-community.org

[Bug 18275] opac-memberentry.pl security vulnerabilities
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '17

03 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18275 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj(a)kohaaloha.com --- Comment #20 from Mason James <mtj(a)kohaaloha.com> --- Pushed to 16.05.x, for 16.05.11 release -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15441] columns_settings.pl: Circulation issues-table - cannot toggle checkin column
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '17

03 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15441 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 17346 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 8010] Search history can be added to the wrong patron
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '17

03 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 --- Comment #25 from Baptiste <baptiste.wojtkowski(a)biblibre.com> --- Hi ! - "This contains strings, so will have to wait to be considered next month." I don't quite understand what you mean.. - "I am not sure about the pref description Maybe we could rephrase that a bit to make it clearer?" What do you think about: "When a user log in [load/don't load] on his own history all searches performed while no user were logged in" - "We'd also want to make it INSERT IGNORE if we want this in 16.11.x in master." You mean in "bug_8010-add_LoadSearchHistoryToTheFirstLoggedUser_syspref.sql" ? - "The sypsref name got a bit long :) Why Load and not Add?" Will one character change anything ? I couldn't find shorter and still.. hum.. let's say explicit. Any idea ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '17

03 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Oleg Vasilenko <synapse.ova(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18371 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18371 [Bug 18371] XSLT transformation fails if UNIMARC 100$a is hidden -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11514] Untranslatable "Uncertain" text in acq
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '17

03 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- acqui/basket.pl: $line{rrp_tax_excluded} .= ' (Uncertain)'; acqui/invoice.pl: $line{rrp} .= ' (Uncertain)'; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14399] "missingitem" code from inventory.pl doesn't work properly
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '17

03 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #2) > I tried to imagine why this was introduced; perhaps it was meant as a > compare with the last inventory date. But since all scanned items are > already updated, this compare does not work. > > I will remove this section on bug 12913. But this section could still be handy when we allow the use of datelastseen without the barcode file.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14399] "missingitem" code from inventory.pl doesn't work properly
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '17

03 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61685|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '17

03 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61309|0 |1 is obsolete| | --- Comment #69 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61792&action=ed… Bug 9988: Add the cronjob and print an upgrade message The Debian cron file and the misc crontab example are updated. A message is printed when upgrading. Note: At this moment the merge cron job is run once a day. This is imo a good starting point. The load for this job greatly depends on the value of pref AuthorityMergeLimit. Of course you can schedule the job more often, and if this need is felt more globally, we can adjust it later. Test plan: [1] Run the dbrev and see the message. [2] Read the changes to the cron files. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '17

03 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61308|0 |1 is obsolete| | --- Comment #68 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61791&action=ed… Bug 9988: Refactor the cron script The cron job is moved from migration tools to cronjobs. And renamed to a plural form. The script is now based on Koha objects. It does no longer include the code to merge one record. This can be done via the interface, and will be added to a maintenance script on bug 18071. Should not be part of this cron job. Adding a cron_cleanup method to MergeRequests; this method is called from the cron script to reset older entries still marked in progress and to also remove old processed entries. Tested in a separate unit test. Test plan: [1] Run t/db_dependent/Authorities/MergeRequests.t [2] Set AuthorityMergeLimit to 0. (All merges are postponed.) [3] Modify an authority linked to a few records. [4] Delete an authority linked to a few records with batch delete tool. [5] And select two auth records with linked records. Merge these two records with authority/merge.pl. Note: Do not select Default. See also bug 17380. [6] Check the need_merge_authorities table for inserted records. [7] Run misc/cronjobs/merge_authorities.pl -b and inspect the linked records and the record status in need_merge_authorities. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '17

03 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61307|0 |1 is obsolete| | --- Comment #67 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61790&action=ed… Bug 9988: Few subtle changes for postponed merge The fails in the previous test showed that we need the first three changes here. Some final polishing in points 4 to 6. [1] Sub merge: Refine the condition for initializing $tags_new. A postponed 'modify'-merge (A to B) makes that $authtypefrom is not defined when running merge later. When crossing the type boundary, we need a new field too. [2] Sub merge: Add condition for an empty @record_to array. This indicates also that a field should be removed, since we should otherwise only add a $9 subfield. [3] Sub merge: Adjust initializing @record_from. This change is tested by verifying a cleared subfield in the test. [4] DelAuthority: Adding a skipmerge parameter to allow the call from authorities/merge.pl to skip an unneeded merge. This also prevents that the 'delete-merge' would precede the 'modify-merge' under a hypothetical race condition. [5] DelAuthority: There is actually no need to call GetAuthority. The subfields of the old record are not relevant in this case. [6] Added a few POD lines to merge. [7] Removed a trailing space in a comment line in merge. Test plan: [1] Run t/db_dependent/Authorities/Merge.t. The last subtest should no longer fail now. [2] See test plan of next patch. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0