May 2017 - Koha-bugs - lists.koha-community.org

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 26 May '17

26 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63751|0 |1 is obsolete| | --- Comment #62 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 63751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63751 Bug 1985: perlcritic Obsoleting because beyond enhancement scope, so as to not distract people who might sign off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 26 May '17

26 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63750|0 |1 is obsolete| | --- Comment #61 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 63750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63750 Bug 1985: perltidy opac/opac-review.pl Obsoleting because beyond enhancement scope, so as to not distract people who might sign off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 26 May '17

26 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63749|0 |1 is obsolete| | --- Comment #60 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 63749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63749 Bug 1985: perlcritic Obsoleting because beyond enhancement scope, so as to not distract people who might sign off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 26 May '17

26 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #59 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Jonathan Druart from comment #58) > We are not following perlcritic -1, this patch is out of the scope of this > bug report. While you are correct about scope creep for the last 4 patches, I do believe the first 3 are fine and should not creep it as far as I recall. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 26 May '17

26 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #58 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to M. Tompsett from comment #57) > (In reply to M. Tompsett from comment #56) > > If you apply everything and run the test plans in comment #50 and comment > > #51, then it should suffice. > > Generally running perlcritic -1 {file}, and ignoring some things, with the > default perlcritic. This puts the code at a higher perlcritic level than > just -5 as used by the koha qa test tools. We are not following perlcritic -1, this patch is out of the scope of this bug report. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 26 May '17

26 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #57 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to M. Tompsett from comment #56) > If you apply everything and run the test plans in comment #50 and comment > #51, then it should suffice. Generally running perlcritic -1 {file}, and ignoring some things, with the default perlcritic. This puts the code at a higher perlcritic level than just -5 as used by the koha qa test tools. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 26 May '17

26 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #56 from M. Tompsett <mtompset(a)hotmail.com> --- If you apply everything and run the test plans in comment #50 and comment #51, then it should suffice. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 26 May '17

26 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #55 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 63752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63752&action=ed… Bug 1985: perltidy Koha/Review.pm -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 26 May '17

26 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #54 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 63751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63751&action=ed… Bug 1985: perlcritic -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 26 May '17

26 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #53 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 63750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63750&action=ed… Bug 1985: perltidy opac/opac-review.pl -- You are receiving this mail because: You are watching all bug changes.

1 0