May 2017 - Koha-bugs - lists.koha-community.org

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 25 May '17

25 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #76 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Ok, trying to get this tested :) First: QA tools: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/report_files.tt FAIL git manipulation The file has been added and deleted in the same patchset FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt FAIL forbidden patterns forbidden pattern: tab char (line 55) forbidden pattern: tab char (line 68) forbidden pattern: tab char (line 63) forbidden pattern: tab char (line 61) forbidden pattern: tab char (line 64) forbidden pattern: tab char (line 58) forbidden pattern: tab char (line 65) forbidden pattern: tab char (line 73) forbidden pattern: tab char (line 59) forbidden pattern: tab char (line 57) forbidden pattern: tab char (line 60) FAIL reports/report_files.pl FAIL git manipulation The file has been added and deleted in the same patchset Easy to fix - as we got no sign-off yet, we'd just need to fix the tabs and squash the patches. Second: Some code review 1) I think as the permission is under Tools and the files live there too, it should also be shown as a tool on the tools page instead of under reports. I'd put it under "Additional tools", maybe under the log viewer. <li><a href="/cgi-bin/koha/reports/report_files.pl">Report/log files</a></li> 2) When I click on the link under Reports, I get a 'not found' error. What am I missing? 3) Looking at the history of this bug, are we missing 2 patches? Bug 11317 - Allow sorting on date column in file access tool. (1.29 KB, patch) Bug 11317 - Remove datatables-strings.inc from .tt (959 bytes, patch) 4) +use strict; +use warnings; Shoudl be: use Modern::Perl; Sorry, can't test further because of 2)! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9031] Overdue items crossing DST boundary throw invalid local time exception
by bugzilla-daemon＠bugs.koha-community.org 25 May '17

25 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61089|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 63718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63718&action=ed… [SIGNED OFF] Bug 9031 - Overdue items crossing DST boundary throw invalid local time exception To test: 1 - Set TZ to America/New York 2 - Checkout item and set due date to '2016-03-09 02:29:00" 3 - Make sure fines are set for the item type, fine mode production, calculate fines on return 4 - Check in item - invalid date time warning in logs 5 - Apply patch 6 - Check in item - no error 7 - prove t/Calendar.t Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9031] Overdue items crossing DST boundary throw invalid local time exception
by bugzilla-daemon＠bugs.koha-community.org 25 May '17

25 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9031] Overdue items crossing DST boundary throw invalid local time exception
by bugzilla-daemon＠bugs.koha-community.org 25 May '17

25 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18671 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function
by bugzilla-daemon＠bugs.koha-community.org 25 May '17

25 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 --- Comment #7 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Katrin Fischer from comment #6) > Fixed typo basetgroupname Thanks. How embarrassing. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function
by bugzilla-daemon＠bugs.koha-community.org 25 May '17

25 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63681|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 63717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63717&action=ed… [SIGNED OFF] Bug 5395: Update C4::Acquisition::SearchOrders POD Comparing the perldoc to the function: - basketname - basketgroupname - budget_id Were missing. This adds them. Also, a description of ordernumber and search were added, as they are not self-evident by their name alone. There are no code changes, so all tests should pass or fail identically before and after patch. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Fixed typo basetgroupname -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function
by bugzilla-daemon＠bugs.koha-community.org 25 May '17

25 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 15343] Allow patrons to choose their own password on self registration.
by bugzilla-daemon＠bugs.koha-community.org 25 May '17

25 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Emma Perks <emma.perks(a)heartofengland.nhs.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emma.perks(a)heartofengland.n | |hs.uk -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11813] Send 'Opac self registration verification' email from branch address if possible
by bugzilla-daemon＠bugs.koha-community.org 25 May '17

25 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11813 Emma Perks <emma.perks(a)heartofengland.nhs.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emma.perks(a)heartofengland.n | |hs.uk -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13901] sort1 and sort2 not on self registration form
by bugzilla-daemon＠bugs.koha-community.org 25 May '17

25 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13901 Emma Perks <emma.perks(a)heartofengland.nhs.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emma.perks(a)heartofengland.n | |hs.uk -- You are receiving this mail because: You are watching all bug changes.

1 0