May 2017 - Koha-bugs - lists.koha-community.org

[Bug 2454] Don't show credits on Pay Fines Tab
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 --- Comment #10 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 62991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62991&action=ed… Bug 2454 - Amended patch: Removed the display of accountype, Notify ID, Level values for manual credit in pay.tt and replaced the description with string "Credit" Reimplemented accounttype column but kept the notifyid a nd level columns These specific values have been removed because this bug report requires the manual credit to no longer be shown on the 'Pay fines' tab. In response to comment 4 (thankyou for noticing that Felix) I have redone this patch so users can now successfully pay or write off manual credits because the manual credit values although not being displayed are still being submitted to pay.pl. Test plan: 1. From the Koha staff interface go the Patron area and select a patron page 2. Create a fine of $10 for the patron by clicking on the 'Fines' tab and creating a fine in the 'Create manual invoice' tab 3. Create a credit of $5 for the patron in the 'Create manual credit' page 4. Then go to the 'Pay fines' tab and notice there is a row for both the fine and credit both with values in the account type, Notify ID, and level boxes of the table 5. Select "write off all" and 'OK' in the confirmation box 6. Youre redirected to Account tab, return to 'pay fines' tab and notice no fines or credits are displayed 7. Repeat steps 2, 3, 4 and then click "Pay amount", confirm it, then navigate back to the 'Pay fines' tab and notice although the fine and credit are displayed the 'total due' value is 0.00 8. Apply the patch attached to this bug report 9. Repeat steps 2, and 3. 10. Navigate to 'Pay fines' tab and notice the fine has values in account type, Notify ID, and level and the credit does not. Additionally credit has the description value of 'Credit' 11. Repeat steps 5 and 6 and as with before this patch was applied notice the 'Pay fines' tab does not show any fines or credits 12. Repeat step 7 and again notice the 'Total due' value is 0.00 Bug 2454 - Reimplemented accounttype column but kept the notifyid and level columns -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 2454] Don't show credits on Pay Fines Tab
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62953|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 15408] Timestamp on funds not updated when you duplicate a budget
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60339|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15408] Timestamp on funds not updated when you duplicate a budget
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60338|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15408] Timestamp on funds not updated when you duplicate a budget
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60337|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15408] Timestamp on funds not updated when you duplicate a budget
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15408] Timestamp on funds not updated when you duplicate a budget
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 --- Comment #14 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 62987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62987&action=ed… [SIGNED OFF] Modified to run properly the QA tests https://bugs.koha-community.org/show_bug.cgi?id=15408 Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15408] Timestamp on funds not updated when you duplicate a budget
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 62986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62986&action=ed… [SIGNED OFF] Added unit tests to patch https://bugs.koha-community.org/show_bug.cgi?id=15408 Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15408] Timestamp on funds not updated when you duplicate a budget
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 62985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62985&action=ed… [SIGNED OFF] Bug 15408 : deleted the timestamp so that the database gives a new one To duplicate the budget, the function CloneBudgetHierarchy create a new budget from the old without the parameter timestamp, so that the database generates a new one. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15408] Timestamp on funds not updated when you duplicate a budget
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Summary|Timestamp not updated when |Timestamp on funds not |you duplicate a budget |updated when you duplicate | |a budget -- You are receiving this mail because: You are watching all bug changes.

1 0