May 2017 - Koha-bugs - lists.koha-community.org

[Bug 2454] Improve display of credits on pay fines tab
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Don't show credits on Pay |Improve display of credits |Fines Tab |on pay fines tab -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 2454] Don't show credits on Pay Fines Tab
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62991|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 62994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62994&action=ed… [SIGNED OFF] Bug 2454 - Amended patch: Removed the display of accountype, Notify ID, Level values for manual credit in pay.tt and replaced the description with string "Credit" Reimplemented accounttype column but kept the notifyid a nd level columns These specific values have been removed because this bug report requires the manual credit to no longer be shown on the 'Pay fines' tab. In response to comment 4 (thankyou for noticing that Felix) I have redone this patch so users can now successfully pay or write off manual credits because the manual credit values although not being displayed are still being submitted to pay.pl. Test plan: 1. From the Koha staff interface go the Patron area and select a patron page 2. Create a fine of $10 for the patron by clicking on the 'Fines' tab and creating a fine in the 'Create manual invoice' tab 3. Create a credit of $5 for the patron in the 'Create manual credit' page 4. Then go to the 'Pay fines' tab and notice there is a row for both the fine and credit both with values in the account type, Notify ID, and level boxes of the table 5. Select "write off all" and 'OK' in the confirmation box 6. Youre redirected to Account tab, return to 'pay fines' tab and notice no fines or credits are displayed 7. Repeat steps 2, 3, 4 and then click "Pay amount", confirm it, then navigate back to the 'Pay fines' tab and notice although the fine and credit are displayed the 'total due' value is 0.00 8. Apply the patch attached to this bug report 9. Repeat steps 2, and 3. 10. Navigate to 'Pay fines' tab and notice the fine has values in account type, Notify ID, and level and the credit does not. Additionally credit has the description value of 'Credit' 11. Repeat steps 5 and 6 and as with before this patch was applied notice the 'Pay fines' tab does not show any fines or credits 12. Repeat step 7 and again notice the 'Total due' value is 0.00 Bug 2454 - Reimplemented accounttype column but kept the notifyid and level columns Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 2454] Don't show credits on Pay Fines Tab
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59961|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 62993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62993&action=ed… [SIGNED OFF] Bug 12691: Use Koha.Preference in Self-Checkout For calls to SCOUserJS, SCOUserCSS, OPACUserCSS, AllowSelfCheckReturns, OpacFavicon, ShowPatronImageInWebBasedSelfCheck, SelfCheckoutByLogin Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> https://bugs.koha-community.org/show_bug.cgi?id=12601 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12601] aqorders.budget_id should be a foreign key
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12601 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62992|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 62992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62992 [SIGNED OFF] Bug 12691: Use Koha.Preference in Self-Checkout wrong bug number! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12601] aqorders.budget_id should be a foreign key
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12601 --- Comment #16 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 62992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62992&action=ed… [SIGNED OFF] Bug 12691: Use Koha.Preference in Self-Checkout For calls to SCOUserJS, SCOUserCSS, OPACUserCSS, AllowSelfCheckReturns, OpacFavicon, ShowPatronImageInWebBasedSelfCheck, SelfCheckoutByLogin Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2454] Don't show credits on Pay Fines Tab
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61765|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 2454] Don't show credits on Pay Fines Tab
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 --- Comment #10 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 62991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62991&action=ed… Bug 2454 - Amended patch: Removed the display of accountype, Notify ID, Level values for manual credit in pay.tt and replaced the description with string "Credit" Reimplemented accounttype column but kept the notifyid a nd level columns These specific values have been removed because this bug report requires the manual credit to no longer be shown on the 'Pay fines' tab. In response to comment 4 (thankyou for noticing that Felix) I have redone this patch so users can now successfully pay or write off manual credits because the manual credit values although not being displayed are still being submitted to pay.pl. Test plan: 1. From the Koha staff interface go the Patron area and select a patron page 2. Create a fine of $10 for the patron by clicking on the 'Fines' tab and creating a fine in the 'Create manual invoice' tab 3. Create a credit of $5 for the patron in the 'Create manual credit' page 4. Then go to the 'Pay fines' tab and notice there is a row for both the fine and credit both with values in the account type, Notify ID, and level boxes of the table 5. Select "write off all" and 'OK' in the confirmation box 6. Youre redirected to Account tab, return to 'pay fines' tab and notice no fines or credits are displayed 7. Repeat steps 2, 3, 4 and then click "Pay amount", confirm it, then navigate back to the 'Pay fines' tab and notice although the fine and credit are displayed the 'total due' value is 0.00 8. Apply the patch attached to this bug report 9. Repeat steps 2, and 3. 10. Navigate to 'Pay fines' tab and notice the fine has values in account type, Notify ID, and level and the credit does not. Additionally credit has the description value of 'Credit' 11. Repeat steps 5 and 6 and as with before this patch was applied notice the 'Pay fines' tab does not show any fines or credits 12. Repeat step 7 and again notice the 'Total due' value is 0.00 Bug 2454 - Reimplemented accounttype column but kept the notifyid and level columns -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 2454] Don't show credits on Pay Fines Tab
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62953|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0