May 2017 - Koha-bugs - lists.koha-community.org

[Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 --- Comment #40 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Nick Clemens from comment #39) > The feature works as expected but I think that we need feedback on opac and > staff pages to indicate whether the auto-renewal will succeed/fail Ah, nvm, implemented in bug 15705 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #39 from Nick Clemens <nick(a)bywatersolutions.com> --- The feature works as expected but I think that we need feedback on opac and staff pages to indicate whether the auto-renewal will succeed/fail -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7550] Self checkout: limit display of patron image to logged-in patron
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7550] Self checkout: limit display of patron image to logged-in patron
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62400|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7550] Self checkout: limit display of patron image to logged-in patron
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy(a)rijksmuseum.nl Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7550] Self checkout: limit display of patron image to logged-in patron
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 --- Comment #28 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 62913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62913&action=ed… Bug 7550: [QA Follow-up] Resolve param warning from sco-patron-image Resolve this warning: CGI::param called in list context from package C4::Service line 212, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. It comes from the require_params call in sco-patron-image.pl. Git grepping on require_params tells me this: members/default_messageprefs.pl:my ($categorycode) = C4::Service->require_params('categorycode'); opac/sco/sco-patron-image.pl:my ($borrowernumber) = C4::Service->require_params('borrowernumber'); opac/sco/sco-patron-image.pl:my ($csrf_token) = C4::Service->require_params('csrf_token'); svc/cataloguing/metasearch:my ( $query_string, $servers ) = C4::Service->require_params( 'q', 'servers' ); The only candidate for multi_param seems to be 'servers', but as we can see this variable is a scalar. Additional servers returned by require_params are lost. This should be solved on its own report. So, we can safely add scalar to the params call, resolve the warning and keep the same behavior. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7550] Self checkout: limit display of patron image to logged-in patron
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62441|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 62912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62912&action=ed… Bug 7550: SCO - Restrict access of patron's image With this patch if SelfCheckoutByLogin is set to 'username and password', only the logged in user will be able to see the image linked to his/her logged in account. If set to "barcode" we generate a token but it can be easily generated. You should add a warning in the about page if SelfCheckoutByLogin="barcode" and ShowPatronImageInWebBasedSelfCheck="Show". How I tested: - Go to SCO - Log - Enable self checkout, go to [Your Server]//cgi-bin/koha/sco/sco-main.pl - Log in with a user 'A' who has a patron image - Copy the address of the patron image into an other browser window - Change the borrowernumber to on of an other user 'B' having a patron image - Verify that the patron image is NOT displayed Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11375] Improve patrons permissions display
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I like it! Only thing maybe is that I like the top level permission clickable, as that seems a bit faster than the 'show details' link when you have to enter a lot of accounts as we usually do. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14399] Fix inventory.pl part two (following 12913)
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #24 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Josef Moravec from comment #23) > Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Thanks for testing, Josef. In the meantime we are using these changes in production on 3.22 already. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15140] Add MARC21 776 to OPAC and staff display
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 --- Comment #14 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Felix Hemme from comment #12) > Hi Marcel, > linking works fine now. But I think the value from subfield $i (relationship > information) should be displayed if second indicator = 8. Like in field 775 > (other edition entry). I changed the status to "Failed QA". Please change it > again if that was not correct. Thanks for testing, Felix. I have tried to implement your suggestion in the second patch. -- You are receiving this mail because: You are watching all bug changes.

1 0