June 2017 - Koha-bugs - lists.koha-community.org

[Bug 7960] choice to not show the text labels for item types
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #9 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Aleisha Amohia from comment #8) > (In reply to Marcel de Rooy from comment #7) > > Have the impression that we should not hide labels with a syspref but > > resolve this with custom css. Please convince me that I am wrong. > > The syspref just provides the functionality for the library to hide or show > the text, without having to play around with css or ask us to do it for > them. I don't think it's fair to assume that librarians know how to write > css. We have to find a balance between adding a syspref for showing/hiding elements and css customization. Yes, not each librarian writes css. I will not block this patch and change the status to Signed off again. Another QA opinion please. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #25 from Marc Véron <veron(a)veron.ch> --- 1) The syspref is populated with ,. The text says: "The separator used between integer and decimal part" Maybe it would be better to explain a little bit more: "Accept any of the following characters as separator between integer and decimal part. Note: To format prices use the system preference 'CurrencyFormat'." 2) The explanation near the input field says: Please use the "," as separator : ex "XX,XX", if you want to change it, click here It should explain that other chars are accepted, something like: "Please use any of the following character(s) as decimal separator: ',.'" 3) The part ",if you want to change it..." should be a separate sentence - for better translatability (keep sentences simple) - to hide it if the patron has no permission to edit system preferences -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #24 from Marc Véron <veron(a)veron.ch> --- Created attachment 64675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64675&action=ed… Screenshot rebasing problem Screenshot of text that remained from a merge / rebasing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #23 from Baptiste <baptiste.wojtkowski(a)biblibre.com> --- Rebased -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Baptiste <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62655|0 |1 is obsolete| | --- Comment #22 from Baptiste <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 64674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64674&action=ed… Bug 12310: Format prices on other pages Fields on thoses page are now automatically formatted. - cgi-bin/koha/admin/aqbudgetperiods.tt - cgi-bin/koha/admin/aqbudgets.tt - cgi-bin/koha/members/mancredit.tt - cgi-bin/koha/members/maninvoice.tt -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Baptiste <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61604|0 |1 is obsolete| | --- Comment #21 from Baptiste <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 64673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64673&action=ed… BUG 12310: Modified the tooltips Modified the tooltips helping the users entering monrtary information in the right format. BUG 12310: Corrected the RegExp -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Baptiste <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64671|0 |1 is obsolete| | --- Comment #20 from Baptiste <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 64672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64672&action=ed… BUG 12310 : Modified scripts in order to convert any string to the good format paxed's solution is obsolete since the form asks for a number. The script includes 2 function which check if it is possible to transform properly into the format "XX.XX" and which do it. The money symbols are ignored. All other symbols are ignored. Test plan : 1) Check you can't enter any string except like "XX.XX" when - you create a Budget (Administration->Budget) - you write a fine (Circulation->[select a Borrower]->new fine ) - you pay an existing fine 2) Apply patch 3) Check you can enter any string with - anything you want - a , or a . as separator (both are default) - change the syspref DigitSeparator into the separator you with and check again ex : XXX,XXX,XXX.XX => . XXX XXX XXX,XX => ,. or , XXX XXX XXX.XX => ,. or . The string is immediately changed after you change the field Please note that any other symbole is ignored -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Baptiste <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60563|0 |1 is obsolete| | --- Comment #19 from Baptiste <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 64671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64671&action=ed… BUG 12310 : Modified scripts in order to convert any string to the good format paxed's solution is obsolete since the form asks for a number. The script includes 2 function which check if it is possible to transform properly into the format "XX.XX" and which do it. The money symbols are ignored. All other symbols are ignored. Test plan : 1) Check you can't enter any string except like "XX.XX" when - you create a Budget (Administration->Budget) - you write a fine (Circulation->[select a Borrower]->new fine ) - you pay an existing fine 2) Apply patch 3) Check you can enter any string with - anything you want - a , or a . as separator (both are default) - change the syspref DigitSeparator into the separator you with and check again ex : XXX,XXX,XXX.XX => . XXX XXX XXX,XX => ,. or , XXX XXX XXX.XX => ,. or . The string is immediately changed after you change the field Please note that any other symbole is ignored -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely(a)hotmail.com --- Comment #18 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- *** Bug 17462 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0