June 2017 - Koha-bugs - lists.koha-community.org

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Baptiste <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64671|0 |1 is obsolete| | --- Comment #20 from Baptiste <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 64672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64672&action=ed… BUG 12310 : Modified scripts in order to convert any string to the good format paxed's solution is obsolete since the form asks for a number. The script includes 2 function which check if it is possible to transform properly into the format "XX.XX" and which do it. The money symbols are ignored. All other symbols are ignored. Test plan : 1) Check you can't enter any string except like "XX.XX" when - you create a Budget (Administration->Budget) - you write a fine (Circulation->[select a Borrower]->new fine ) - you pay an existing fine 2) Apply patch 3) Check you can enter any string with - anything you want - a , or a . as separator (both are default) - change the syspref DigitSeparator into the separator you with and check again ex : XXX,XXX,XXX.XX => . XXX XXX XXX,XX => ,. or , XXX XXX XXX.XX => ,. or . The string is immediately changed after you change the field Please note that any other symbole is ignored -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Baptiste <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60563|0 |1 is obsolete| | --- Comment #19 from Baptiste <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 64671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64671&action=ed… BUG 12310 : Modified scripts in order to convert any string to the good format paxed's solution is obsolete since the form asks for a number. The script includes 2 function which check if it is possible to transform properly into the format "XX.XX" and which do it. The money symbols are ignored. All other symbols are ignored. Test plan : 1) Check you can't enter any string except like "XX.XX" when - you create a Budget (Administration->Budget) - you write a fine (Circulation->[select a Borrower]->new fine ) - you pay an existing fine 2) Apply patch 3) Check you can enter any string with - anything you want - a , or a . as separator (both are default) - change the syspref DigitSeparator into the separator you with and check again ex : XXX,XXX,XXX.XX => . XXX XXX XXX,XX => ,. or , XXX XXX XXX.XX => ,. or . The string is immediately changed after you change the field Please note that any other symbole is ignored -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely(a)hotmail.com --- Comment #18 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- *** Bug 17462 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers(a)biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13178] cardnumber field length is too short
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10267 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10267] No error message when entering an invalid cardnumber
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13178 --- Comment #16 from Marc Véron <veron(a)veron.ch> --- Related bug, signed off: Bug 13178 - cardnumber field length is too short It expands the card number length to 32. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10267] No error message when entering an invalid cardnumber
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10267] No error message when entering an invalid cardnumber
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 --- Comment #15 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #14) > Hmm I do not really understand why we need this message. > > You cannot type more than 16 chars or paste them. > There is a hint that it should be between 1 and 16. > Currently, the message shows up at 16 chars. This makes me think that I > entered too much chars, but I did not. > > I think that if we want to do something on this matter, we need to search > for another angle. But I am not convinced that we should; the hint is clear > to me. We could allow more than 16 chars and then mark it red or something ? Owen explains the benefit of a patch like this in Comment 7. It may not be broken and seems very obvious to us, but the point is to make things as clear as possible for the user. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13205] Last/First page options for result list paging
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 --- Comment #9 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 64670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64670&action=ed… Bug 13205: [FOLLOW-UP] Some extra logic See Comment 8. Test: When on first page of results, confirm that the 'First' and 'Previous' buttons do not show. Confirm they come back on the second page and every page after. When on last page of results, confirm that the 'Last' and 'Next' buttons do not show. Confirm they come back on all previous pages. Check on both staff side and OPAC. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13205] Last/First page options for result list paging
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '17

27 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0