June 2017 - Koha-bugs - lists.koha-community.org

[Bug 12145] Lock for Move up buttons with Marc tag
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '17

22 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12145 --- Comment #8 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 64543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64543&action=ed… Bug 12145: Add LockMoveUpButtons syspref to lock subfield positions This patch adds a syspref LockMoveUpButtons to hide the 'move up' buttons by default in the MARC editor. There is also a new option in the settings menu in the MARC editor called 'Lock subfield positions' so users can toggle the 'move up' buttons in the editor. To test: 1) Apply patch and update database 2) Find the LockMoveUpButtons syspref in Admin -> Global system preferences. Confirm it is set to "Don't lock" by default 3) Go to add a new biblio or edit an existing one in cataloguing 4) The Move Up buttons should still be present and work as normal. Click Settings and confirm the 'Lock subfield positions' option is unchecked 5) Click 'Lock subfield positions' to show and hide the buttons 6) Set the LockMoveUpButtons syspref to Lock and refresh the cataloguing editor 7) Confirm the buttons are hidden by default Sponsored-by: Catalyst IT Signed-off-by: Eugene Jose Espinoza for KohaCon2017 <eugenegf(a)yahoo.com> Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12145] Lock for Move up buttons with Marc tag
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '17

22 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12145 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64540|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12145] Lock for Move up buttons with Marc tag
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '17

22 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12145 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64539|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12145] Lock for Move up buttons with Marc tag
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '17

22 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12145 --- Comment #7 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Patch tested with a sandbox, by Israelex A Veleña for KohaCon17 <israelex19(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12145] Lock for Move up buttons with Marc tag
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '17

22 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12145 --- Comment #6 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 64540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64540&action=ed… Bug 12145: [FOLLOW-UP] Separating buttons and tags This patch fixes the issue in Comment 2. The move-up buttons were inside the element that gets hidden when 'Show tags' is off, therefore removing their functionality and making the 'Lock subfield positions' button useless. This patch separates the buttons and the tags into two separate span elements, and adds the appropriate CSS. To test: Confirm that 'Lock subfield positions' still works when 'Show tags' is off. Signed-off-by: Eugene Jose Espinoza for KohaCon2017 <eugenegf(a)yahoo.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12145] Lock for Move up buttons with Marc tag
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '17

22 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12145 --- Comment #5 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 64539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64539&action=ed… Bug 12145: Add LockMoveUpButtons syspref to lock subfield positions This patch adds a syspref LockMoveUpButtons to hide the 'move up' buttons by default in the MARC editor. There is also a new option in the settings menu in the MARC editor called 'Lock subfield positions' so users can toggle the 'move up' buttons in the editor. To test: 1) Apply patch and update database 2) Find the LockMoveUpButtons syspref in Admin -> Global system preferences. Confirm it is set to "Don't lock" by default 3) Go to add a new biblio or edit an existing one in cataloguing 4) The Move Up buttons should still be present and work as normal. Click Settings and confirm the 'Lock subfield positions' option is unchecked 5) Click 'Lock subfield positions' to show and hide the buttons 6) Set the LockMoveUpButtons syspref to Lock and refresh the cataloguing editor 7) Confirm the buttons are hidden by default Sponsored-by: Catalyst IT Signed-off-by: Eugene Jose Espinoza for KohaCon2017 <eugenegf(a)yahoo.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12145] Lock for Move up buttons with Marc tag
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '17

22 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12145 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63906|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12145] Lock for Move up buttons with Marc tag
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '17

22 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12145 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62808|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12145] Lock for Move up buttons with Marc tag
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '17

22 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12145 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes(a)biblibre.com Status|Needs Signoff |Signed Off --- Comment #4 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Patch tested with a sandbox, by Eugene Jose Espinoza for KohaCon2017 <eugenegf(a)yahoo.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15465] README for github
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '17

22 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial --- Comment #17 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Changing importance to trivial from enh, because of the follow-up patch with the typo fix. -- You are receiving this mail because: You are watching all bug changes.

1 0