June 2017 - Koha-bugs - lists.koha-community.org

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '17

22 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55131|0 |1 is obsolete| | --- Comment #65 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 64513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64513&action=ed… Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. This development consider the value of syspref OPACURLOpenInNewWindow when building the link. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are in OPACOpenURLItemTypes). Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" and repeat steps 5 to 7 Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7425] Export Bibliographic Holdings fails if no item records attached
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '17

22 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7425 Hugo Agud <hagud(a)orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud(a)orex.es Resolution|FIXED |--- Status|CLOSED |REOPENED --- Comment #5 from Hugo Agud <hagud(a)orex.es> --- Testing on Debian 8 Koha 16.11.08 it doesn't matter the value on item-level_itypes, it nevers export a biblio record if there is not an item attached -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14803] Rental and fine fees are not updating on circulation screen
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '17

22 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain(a)biblibre.com Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18842] New: When cataloguing 300$a, I get this and that
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '17

22 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18842 Bug ID: 18842 Summary: When cataloguing 300$a, I get this and that Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: paul.poulain(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Im explaining at the kohacon17 how to deal with bugs. not really a bug then -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '17

22 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #131 from David Cook <dcook(a)prosentient.com.au> --- Thanks for the feedback, Josef! I'll try to address it as soon as I can. I have a busy day today, but I'll do my best to get to it. That reminds me that I should double-check the RDF::Query versions for compatibility as well. According to https://packages.qa.debian.org/libr/librdf-query-perl.html, Debian Stretch is on 2.918, which is the same version that I've been using on openSUSE Leap 42.2. But Debian Jessie is on 2.912. I don't know if that will be significant or not, so I'll have to check that later. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18840] New: Unable to delete Duplicate Report Group
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '17

22 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18840 Bug ID: 18840 Summary: Unable to delete Duplicate Report Group Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: jbalway(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Created attachment 64501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64501&action=ed… Page the problem occured and the code that is generating the duplicate. There is a duplicate Serials tab when using a Saved Report. There doesn't seem to be a way to delete one of the duplicate tabs. I viewed the source for the page and found that there's a Report Group "SER" and a group "Serials". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 18835] New: SQL syntax error in overdue_notices.pl
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '17

21 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18835 Bug ID: 18835 Summary: SQL syntax error in overdue_notices.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Caused by bug 17952, an extra / is in the middle of the query. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 14572] insert_single_holiday() forces a value on an AUTO_INCREMENT column, during an INSERT
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '17

21 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14572 Rodrigo Santellan <rsantellan(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rsantellan(a)gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14572] insert_single_holiday() forces a value on an AUTO_INCREMENT column, during an INSERT
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '17

21 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14572 --- Comment #1 from Rodrigo Santellan <rsantellan(a)gmail.com> --- Created attachment 64498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64498&action=ed… Bug 14572 - insert_single_holiday() forces a value on an AUTO_INCREMENT column, during an INSERT Removing all the id from the columns on the inserts and removing the parameter '' of the values for the id. Test plan: 1) Go to tools -> calendar 2) Add a Holiday only on this day. 3) Add a Holiday repeated every same day of the week. 4) Add a Holiday repeated yearly on the same date. 5) Add a Holidays on a range. 6) Add a Holidays repeated yearly on a range. 7) You should have the five calendars displayed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '17

21 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Hugo Agud <hagud(a)orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |hagud(a)orex.es Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18837 --- Comment #54 from Hugo Agud <hagud(a)orex.es> --- HI I have tried to apply the patch on master, but I get an error Applying: Bug 7317: DO NOT PUSH: Update OPAC CSS Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/css/opac.css Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/opac.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/opac.css Failed to merge in the changes. Patch failed at 0001 Bug 7317: DO NOT PUSH: Update OPAC CSS The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-7317-DO-NOT-PUSH-Update-OPAC-CSS-xvmzXj.patch --- Comment #55 from Magnus Enger <magnus(a)libriotech.no> --- Iam ready to sign off on this, when Alex has provided the missing tests (and possibly a rebase). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 [Bug 18837] Add an unmediated Interlibrary Loans workflow -- You are receiving this mail because: You are watching all bug changes.

1 0