June 2017 - Koha-bugs - lists.koha-community.org

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '17

09 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #117 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Comment on attachment 63910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63910 Bug 8612: Use CSV profile for exporting basket Review of attachment 63910: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=861…) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ +310,5 @@ > + my $bd = GetBiblioData( $order->{'biblionumber'} ); > + my @biblioitems = GetBiblioItemByBiblioNumber( $order->{'biblionumber'}); > + for my $biblioitem (@biblioitems) { > + if ($biblioitem->{isbn} eq $order->{isbn}) { > + $order = {%$order, %$biblioitem}; Could you explain these 3 lines? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '17

09 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #42 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- Pushed to 17.05.x, will be in 17.05.01 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12996] Tool to bulk export patrons images
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '17

09 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12996 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5471] Quotes in tags cause moderation approval/rejection to fail
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '17

09 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5471 --- Comment #3 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 64129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64129&action=ed… Bug 5471 - Quotes in tags cause moderation approval/rejection to fail This patch makes changes to the tag moderation template and JavaScript to fix handling of tags with double or single quotes. This patch also moves the tags moderation JavaScript out of the template and into a separate JS file. To test you should have multiple tags awaiting moderation, including tags which contain double and single quotes. - Go to Tools -> Tags. - In the list of tags pending approval, test approving and rejecting tags, including those containing single or double quotes. - The state of the "Approve" or "Reject" buttons should correctly change according to the action you chose. - The label in the status column should update correctly. - In the "Check lists" form, submitting approved, rejected, and unclassified terms should result in the correct message. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5471] Quotes in tags cause moderation approval/rejection to fail
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '17

09 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5471 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5471] Quotes in tags cause moderation approval/rejection to fail
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '17

09 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5471 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 13766] biblioitems.ean field is too short
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '17

09 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 Colin Campbell <colin.campbell(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #6 from Colin Campbell <colin.campbell(a)ptfs-europe.com> --- (In reply to Frédéric Demians from comment #4) > (In reply to Jonathan Druart from comment #3) > > Frédéric, I got an error on executing the updatedb entry: > > > > DBD::mysql::db do failed: BLOB/TEXT column 'ean' used in key specification > > without a key length at installer/data/mysql/updatedatabase.pl line 9798. > > Thanks testing. I also can get this error. I don't have it on recent DB. I > get it on older. > > In updatedatebase.pl, line 5323: > > $dbh->do("CREATE INDEX `ean` ON biblioitems (`ean`) "); > > So a DB which was on Koha 3.8, and earlier, has an index on biblioitems.ean. > > A fresh DB, hasn't such an index. kohastructre.sql, line 186 and after, > there are index defined for isbn but not for ean. > > Do you think that an index is required on ean field? Yes it should, like isbn, issn be indexed. It could be an important field if the library (like most publics) has a large dvd collection. The short size and lack of key is a problem if trying to do checks against this field -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '17

09 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #57 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 64126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64126&action=ed… Bug 14570 - Update Schema -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '17

09 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #56 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 64125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64125&action=ed… Bug 14570 - Followup Fix small errors in update child script Signed-off-by: Kim Peine <kmpeine(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '17

09 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62450|0 |1 is obsolete| | Attachment #62451|0 |1 is obsolete| | Attachment #62452|0 |1 is obsolete| | --- Comment #55 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 64124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64124&action=ed… Bug 14570 - Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t Signed-off-by: Kim Peine <kmpeine(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0