June 2017 - Koha-bugs - lists.koha-community.org

[Bug 7520] json script to return advanced search types
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '17

08 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #26 from M. Tompsett <mtompset(a)hotmail.com> --- I'm going to be picky about the License. The DBIx vs DBI suggestions probably could slide, though QA might fault you. Also, rather than assume the DB's have category codes and branches, consider the use of TestBuilder. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7520] json script to return advanced search types
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '17

08 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520 --- Comment #25 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 60539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60539 bug_7520 Added Meta handler to API v1 for metadata lists Review of attachment 60539: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=752…) ----------------------------------------------------------------- ::: Koha/REST/V1/Meta.pm @@ +12,5 @@ > +# A PARTICULAR PURPOSE. See the GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License along > +# with Koha; if not, write to the Free Software Foundation, Inc., > +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Since this is new, please use https://wiki.koha-community.org/wiki/Coding_Guidelines#Licence ::: t/db_dependent/api/v1/meta.t @@ +12,5 @@ > +# A PARTICULAR PURPOSE. See the GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License along > +# with Koha; if not, write to the Free Software Foundation, Inc., > +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Since this is new, please use https://wiki.koha-community.org/wiki/Coding_Guidelines#Licence @@ +32,5 @@ > +my $builder = t::lib::TestBuilder->new(); > + > +my $dbh = C4::Context->dbh; > +$dbh->{AutoCommit} = 0; > +$dbh->{RaiseError} = 1; This isn't necessary, since you can do it with the schema. No sense switching between DBI and DBIx ways of doing things. It gets ugly if they conflict. @@ +37,5 @@ > + > +my $t = Test::Mojo->new('Koha::REST::V1'); > + > +my $categorycode = Koha::Database->new()->schema()->resultset('Category')->first()->categorycode(); > +my $branchcode = Koha::Database->new()->schema()->resultset('Branch')->first()->branchcode(); my $schema = Koha::Database->new()->schema(); $schema->storage->txn_begin(); Then use $schema for the categorycode and branchcode. @@ +77,5 @@ > + ->json_has('/types/0/code') > + ->json_has('/types/0/description') > + ->json_has('/types/0/imageurl'); > + > +$dbh->rollback; $schema->storage->txn_rollback(); -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3137] Add sys pref to collapse areas of the patron add by default
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '17

08 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 --- Comment #6 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 64094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64094&action=ed… Bug 3137: [FOLLOW-UP] Remove checkboxes, add collapsing sections This patch removes the checkboxes from my previous patch and adds collapsing/uncollapsing sections. Follow the above test plan until step 6. The fields selected in HideFieldsAddPatronForm will still be hidden, but can now be shown and collapsed again (as well as all other sections) much more easily and without scrolling. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 3137] Add sys pref to collapse areas of the patron add by default
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '17

08 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '17

07 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Philippe Audet-Fortin <philippe.audet-fortin(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64088|0 |1 is obsolete| | --- Comment #78 from Philippe Audet-Fortin <philippe.audet-fortin(a)inlibro.com> --- Created attachment 64089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64089&action=ed… Bug 11317 - Update the link under reports Signed-off-by: Paudet <philippe.audet-fortin(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '17

07 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #77 from Philippe Audet-Fortin <philippe.audet-fortin(a)inlibro.com> --- Created attachment 64088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64088&action=ed… Bug 11317 - Update the link under reports -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9188] Remove 'debug' information from patron statistics
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '17

07 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9188 --- Comment #10 from M. Tompsett <mtompset(a)hotmail.com> --- P.S. This does NOT fix the row/column not fully selected problem, as that is beyond scope. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9188] Remove 'debug' information from patron statistics
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '17

07 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9188 --- Comment #9 from M. Tompsett <mtompset(a)hotmail.com> --- If you believe the counter patch is good, obsolete the first patch and sign off the second. If you believe there is need for more discussion, discuss away. Do not apply both patches, just one or the other. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9188] Remove 'debug' information from patron statistics
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '17

07 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9188 --- Comment #8 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 64087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64087&action=ed… Bug 9188: counter patch -- just meaningful filter information TEST PLAN --------- run patron statistics without filtering -- notice lots of text at top. run patron statistics with filtering -- notice lots of text at top. apply patch run it without and without filtering -- amount of text should be small or none and be related to the filtering selected. run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9188] Remove 'debug' information from patron statistics
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '17

07 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9188 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com Status|Needs Signoff |In Discussion --- Comment #7 from M. Tompsett <mtompset(a)hotmail.com> --- I agree the top part is messy. However, I believe the things which are not filtered expressly don't need to be listed. For example, I chose a particular category code and branch code, and there would have been no way to know the branch code without the mess at the top. And yes, it was just a single number. I agree the Query parts are rather pointless. I think if you choose a row and column, there is no need to display a value for either the row or column unless it is filtered to that value. This means there should only be two lines at most at the top. As such, I don't think this patch is the correct way to do it. -- You are receiving this mail because: You are watching all bug changes.

1 0