July 2017 - Koha-bugs - lists.koha-community.org

[Bug 14039] Add patron title to checkout screen
by bugzilla-daemon＠bugs.koha-community.org 14 Jul '17

14 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi David, I think you can fix it easily - just make the id a class. If you have multiple elements with the same id on a page, this will cause problems, for example you will not be able to target them with jQuery in my experience. So Jonathan is right that we might want to be careful here. class attributes can appear many times and will work nicely here to be on the safe side. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14039] Add patron title to checkout screen
by bugzilla-daemon＠bugs.koha-community.org 14 Jul '17

14 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 --- Comment #15 from David Roberts <david.roberts(a)ptfs-europe.com> --- The only reason I added an id was because it failed QA without one. Now it's failed QA with one! Can't win. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Allow correct handling of plural translation
by bugzilla-daemon＠bugs.koha-community.org 14 Jul '17

14 Jul '17

1 0

[Bug 15395] Allow correct handling of plural translation
by bugzilla-daemon＠bugs.koha-community.org 14 Jul '17

14 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #53 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- This patchset includes a new perl dep: Locale::Util. You call set_locale two times. I am not sure if it is packaged for Debian; could not find it so quickly. Should be added to PerlDependencies? Also do we really need it? Can we use POSIX instead, or do without it, construct it some other way ?? Glancing through CPAN, I note: It is not the recommended way to set the program locale for a regular application. Changing status to reflect need for feedback. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 14 Jul '17

14 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #29 from Colin Campbell <colin.campbell(a)ptfs-europe.com> --- Yes this newer patch doesnt address the underlying problem identified above. So that it returns to the random situation of manifesting in some cases and not others -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 14 Jul '17

14 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #28 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Spent some time on this one and it is still confusing. With and without this patch I got back in AF: AFItem is reserved for another patron upon return.| Also saw this in log: Jul 14 09:52:05 master koha_sip[31568]: Blocking checkout Reason:rescardnumber Jul 14 09:52:05 master koha_sip[31568]: Blocking checkout Reason:resbranchcode Jul 14 09:52:05 master koha_sip[31568]: Blocking checkout Reason:ressurname Jul 14 09:52:05 master koha_sip[31568]: Blocking checkout Reason:resborrowernumber Jul 14 09:52:05 master koha_sip[31568]: Blocking checkout Reason:resfirstname Jul 14 09:52:05 master koha_sip[31568]: Blocking checkout Reason:resreservedate My conclusion sofar: The problem is in the hash from CanBookBeIssued. The way we loop through this hash now in sub do_checkout will not (always) resolve the problem. It just depends on what comes first in the hash and fills screen_msg. Instead of looping thru all entries, we should probably test for exists RESERVED or exists RESERVED_WAITING etc. etc. Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7374] can't upload icon for auth values
by bugzilla-daemon＠bugs.koha-community.org 14 Jul '17

14 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Dilan Johnpullé <dilan(a)calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64916|0 |1 is obsolete| | Attachment #64917|0 |1 is obsolete| | --- Comment #7 from Dilan Johnpullé <dilan(a)calyx.net.au> --- Created attachment 65036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65036&action=ed… Bug 7374: Can't upload icon for auth values Fixes a bug which prevents the delivered images being selected. Works as expected in line with test plan above. Signed-off-by: Dilan Johnpullé <dilan(a)calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7374] can't upload icon for auth values
by bugzilla-daemon＠bugs.koha-community.org 14 Jul '17

14 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Dilan Johnpullé <dilan(a)calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 14 Jul '17

14 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #30 from M. Tompsett <mtompset(a)hotmail.com> --- Bug 17829 means the C4::Member::GetMember logic here doesn't work. Tweaking. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 14 Jul '17

14 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17829 -- You are receiving this mail because: You are watching all bug changes.

1 0