July 2017 - Koha-bugs - lists.koha-community.org

[Bug 14039] Add patron title to checkout screen
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '17

13 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Comment on attachment 64077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64077 [SIGNED-OFF] Bug 14039 - Add patron salutation to checkout screen Review of attachment 64077: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=140…) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc @@ +5,4 @@ > [%- IF invert_name %] > [%- borrower.surname | html %], [% borrower.firstname | html %] [% IF borrower.othernames %] ([% borrower.othernames | html %]) [% END %] > [%- ELSE %] > + [% IF borrower.title %] <span id="patron-title">[%- borrower.title | html %] </span>[% END %][%- borrower.firstname | html %] [% IF borrower.othernames %] ([% borrower.othernames | html %]) [% END %] [% borrower.surname | html %] I do not think it's a good idea to have an id here, there are certainly places where this include file is used several times. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15404] CanBookBeReserved: No count of biblio level holds if ReservesControlBranch is item' s home library
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '17

13 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15404 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18935] New: MARC::Record-> new_from_usmarc does not handle UNIMARC records
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '17

13 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18935 Bug ID: 18935 Summary: MARC::Record->new_from_usmarc does not handle UNIMARC records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: baptiste.wojtkowski(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org The problem related by Bug 18533 is also concerning all calls to MARC::Record->new_from_usmarc (this function uses MARC::Record->encoding). All imported marc notice from z3950 with 18152 active (versions after 16.11) are not considered as UTF-8 anymore by MARC::Record->new_from_usmarc and are also false encoded when imported in Koha. Example of problematic call: cataloguing/addbiblio.pl 85 my $record = MARC::Record->new_from_usmarc($marc); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '17

13 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #139 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to David Cook from comment #133) > > 2) Could you elaborate on the style issues? I went to > https://wiki.koha-community.org/wiki/QA_Test_Tools, but the configure > dependency step is risky and it looks set up to be used on Debian (and I'm > on openSUSE although I should try out kohadevbox again) so I might hold off > trying the tools for now. > No problem, here is relevant output from qa tools: FAIL Koha/Daemon.pm FAIL critic "$fh" is declared but not used at line 78, column 14. Unused variables clutter code and make it harder to read. Bareword file handle opened at line 64, column 18. See pages 202,204 of PBP. FAIL Koha/OAI/Harvester.pm FAIL critic Variable declared in conditional statement at line 291, column 9. Declare variables outside of the condition. FAIL pod =head3 without preceding higher level in file Koha/OAI/Harvester.pm FAIL Koha/OAI/Harvester/Downloader.pm FAIL pod in file Koha/OAI/Harvester/Downloader.pm =head2 without preceding higher level FAIL Koha/OAI/Harvester/Import/RDFXML.pm FAIL critic Variable declared in conditional statement at line 110, column 5. Declare variables outside of the condition. FAIL forbidden patterns forbidden pattern: tab char (line 32) FAIL Koha/OAI/Harvester/Import/Record.pm FAIL critic Variable declared in conditional statement at line 325, column 17. Declare variables outside of the condition. Variable declared in conditional statement at line 262, column 13. Declare variables outside of the condition. "return" statement with explicit "undef" at line 145, column 41. See page 199 of PBP. Variable declared in conditional statement at line 252, column 5. Declare variables outside of the condition. FAIL forbidden patterns forbidden pattern: tab char (line 152) forbidden pattern: tab char (line 156) forbidden pattern: tab char (line 142) forbidden pattern: tab char (line 139) forbidden pattern: tab char (line 136) forbidden pattern: tab char (line 384) forbidden pattern: tab char (line 380) forbidden pattern: tab char (line 140) forbidden pattern: tab char (line 141) forbidden pattern: tab char (line 151) forbidden pattern: tab char (line 155) forbidden pattern: tab char (line 149) forbidden pattern: tab char (line 154) forbidden pattern: tab char (line 153) forbidden pattern: tab char (line 138) forbidden pattern: tab char (line 150) forbidden pattern: tab char (line 137) FAIL pod in file Koha/OAI/Harvester/Import/Record.pm =head3 without preceding higher level empty =head3 FAIL Koha/OAI/Harvester/Request.pm FAIL forbidden patterns forbidden pattern: tab char (line 69) forbidden pattern: tab char (line 191) forbidden pattern: tab char (line 189) forbidden pattern: tab char (line 181) forbidden pattern: tab char (line 188) forbidden pattern: tab char (line 193) forbidden pattern: tab char (line 104) forbidden pattern: tab char (line 98) forbidden pattern: tab char (line 77) forbidden pattern: tab char (line 113) forbidden pattern: tab char (line 183) forbidden pattern: tab char (line 184) forbidden pattern: tab char (line 89) forbidden pattern: tab char (line 185) forbidden pattern: tab char (line 101) forbidden pattern: tab char (line 190) forbidden pattern: tab char (line 83) forbidden pattern: tab char (line 102) forbidden pattern: tab char (line 70) forbidden pattern: tab char (line 78) forbidden pattern: tab char (line 95) forbidden pattern: tab char (line 194) forbidden pattern: tab char (line 107) forbidden pattern: tab char (line 76) forbidden pattern: tab char (line 80) forbidden pattern: tab char (line 108) forbidden pattern: tab char (line 182) forbidden pattern: tab char (line 99) forbidden pattern: tab char (line 109) forbidden pattern: tab char (line 66) forbidden pattern: tab char (line 97) forbidden pattern: tab char (line 106) forbidden pattern: tab char (line 103) forbidden pattern: tab char (line 112) forbidden pattern: tab char (line 93) forbidden pattern: tab char (line 170) forbidden pattern: tab char (line 111) forbidden pattern: tab char (line 105) forbidden pattern: tab char (line 192) forbidden pattern: tab char (line 114) forbidden pattern: tab char (line 90) forbidden pattern: tab char (line 110) forbidden pattern: tab char (line 187) forbidden pattern: tab char (line 79) forbidden pattern: tab char (line 186) forbidden pattern: tab char (line 115) forbidden pattern: tab char (line 92) forbidden pattern: tab char (line 94) forbidden pattern: tab char (line 91) forbidden pattern: tab char (line 100) forbidden pattern: tab char (line 96) FAIL installer/data/mysql/kohastructure.sql FAIL charset_collate The table oai_harvester_requests does not have the current charset collate (see bug 11944) FAIL koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc FAIL forbidden patterns forbidden pattern: tab char (line 102) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/oai-pmh-harvester/dashboard.tt FAIL forbidden patterns forbidden pattern: Do not use line breaks inside template tags (bug 18675) (line 308) forbidden pattern: Do not use line breaks inside template tags (bug 18675) (line 287) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '17

13 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #138 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Josef Moravec from comment #129) > > Not tested RDF harvesting, as I had no luck to install Fuseki properly :( If you're unable to install it, perhaps Magnus Enger can give you an account to his Fuseki instance? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '17

13 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #137 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 65019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65019&action=ed… Use old style of UUID generation -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '17

13 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #136 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 65018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65018&action=ed… Standardize OAI-PMH test success/failure -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '17

13 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #135 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 65017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65017&action=ed… Fix configuration typo for Debian instances -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '17

13 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #134 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 65016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65016&action=ed… Add RDF::Query dependency -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '17

13 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #133 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Josef Moravec from comment #129) > Started testing, from first view I can see these issues: > > 1) RDF::Query is not in dependencies but used in various files > > 2) There are some style issues etc, could be catched easily by qa tools > > 3) Module UUID (package libuuid-perl) is packaged in version 0.05 for > jessie, but version 0.27 needed as you use the sub "uuid", this version is > packaged for stretch (which is released for few days now) > > 4) You use oai-pmh-harvester.yaml filename everywhere, but in > /debian/templates/koha-conf-site.xml.in it is 'oai_pmh_harvester.yaml' (with > underscores) - should be consistant > > 5) The message "Test succesfull!" should be more visible, you could use > "dialog message" classes to make it standard koha message > > > But the main think is: It does work well! ;) > > Not tested RDF harvesting, as I had no luck to install Fuseki properly :( 1) Ok, I'll add the RDF::Query dependency in a new patch. 2) Could you elaborate on the style issues? I went to https://wiki.koha-community.org/wiki/QA_Test_Tools, but the configure dependency step is risky and it looks set up to be used on Debian (and I'm on openSUSE although I should try out kohadevbox again) so I might hold off trying the tools for now. 3) I only use uuid() in two places, so I'll go back and make those bits compatible with UUID 0.05. 4) I'll add that to a new patch as well. Thanks for catching that one! 5) Makes sense! I've split the difference and done both, and added to a new patch! -- You are receiving this mail because: You are watching all bug changes.

1 0