August 2017 - Koha-bugs - lists.koha-community.org

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '17

22 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #14 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 66324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66324&action=ed… [SIGNED-OFF] Bug 4461: [FOLLOW-UP] Problem Report feature This patch: - uses a pull down menu to switch the recipient instead of tabs - if the library has no email or the administrator has no email, this error message has been moved to be down by the Submit button - includes use of branchreplyto and ReplytoDefault for branch email - disables use of the feature if the user is not logged in - adds a syspref to hide or show the feature - provides support for if JS is disabled Additional testing: - using the message_queue table, check that the correct recipient receives a problem report when switching in the drop down menu - check appropriate error message shows next to the submit button if an email is not provided. this should dynamically change as you select a different recipient from the drop down menu - check that when the library is the recipient, the feature sends the report to the branchreplyto, then the ReplytoDefault, then the branch email in that priority order - log out of the OPAC and confirm that you can't submit a report without logging in. the submit button should be disabled - disable the OPACReportProblem syspref. the Report a Problem link in the footer should be gone. if you force the URL (/cgi-bin/koha/opac-reportproblem.pl) the form should be hidden and replaced with an error message. - disable JS in your browser. confirm that you are still able to send problem reports to library and administrator. remove the administrator email address. confirm the error message shows next to the submit button and that clicking the submit button returns an error. check in the message_queue that the email was never sent. After this feature is passed: - i would like to add a staff-side feature where staff can see the problem reports and mark them as 'read'. i'll work on that once this gets through :) Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '17

22 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61654|0 |1 is obsolete| | Attachment #66253|0 |1 is obsolete| | --- Comment #13 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 66323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66323&action=ed… [SIGNED-OFF] Bug 4461: Add a context-sensitive 'Report a Problem' feature to OPAC This patch adds a 'Report a problem' link to the bottom of every page in the OPAC. The user can choose to submit their report to the library or Koha administrator. The report will store the user's problem message, but also their username and the page they were on when they clicked the 'report a problem' link. The patch adds a table 'problem_reports' to the db. Update: This patch adds a check for the KohaAdminEmailAddress and library branch email before sending the report. Update: Fix merge conflicts To test: 1) Apply patch, update database, rebuild schema 2) Restart koha-common and memcached 3) Confirm that your user has an email address. 4) Confirm that your library does NOT have an email address. 5) Confirm that your syspref KohaAdminEmailAddress is NOT filled. 6) Log into OPAC 7) Click the 'Report a problem' link at the bottom of whatever page you're on 8) Notice that there are error messages alerting that library does not have an email address and that the Koha Administrator does not have email address. Both submit buttons will be disabled. 9) Add an email address for your library. You may have to restart memcached again. The error message for the library email address will have disappeared and the Submit button for 'Report to library' will now work. 10) Add an email address for the syspref KohaAdminEmailAddress. You may have to restart memcached again. The error message for the administrator email address will have disappeared and the Submit button for 'Report to Koha Administrator' will not work. 11) First try submitting a problem to the library. Confirm that the fields for 'Problem found on page' and 'Username' are correct, then fill out the 'Subject' and 'Message' and click Submit. 12) Confirm a message shows at the top of the page to show success. 13) Go into mysql and display records from the message_queue table. Confirm that the borrowernumber and subject are correct. Confirm that content shows the message from the problem report, but also the user's username and the problem page. Confirm that the to_address shows the library's email address and the from_address shows the user's email address. 14) Now try submitting a problem to the Koha Admin. Fill fields and click Submit. Confirm message shows at top to show success again. 15) Check message_queue for new problem report. Confirm that the to_address shows the email address from the syspref KohaAdminEmailAddress. Sponsored-by: Catalyst IT Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '17

22 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '17

22 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #58 from Josef Moravec <josef.moravec(a)gmail.com> --- Some comments from QA test tools, sorry FAIL C4/Reserves.pm FAIL valid "my" variable $holds masks earlier declaration in same scope FAIL reserve/request.pl FAIL valid "my" variable $holds masks earlier declaration in same scope FAIL t/db_dependent/Holds.t FAIL valid "my" variable $holds masks earlier declaration in same scope FAIL t/db_dependent/Reserves.t FAIL valid "my" variable $holds masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5534] Koha does not ignore punctuation when searching
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '17

22 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5534 --- Comment #18 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to dguidry from comment #17) > We originally installed Koha around May or June of 2016 and would have been > on the 3.22 version that was released at that time. We used defaults for > everything as far as I remember and it appears that we're using Zebra. Is it > possible to switch to ElasticSearch and is it fairly involved to do so? Are > there any other considerations to take into account before doing so? Is > ElasticSearch production-ready? > > Thanks! Elasticsearch is still in testing phase I would say,there are a few things that need to be cleaned up to be production ready, most of them are small issues, but together they would cause some pain points. Most of them relate to indexing configuration and Koha expectations - if you don't define expected fields sortable - sorting causes a failed search for example Setting it up should be fairly straight forward - Mirko has put together a 'koha-elasticsearch' package which will install needed dependencies for koha, and you will need to install Java and Elasticsearch itself. I will work on some of the issues in the coming weeks and update the status page on the wiki and send something to the list. We do need testers and are working on enabling ES on some sandboxes and will update when that work is ready. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '17

22 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Hugo Agud <hagud(a)orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud(a)orex.es --- Comment #21 from Hugo Agud <hagud(a)orex.es> --- Hi, this is a nice feature.. just a couple of questions a super user always is able to see all pages right? at least this is what it happens to us. be aware of children pages should have a greater order than parents if not, they will be published as children of other links... for example we have 3 pages 2 root and one children... if the order of children is lower than parent. it appears as children of the other like this root1 . children_of_root_2 root2 I can't see where pages are published in staff. in opac we see them in opacnav The links are not published in opac account page, right? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '17

22 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Hugo Agud <hagud(a)orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |hagud(a)orex.es --- Comment #14 from Hugo Agud <hagud(a)orex.es> --- 56613 - Bug 14367: Add MARC record history 64243 - Bug 14367: [FOLLOW-UP] Fixing merge conflicts... Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14367: Add MARC record history Using index info to reconstruct a base tree... M C4/Biblio.pm M cataloguing/addbiblio.pl M koha-tmpl/intranet-tmpl/prog/css/addbiblio.css M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt M koha-tmpl/intranet-tmpl/prog/js/cataloging.js <stdin>:376: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/cataloging.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Auto-merging koha-tmpl/intranet-tmpl/prog/css/addbiblio.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/addbiblio.css Auto-merging cataloguing/addbiblio.pl CONFLICT (content): Merge conflict in cataloguing/addbiblio.pl Auto-merging C4/Biblio.pm CONFLICT (content): Merge conflict in C4/Biblio.pm Failed to merge in the changes. Patch failed at 0001 Bug 14367: Add MARC record history The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14367-Add-MARC-record-history-6jWpQA.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2093] Add OPAC dashboard for logged-in users
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '17

22 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 Hugo Agud <hagud(a)orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud(a)orex.es Status|Needs Signoff |Signed Off --- Comment #13 from Hugo Agud <hagud(a)orex.es> --- patch tested and it works fine! but test fail Test Summary Report ------------------- t/Creators.t (Wstat: 6400 Tests: 39 Failed: 0) Non-zero exit status: 25 Parse errors: Bad plan. You planned 41 tests but ran 39. Files=98, Tests=7437, 238 wallclock secs ( 1.18 usr 0.18 sys + 217.40 cusr 4.47 csys = 223.23 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '17

22 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #106 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 66303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66303&action=ed… Bug 14385: Added missing 'my' -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '17

22 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #105 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 66302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66302&action=ed… Bug 14385: Trigger the C4::ILSDI::Services changes prove t/db_dependent/ILSDI_Services.t -- You are receiving this mail because: You are watching all bug changes.

1 0